[Bug 202820] Review Request: libconfuse - A configuration file parser library

2008-07-07 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libconfuse - A configuration file parser library


https://bugzilla.redhat.com/show_bug.cgi?id=202820


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium
Product|Fedora Extras   |Fedora
Version|devel   |rawhide




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 202820] Review Request: libconfuse - A configuration file parser library

2006-08-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libconfuse - A configuration file parser library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202820


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




--- Additional Comments From [EMAIL PROTECTED]  2006-08-23 23:17 EST ---
Whoops, forgot to close this out...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 202820] Review Request: libconfuse - A configuration file parser library

2006-08-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libconfuse - A configuration file parser library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202820





--- Additional Comments From [EMAIL PROTECTED]  2006-08-17 09:35 EST ---
(In reply to comment #5)
 New record for quickest review approval ? :-)

I was wondering that myself. :p

(In reply to comment #6)
 It was carefully prepared so the formal part was easy for me.

I do put quite a bit of effort into trying to make the reviewer's job as easy as
possible (and its a relativley simple package). :)

 PS: you should close the bug now

Not quite yet, still waiting on the FC5 branch to be created. Once that's done,
I'll close it.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 202820] Review Request: libconfuse - A configuration file parser library

2006-08-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libconfuse - A configuration file parser library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202820


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 202820] Review Request: libconfuse - A configuration file parser library

2006-08-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libconfuse - A configuration file parser library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202820





--- Additional Comments From [EMAIL PROTECTED]  2006-08-16 15:29 EST ---
- there is a missing defattr line in the devel package
- the devel package should go into Development/Libraries instead of System
Environment/Libraries
otherwise it looks good

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 202820] Review Request: libconfuse - A configuration file parser library

2006-08-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libconfuse - A configuration file parser library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202820





--- Additional Comments From [EMAIL PROTECTED]  2006-08-16 15:41 EST ---
Thanks for poking at it, both issues are remedied in a -2 build:

http://wilsonet.com/packages/libconfuse/libconfuse.spec
http://wilsonet.com/packages/libconfuse/libconfuse-2.5-2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 202820] Review Request: libconfuse - A configuration file parser library

2006-08-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libconfuse - A configuration file parser library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202820


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2006-08-16 15:51 EST ---
Review:
- no rpmlint output on any package
- package name OK
- spec file name OK, is in English and is legible
- package meets the Packaging Guidelines
- license OK (LGPL) and is included
- source matches upstream
4bc9b73d77ebd571ac834619ce0b3582  confuse-2.5.tar.gz
4bc9b73d77ebd571ac834619ce0b3582  confuse-2.5.tar.gz.1
- compiles and builds at least on i386 (FC4 and devel)
- BuildRequires are correct
- localized files are handled with %find_lang
- has shared lib with appropriate ldconfig calls
- does not create any directory
- no duplicates files, permissions are set properly, uses %defattr
- has %clean section
- consistent use of macros
- contains code
- no large docs, %doc is not required during runtime
- devel subpackage required and present, contains pkgconfig file
- no .la libtool archives
- not a GUI application
- it works

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 202820] Review Request: libconfuse - A configuration file parser library

2006-08-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libconfuse - A configuration file parser library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202820





--- Additional Comments From [EMAIL PROTECTED]  2006-08-16 16:22 EST ---
Thanks much, package imported and built for devel branch, FC5 branch pending.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 202820] Review Request: libconfuse - A configuration file parser library

2006-08-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libconfuse - A configuration file parser library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202820





--- Additional Comments From [EMAIL PROTECTED]  2006-08-16 18:03 EST ---
New record for quickest review approval ? :-)

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 202820] Review Request: libconfuse - A configuration file parser library

2006-08-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: libconfuse - A configuration file parser library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=202820





--- Additional Comments From [EMAIL PROTECTED]  2006-08-17 01:29 EST ---
It was carefully prepared so the formal part was easy for me.

PS: you should close the bug now

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review