[Bug 211214] Review Request: mod_revocator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_revocator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211214 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||241927 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211214] Review Request: mod_revocator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_revocator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211214 --- Additional Comments From [EMAIL PROTECTED] 2006-11-12 16:08 EST --- Source URL fixed. /usr/lib/librevocation.so.0 is linked to the binary ldapget which is why ldconfig is run. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211214] Review Request: mod_revocator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_revocator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211214 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-11-12 21:51 EST --- ok, the Source url works for me now... The md5sum matches: 07307d8972e3442fd81d84e3852611c5 mod_revocator-1.0.2.tar.gz 07307d8972e3442fd81d84e3852611c5 mod_revocator-1.0.2.tar.gz.1 That was the last blocker I see, so this package is APPROVED. Don't forget to close this NEXTRELEASE once it's been imported and built. Also, consider reviewing another waiting package to help spread out the reviewing load. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 211214] Review Request: mod_revocator
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mod_revocator https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211214 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-11-12 00:30 EST --- Here's a review: OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (Apache) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. See below - Sources match upstream md5sum: OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. See below - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. x86_64/i386 - Should build on all supported archs OK - Should have dist tag OK - Should package latest version Issues: 1. The Source url doesn't seem to be working... I get a 404 from it. 2. rpmlint says: W: mod_revocator devel-file-in-non-devel-package /usr/lib/librevocation.so This can be ignored if httpd is loading it directly as you mention... 3. If the /usr/lib/librevocation.so file is directly loaded by httpd, are the ldconfig calls even needed in post/postun? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
