[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-07-12 11:22 EST --- Package Change Request == Package Name: limph New Branches: EL-4 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-12 12:51 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 07:41 EST --- Build in devel. Will build in FC-6/5 when branches are complete. Closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:01 EST --- Imported, owners.list updated, branches requested. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2007-01-10 12:23 EST --- So I'm sponsored in cvsextras (thank you!), I've got the various certs, CVS and plague set up. However: [EMAIL PROTECTED] cvs]$ cvs co common Permission denied (publickey,keyboard-interactive). cvs [checkout aborted]: end of file from server (consult above messages if any) Any thoughts? I'm using limb as the username in my cvsroot env entry in .bash_profile, and not [EMAIL PROTECTED] I've tried both, however. I'm guessing limb is correct due to syntax (I'm a Subversion user and emarrasingly new to CVS). Has my new permission status just not propagated yet? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2007-01-09 14:07 EST --- It's been over a month since the last action on this review, mine or otherwise. I recognize that we're just coming off the holidays, but this http://fedoraproject.org/wiki/Extras/Policy/StalledReviews would seem indicate that this review is stalled. I think I've fulfilled the stated requests, and welcome correction if I have not. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Limph - PHP network host monitor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830
--- Additional Comments From [EMAIL PROTECTED] 2007-01-09 14:27 EST ---
Sorry for the delay. On travel and then the holidays.
- $ rpmlint -i limph-hostagent-1.9.4-1.fc6.noarch.rpm
E: limph-hostagent executable-marked-as-config-file
/etc/cron.hourly/limph-hostagent
Executables must not be marked as config files because that may
prevent upgrades from working correctly. If you need to be able to
customize an executable, make it for example read a config file in
/etc/sysconfig.
- You're still creating the tmp dir:
mkdir -p %{buildroot}%{limphdir}/tmp
- Both limph and limph-hostagent own /usr/share/limph/host_agent.php. You need
an %exclude in the limph files section.
- Does limph-hostagent require limph to run? Looks like it does need
config.php. Add the appropriate requires.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2007-01-09 14:43 EST --- Thanks for the quick response. I've addressed the config and tmp issues, and the exclude. Limph-hostagent does not require Limph to run, it includes it's own config.php. Is this a problem? Do they need to be in two seperate places, like /etc/limph and /etc/limph-hostagent for example? Links to the current versions: Spec URL: http://gryffindor.jcomserv.net/extras/limph/limph-4.spec SRPM URL: http://gryffindor.jcomserv.net/extras/limph/limph-1.9.4-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2007-01-09 15:23 EST --- But both limph and limph-hostagent use and own the same config file. This is not allowed. What you could do is create limph-common to own /etc/limph/config.php and have both limph and limph-hostagent require that. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2007-01-09 15:41 EST --- I see. I've done that. Now rpmlint -i is clean for all 3. Links to the current versions: Spec URL: http://gryffindor.jcomserv.net/extras/limph/limph-5.spec SRPM URL: http://gryffindor.jcomserv.net/extras/limph/limph-1.9.4-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Limph - PHP network host monitor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830
--- Additional Comments From [EMAIL PROTECTED] 2007-01-09 15:54 EST ---
Requires should be:
Requires: limph-common = %{version}-%{release}
And one more problem, %limphdir needs to be owned by limph-common as well and
not by limph.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2007-01-09 16:08 EST --- Ok. Does this do it for %limphdir? I think I specified the files and the directory properly. I also re-included the config.php symlink. Spec URL: http://gryffindor.jcomserv.net/extras/limph/limph-6.spec SRPM URL: http://gryffindor.jcomserv.net/extras/limph/limph-1.9.4-4.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Limph - PHP network host monitor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830
--- Additional Comments From [EMAIL PROTECTED] 2007-01-09 16:13 EST ---
In main %files section, should be:
%{limphdir}/*
so it doesn't own the directory.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2007-01-09 16:19 EST --- So like this?: Spec URL: http://gryffindor.jcomserv.net/extras/limph/limph-7.spec SRPM URL: http://gryffindor.jcomserv.net/extras/limph/limph-1.9.4-5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-09 16:35 EST --- That's the ticket. Good: - rpmlint checks return nothing - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Limph - PHP network host monitor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830
--- Additional Comments From [EMAIL PROTECTED] 2007-01-09 17:17 EST ---
* %{_sysconfdir}/limph/ is not included
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Limph - PHP network host monitor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830
--- Additional Comments From [EMAIL PROTECTED] 2007-01-09 17:19 EST ---
(In reply to comment #18)
* %{_sysconfdir}/limph/ is not included
Gah, thanks Michael!
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2007-01-09 22:03 EST --- Spec URL: http://gryffindor.jcomserv.net/extras/limph/limph-8.spec SRPM URL: http://gryffindor.jcomserv.net/extras/limph/limph-1.9.4-6.src.rpm Done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2006-12-12 09:18 EST --- Is there anything further I need to do here, or were my most recent changes sufficient? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Limph - PHP network host monitor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830
--- Additional Comments From [EMAIL PROTECTED] 2006-11-27 14:00 EST ---
Thanks, terribly helpful patch. I've applied it, released upstream version
1.9.4 to address the config file, tmp dir and tarball issues, updated spec
accordingly, rebuilt, and posted the results:
Spec URL: http://gryffindor.jcomserv.net/extras/limph/limph-3.spec
SRPM URL: http://gryffindor.jcomserv.net/extras/limph/limph-1.9.4-1.src.rpm
(In reply to comment #3)
Created an attachment (id=141960)
--
(https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=141960action=view)
[edit]
patch to spec file
Here's a patch that resolves some issues.
To fix the tar ball issue:
%setup -q -n %{name}
Then go back to %setup -q when you fix that.
Other issues:
- still got some config files in /usr.See my earlier suggestion about
maybe
having them include the password information from a common file in /etc/limph.
- tmp dir is still wrong. Do you really need your own tmp dir? Can't be in
/usr in any case.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Limph - PHP network host monitor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830
--- Additional Comments From [EMAIL PROTECTED] 2006-11-27 14:05 EST ---
Hang on, scratch those, I forgot to migrate one thing to a different file. Give
me a few minutes. . . .
(In reply to comment #4)
Thanks, terribly helpful patch. I've applied it, released upstream version
1.9.4 to address the config file, tmp dir and tarball issues, updated spec
accordingly, rebuilt, and posted the results:
Spec URL: http://gryffindor.jcomserv.net/extras/limph/limph-3.spec
SRPM URL: http://gryffindor.jcomserv.net/extras/limph/limph-1.9.4-1.src.rpm
(In reply to comment #3)
Created an attachment (id=141960)
--
(https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=141960action=view)
[edit] [edit]
patch to spec file
Here's a patch that resolves some issues.
To fix the tar ball issue:
%setup -q -n %{name}
Then go back to %setup -q when you fix that.
Other issues:
- still got some config files in /usr. See my earlier suggestion about
maybe
having them include the password information from a common file in
/etc/limph.
- tmp dir is still wrong. Do you really need your own tmp dir? Can't be in
/usr in any case.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Limph - PHP network host monitor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830
--- Additional Comments From [EMAIL PROTECTED] 2006-11-27 14:21 EST ---
Ok, the above links are again valid. I had to re-do upstream since I forgot to
migrate a chunk of host_agent.php to config.php. All better now, but I didn't
bump the release number, if I need to, let me know.
(In reply to comment #5)
Hang on, scratch those, I forgot to migrate one thing to a different file.
Give
me a few minutes. . . .
(In reply to comment #4)
Thanks, terribly helpful patch. I've applied it, released upstream version
1.9.4 to address the config file, tmp dir and tarball issues, updated spec
accordingly, rebuilt, and posted the results:
Spec URL: http://gryffindor.jcomserv.net/extras/limph/limph-3.spec
SRPM URL: http://gryffindor.jcomserv.net/extras/limph/limph-1.9.4-1.src.rpm
(In reply to comment #3)
Created an attachment (id=141960)
--
(https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=141960action=view)
[edit] [edit] [edit]
patch to spec file
Here's a patch that resolves some issues.
To fix the tar ball issue:
%setup -q -n %{name}
Then go back to %setup -q when you fix that.
Other issues:
- still got some config files in /usr.See my earlier suggestion about
maybe
having them include the password information from a common file in
/etc/limph.
- tmp dir is still wrong. Do you really need your own tmp dir? Can't be
in
/usr in any case.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Limph - PHP network host monitor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830
--- Additional Comments From [EMAIL PROTECTED] 2006-11-22 18:36 EST ---
Created an attachment (id=141960)
-- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=141960action=view)
patch to spec file
Here's a patch that resolves some issues.
To fix the tar ball issue:
%setup -q -n %{name}
Then go back to %setup -q when you fix that.
Other issues:
- still got some config files in /usr. See my earlier suggestion about maybe
having them include the password information from a common file in /etc/limph.
- tmp dir is still wrong. Do you really need your own tmp dir? Can't be in
/usr in any case.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 --- Additional Comments From [EMAIL PROTECTED] 2006-11-17 09:21 EST --- Spec URL: http://gryffindor.jcomserv.net/extras/limph/limph-2.spec SRPM URL: http://gryffindor.jcomserv.net/extras/limph/limph-1.9.3-2.src.rpm I addressed the source BuildArch, URL, RPM_SOURCE_DIR, limph.conf issues. I'm trying to solve the conf file issues with symlinks and it's not working, nor is my %attr for the tmp directory applying the desired ownership. What am I doing wrong? The reason the MD5 doesn't match upstream is the folder name in the source tarball is limph, not limph-1.9.3, so I untarred, renamed and retarred to get it to build. Should I re-release a 1.9.3.1 with this fixed, or is there a way around it in the SPEC? Thanks for the help, BTW. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: Limph - PHP network host monitor
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776, 177841 |163778
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2006-11-16 16:21 EST ---
Initial comments:
- BAD: md5sum does not match upstream.
- Need full URL for source
(http://prdownloads.sf.net/limph/limph-%{version}.tar.gz
- Please, BuildArch: not BuildArchitectures:
$ rpmlint ~/Desktop/limph-1.9.3-1.src.rpm
W: limph strange-permission limph-hostagent 0755
- perhaps just change the permission with install?
E: limph use-of-RPM_SOURCE_DIR
- Instead of $RPM_SOURCE_DIR/limph.conf, use %SOURCE1, etc.
- should add to limph.conf:
Directory /usr/share/limph/
Order Deny,Allow
Deny from all
Allow from 127.0.0.1
/Directory
- More rpmlint:
# rpmlint limph
E: limph file-in-usr-marked-as-conffile /usr/share/limph/config.php
E: limph file-in-usr-marked-as-conffile /usr/share/limph/input.php
- move to /etc/limph. Is input.php really a config file?
E: limph world-writable /usr/share/limph/tmp 0777
E: limph non-standard-dir-perm /usr/share/limph/tmp 0777
- These should only be writable by limph.
# rpmlint limph-hostagent
E: limph-hostagent file-in-usr-marked-as-conffile
/usr/share/limph/host_agent.php
- same here. Maybe put $secret into a config file in /etc/limph and include
that?
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 214830] Review Request: Limph - PHP network host monitor
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Limph - PHP network host monitor https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=214830 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: Limph - PHP |Review Request: Limph - PHP |network host monitor|network host monitor OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
