[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=221054 Chitlesh GOORAH [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Comment #22 from Chitlesh GOORAH [EMAIL PROTECTED] 2008-11-13 15:06:17 EDT --- Package Change Request === Package Name: gerbv Short Description: Gerber file viewer from the gEDA toolkit Owners: chitlesh Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=221054 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #23 from Kevin Fenzi [EMAIL PROTECTED] 2008-11-14 00:50:57 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-06-27 15:31 EST --- I'm thereby closing this bug as duplicate. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||DUPLICATE --- Additional Comments From [EMAIL PROTECTED] 2007-06-27 15:32 EST --- *** This bug has been marked as a duplicate of 245985 *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163776, 177841 |201449 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-06-24 11:26 EST --- (In reply to comment #17) However now, file - open project fails to open examples provided by this package. But if one open a project file or a gerbv file from the konsole, gerbv opens it successfully. I'll dig later on. Ok, I've found what was wrong. Actually it wasn't the code that was failing this time but rather the examples provided by gerbv are outdated. I'll update them and file another review under my name later on. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-06-24 11:44 EST --- I think it is better that you close this bug and create new review request once you create a new spec/srpm for this package and mark this as duplicate of the new review request.. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-05-28 03:35 EST --- Does the patch by Ralf work for you? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-05-28 04:23 EST --- Yes, Thanks Ralf, the patch works. However now, file - open project fails to open examples provided by this package. But if one open a project file or a gerbv file from the konsole, gerbv opens it successfully. I'll dig later on. PS: I'm in examination period for the following two weeks. I might not answer my mails during that interval. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED])| --- Additional Comments From [EMAIL PROTECTED] 2007-05-25 06:41 EST --- Hello. Apologies for the long absence. The continuous barrage of non-gerbv related stuff that I've had to do since filing this review request has not yet stopped. If someone else wants to submit a review request for it, then I'm not stopping them... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-05-25 13:33 EST --- Chitlesh, are you insterested in being the maintainer of this package (gerbv)? If you are not, or any response cannot be gained within one week from anyone, I will once close this bug as NOTABUG -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-05-25 16:13 EST --- (In reply to comment #13) Chitlesh, are you insterested in being the maintainer of this package (gerbv)? Actually I would love to. But however, there isn't any upstream for this package to fix the following bugs from comment #2: * In build log: gerbv.c:1526: warning: call to __builtin___snprintf_chk will always overflow destination buffer * Gerber file format support fails to load test files. * Drill file format support crashes with buffer overflow. * Passing files at the command-line results in 100% buffer overflow crash: *** buffer overflow detected ***: gerbv terminated === Backtrace: = /lib/libc.so.6(__chk_fail+0x41)[0x87c161] /lib/libc.so.6[0x87bba3] /lib/libc.so.6(__snprintf_chk+0x37)[0x87ba87] gerbv[0x8055686] gerbv[0x805625a] /lib/libglib-2.0.so.0[0x12a5e1] -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-05-24 12:26 EST --- ping again? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO Flag||needinfo?([EMAIL PROTECTED]) --- Additional Comments From [EMAIL PROTECTED] 2007-05-09 14:04 EST --- ping, Robert? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-02-13 18:27 EST --- You should also fix the desktop file --- rpmbuild/SOURCES/gerbv-1.0.2/desktop/gerbv.desktop 2006-07-26 09:35:40.0 +0200 +++ /usr/share/applications/gerbv.desktop 2007-02-13 23:47:19.0 +0100 @@ -7,4 +7,5 @@ Type=Application Exec=gerbv Icon=gerbv -Categories=Education;Electronics;Engineering; +Categories=Qt;KDE;Education;Science;Engineering; see how it can be done in your spec file with desktop-file-utils instead of the patch: http://fedoraproject.org/wiki/PackagingDrafts/DesktopFiles (easy fix) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-01-14 18:20 EST --- (In reply to comment #6) Chitlesh said: By the way, I'm the geda suite packager for fedora:) Sorry, didn't mean to step on anyone's feet! It's not the case:) I'm glad someone is pushing scientific/electronic tools inside. :) keep it up -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-01-02 08:01 EST --- Created an attachment (id=144637) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=144637action=view) Chitlesh's gerbv patch -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-01-02 08:02 EST --- Created an attachment (id=144638) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=144638action=view) Chitlesh's gerbv spec file -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-01-02 08:05 EST --- Hello, I've recently attached a patch and my gerbv file which I was working on some months ago. My spec file will help you fix the issues pointed by Michael's review. However, I missed out some materials on the doc directory, probably you can add them to the spec file. :) By the way, I'm the geda suite packager for fedora:) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 --- Additional Comments From [EMAIL PROTECTED] 2007-01-02 11:01 EST --- Chitlesh said: By the way, I'm the geda suite packager for fedora:) Sorry, didn't mean to step on anyone's feet! Michael: Thanks for the feedback, I'll try and resubmit within the next few days. When I originally submitted, I didn't realise that there was this maintainership problem (err... I think I must have been blind or something). Perhaps this package shouldn't go into extras because of lack of upstream maintenance. I've posted about this on the gEDA-devel mailing list to see whether anyone's thinking about maintaining it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gerbv - A gerber file viewer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2006-12-31 09:54 EST --- Added FE-NEEDSPONSOR -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 221054] Review Request: gerbv - A gerber file viewer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gerbv - A gerber file viewer
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221054
--- Additional Comments From [EMAIL PROTECTED] 2006-12-31 11:10 EST ---
* In build log:
gerbv.c:1526: warning: call to __builtin___snprintf_chk will
always overflow destination buffer
* Gerber file format support fails to load test files.
* Drill file format support crashes with buffer overflow.
* Passing files at the command-line results in 100% buffer
overflow crash:
*** buffer overflow detected ***: gerbv terminated
=== Backtrace: =
/lib/libc.so.6(__chk_fail+0x41)[0x87c161]
/lib/libc.so.6[0x87bba3]
/lib/libc.so.6(__snprintf_chk+0x37)[0x87ba87]
gerbv[0x8055686]
gerbv[0x805625a]
/lib/libglib-2.0.so.0[0x12a5e1]
* Directories %{_datadir}/gerbv and %{_datadir}/gerbv/scheme
are not included:
$ rpmls -p /home/qa/tmp/rpm/RPMS/gerbv-1.0.2-1.i386.rpm
-rwxr-xr-x /usr/bin/gerbv
-rw-r--r-- /usr/share/applications/fedora-gerbv.desktop
-rw-r--r-- /usr/share/gerbv/scheme/init.scm
-rw-r--r-- /usr/share/icons/hicolor/48x48/apps/gerbv.png
-rw-r--r-- /usr/share/man/man1/gerbv.1.gz
* Scriptlets for GTK icon cache are missing:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=showredirect=ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda
* No %doc files are included. Not even the GPL license.
* Manual pages are marked %doc automatically.
* Upstream project site contains the following warning: If anyone is interested
to takeover this project, please contact Stefan. Else this project will risk to
rot away yet again.
Hints:
* It is commonly considered better style to make Summary in
headline-style:
Summary: Gerber file viewer from the gEDA toolkit
* Second sentence in %description is missing punctuation.
* Manual pages contains unexpanded ${prefix}.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
