[Bug 221947] Review Request: gwenhywfar - utility library

2007-06-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|CLOSED  |ASSIGNED
   Keywords||Reopened
 Resolution|RAWHIDE |
   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-06-08 21:17 EST ---
Package Change Request
==
Package Name: gwenhywfar
New Branches: EL-4 EL-5



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-06-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-06-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE
   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2007-06-08 23:59 EST ---
CVS done.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-03-19 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||RAWHIDE




--- Additional Comments From [EMAIL PROTECTED]  2007-03-19 15:32 EST ---
This is built now.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-02-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947





--- Additional Comments From [EMAIL PROTECTED]  2007-02-22 11:16 EST ---
Just waiting for the round tuits. Will get to it this week-ish.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-02-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947





--- Additional Comments From [EMAIL PROTECTED]  2007-02-22 00:09 EST ---
Ping
any problem for importing this package to CVS?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-01-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947





--- Additional Comments From [EMAIL PROTECTED]  2007-01-12 10:04 EST ---
Just looking over:

(In reply to comment #7)
 + no gwenhywfar.pc files present.

It certainly has them in my builds...


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-01-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947





--- Additional Comments From [EMAIL PROTECTED]  2007-01-11 17:54 EST ---
2.3.0-6 uploaded; cert bundle marked as config, rpaths fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-01-11 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947


[EMAIL PROTECTED] changed:

   What|Removed |Added

OtherBugsDependingO|163778  |163779
  nThis||




--- Additional Comments From [EMAIL PROTECTED]  2007-01-12 01:52 EST ---
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM.
- rpmlint is NOT silent for RPMS.
E: gwenhywfar-devel only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.
But its ok as it looks mis-error by rpmlint.

+ source files match upstream.
0f7cf7d0efa6719f85c00d6d8ccec2b3  gwenhywfar-2.3.0.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.  License text included in package.
+ %doc is small; no -doc subpackage required.
+ %doc does not affect runtime.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code Not contents.
+ no static libraries present.
+ no gwenhywfar.pc files present.
+ -devel subpackage exists
+ included
  %post -p /sbin/ldconfig
  %postun -p /sbin/ldconfig
+ no .la files.
+ translations are available
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ no scriptlets used.
+ file permissions are appropriate.
APPROVED.



-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-01-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947





--- Additional Comments From [EMAIL PROTECTED]  2007-01-10 09:35 EST ---
(In reply to comment #1)
 W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt

It's not really a configuration file, it's a data file. It's a CA certificate
bundle, much like /etc/pki/tls/certs/ca-bundle.crt. However, that is
also marked %config, so I'll change this.

(Ideally it just uses the openssl CA bundle.)

 E: gwenhywfar-devel only-non-binary-in-usr-lib
 There are only non binary files in /usr/lib so they should be in /usr/share.

This is a mis-error from rpmlint. It's a architecture-specific include, so it
can't be in /usr/include, and needs to be in an architecture specific directory.
 See glib2, dbus, gcc, qt for other examples of this.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-01-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947





--- Additional Comments From [EMAIL PROTECTED]  2007-01-10 10:28 EST ---
(In reply to comment #2)
 (In reply to comment #1)
  W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt
 
 It's not really a configuration file, it's a data file. It's a CA certificate
 bundle, much like /etc/pki/tls/certs/ca-bundle.crt. However, that is
 also marked %config, so I'll change this.

Perhaps it should live in /etc/pki/tls/certs too?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-01-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947





--- Additional Comments From [EMAIL PROTECTED]  2007-01-10 12:03 EST ---
It's not easily modifiable without patching, and if I'm going to do that, I'd
rather just patch it to *use* the openssl one. Currently discussing that 
w/upstream.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-01-10 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947





--- Additional Comments From [EMAIL PROTECTED]  2007-01-10 12:12 EST ---
FWIW, curl uses the openssl one rather than the one shipped in the curl 
tarball...

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776  |163778
  nThis||




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 221947] Review Request: gwenhywfar - utility library

2007-01-09 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gwenhywfar - utility library


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221947





--- Additional Comments From [EMAIL PROTECTED]  2007-01-10 02:47 EST ---
rpmlint is not silent
rpmlint on main RPM reported
W: gwenhywfar non-conffile-in-etc /etc/gwen-public-ca.crt
A non-executable file in your package is being installed in /etc, but is not
a configuration file. All non-executable files in /etc should be configuration
files. Mark the file as %config in the spec file.

rpmlint on -devel rpm reported
I: gwenhywfar-devel checking
E: gwenhywfar-devel only-non-binary-in-usr-lib
There are only non binary files in /usr/lib so they should be in /usr/share.

Otherwise mock build is fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review