[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: six - Hex playing program https://bugzilla.redhat.com/show_bug.cgi?id=222175 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: six - Hex playing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: six - Hex playing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 17:00 EST --- Package looks fine now. Pity that I wasn't able to win ;) but it, obviously, doesn't stand in the way to make this package approved. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: six - Hex playing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175 --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 16:20 EST --- (In reply to comment #8) > You forgot to add --ignore-theme-index option argument to > gtk-update-icon-cache > run against locolor dir. There's no index.theme file so it causes an error: > > No theme index file in '/usr/share/icons/locolor/'. > If you really want to create an icon cache here, use --ignore-theme-index. > Fixed. Spec URL: http://rafalzaq.nonlogic.org/fedora/six/six.spec SRPM URL: http://rafalzaq.nonlogic.org/fedora/six/six-0.5.3-4.fc6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: six - Hex playing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175 --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 16:08 EST --- You forgot to add --ignore-theme-index option argument to gtk-update-icon-cache run against locolor dir. There's no index.theme file so it causes an error: No theme index file in '/usr/share/icons/locolor/'. If you really want to create an icon cache here, use --ignore-theme-index. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: six - Hex playing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175 --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 15:57 EST --- I forgot about the locolor icons. Spec URL: http://rafalzaq.nonlogic.org/fedora/six/six.spec SRPM URL: http://rafalzaq.nonlogic.org/fedora/six/six-0.5.3-3.fc6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: six - Hex playing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175 --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 15:49 EST --- New SRPM and spec. Spec URL: http://rafalzaq.nonlogic.org/fedora/six/six.spec SRPM URL: http://rafalzaq.nonlogic.org/fedora/six/six-0.5.3-2.fc6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: six - Hex playing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175 --- Additional Comments From [EMAIL PROTECTED] 2007-01-10 17:03 EST --- (In reply to comment #4) > No. update-desktop-database must be run. Right. I have accidentally pasted a wrong script there... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: six - Hex playing program
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175
--- Additional Comments From [EMAIL PROTECTED] 2007-01-10 16:55 EST ---
> Also, there's a "MimeType=" entry so you need to add:
> %post
> update-mime-database %{_datadir}/mime &> /dev/null || :
No. update-desktop-database must be run.
update-mime-database, on the contrary, is only for the new
XML MIME type definition files.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: six - Hex playing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175 --- Additional Comments From [EMAIL PROTECTED] 2007-01-10 14:53 EST --- Also, I can call ArcadeGame category into question. In my opinion it is rather only a BoardGame. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: six - Hex playing program
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175
--- Additional Comments From [EMAIL PROTECTED] 2007-01-10 14:44 EST ---
It looks like there's some missing scriptlets. You ought to read
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets to know most of
them.
Firstly, your package installs icons into %{_datadir}/icons/{hicolor,locolor}.
It means that you have to add following lines to your spec file:
%post
touch --no-create %{_datadir}/icons/hicolor || :
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
%{_bindir}/gtk-update-icon-cache --ignore-theme-index --quiet %{_datadir}/icons/
hicolor || :
%postun
touch --no-create %{_datadir}/icons/hicolor || :
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
%{_bindir}/gtk-update-icon-cache --ignore-theme-index --quiet %{_datadir}/icons/
hicolor || :
Also, there's a "MimeType=" entry so you need to add:
%post
update-mime-database %{_datadir}/mime &> /dev/null || :
%postun
update-mime-database %{_datadir}/mime &> /dev/null || :
And the normal review process:
* sources match upstream (457028e8040f030b8f2cd6a65d04bab9)
* rpmlint is silent
* dist tag present
* build root correct
* license field matches the actual license and is included in %doc
* BuildRequires looks good as package builds in mock (fc6/x86_64)
* provides and requires are sane
* no shared libraries
* not relocatable
* it owns all directories well
Package contains check procedure, so you can create %check section with `make
check` inside it.
Thus, THINGS you need to do are:
- add missing %post and %postun sections
- add %check section
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222175] Review Request: six - Hex playing program
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: six - Hex playing program https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222175 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-10 14:12 EST --- I'll take it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
