[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/show_bug.cgi?id=57 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-12 12:23 EST --- (In reply to comment #17) Would this be an acceptable way to sed only text files? This script should work well. I can accept 0.50-3 for sed issue (not checked if other issues exist, however I assume it is okay for now). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 10:31 EST --- I have fixed he above issues. Spec URL: http://www.stahnkage.com/rpms/pastebin.spec SRPM URL: http://www.stahnkage.com/rpms/pastebin-0.50-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 10:41 EST --- ok looks good and the package works. APPROVED and ill sponsor you also as it seems you are not sponsored already apply for cvsextras group access -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pastebin - A collaborative debugging tool
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
OtherBugsDependingO|163779 |163778
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:08 EST ---
(In reply to comment #1)
rpmlint is silent.
rpmlint is not silent:
W: pastebin mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12)
Also, there are some documentation files in %{_datadir}/pastebin/lib/geshi/docs
which should be moved to %doc. Creation of new directory there, like geshi
sounds like a good solution. It seems to me that the content of
{_datadir}/pastebin/lib/geshi may be moved there as well, obviously after some
fixing in example.php.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:10 EST --- Oops, I didn't want to set an FE-REVIEW blocker back. Changing to FE-ACCEPT again. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:27 EST --- Are you saying the geshi doc should be in /usr/share/doc/geshi or /usr/share/doc/pastebin-0.50/geshi? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:32 EST --- Well, some notes: Keep timestamps for text files as possible. ( Timestamps in http://fedoraproject.org/wiki/Packaging/Guidelines ) * Use cp -p or install -p instead of just cp or install * for sed usage: find . -type f| xargs sed -i 's/\r//' Well, this usage of find - sed change timestamps of all files under the directory ., even some (many) files are actually not necessary to be fixed. Just use sed to the files which are _actually_ needed to be changed. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:35 EST --- (In reply to comment #6) Are you saying the geshi doc should be in /usr/share/doc/geshi or /usr/share/doc/pastebin-0.50/geshi? I meant the second one. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:49 EST --- with the find and sed removed i get [EMAIL PROTECTED] SPECS]$ rpmlint /home/dennis/fedora/RPMS/noarch/pastebin-0.50-2.noarch.rpm |grep wrong-script-end-of-line-encoding |wc -l 84 [EMAIL PROTECTED] SPECS]$ rpm -qlp /home/dennis/fedora/RPMS/noarch/pastebin-0.50-2.noarch.rpm |wc -l 106 [EMAIL PROTECTED] SPECS]$ so nearly every single file is dos line ended in this instance i think it is fine to mass change line endings. if it was a small handfull of files i would do them individually. but that is not the case. as far as the docs yeah I missed that they should go into %doc -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 11:53 EST --- as far as rpmlint goes [EMAIL PROTECTED] SPECS]$ rpmlint /home/dennis/fedora/RPMS/noarch/pastebin-0.50-2.noarch.rpm [EMAIL PROTECTED] SPECS]$ rpmlint /home/dennis/fedora/RPMS/noarch/pastebin-0.50-1.noarch.rpm [EMAIL PROTECTED] SPECS]$ it is indeed silent for me if there is mixed spaces/tabs then thats should be fixed -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 12:12 EST --- (In reply to comment #10) it is indeed silent for me if there is mixed spaces/tabs then thats should be fixed Apart from built rpm file, you ought to also check rpmlint against source rpm file. [EMAIL PROTECTED] ~]$ rpmlint ~/rpmbuild/SRPMS/pastebin-0.50-2.src.rpm W: pastebin mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 12) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 12:15 EST --- (In reply to comment #9) with the find and sed removed i get [EMAIL PROTECTED] SPECS]$ rpmlint /home/dennis/fedora/RPMS/noarch/pastebin-0.50-2.noarch.rpm |grep wrong-script-end-of-line-encoding |wc -l 84 [EMAIL PROTECTED] SPECS]$ rpm -qlp /home/dennis/fedora/RPMS/noarch/pastebin-0.50-2.noarch.rpm |wc -l 106 [EMAIL PROTECTED] SPECS]$ so nearly every single file is dos line ended in this instance i think it is fine to mass change line endings. if it was a small handfull of files i would do them individually. but that is not the case. Well, even this case, still checking if the file sed command is to be applied is really a text file. As far as I checked, there is one file which is not a text file (./public_html/favicon.ico), against this file sed command should not be used. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 12:40 EST --- (In reply to comment #12) Well, even this case, still checking if the file sed command is to be applied is really a text file. As far as I checked, there is one file which is not a text file (./public_html/favicon.ico), against this file sed command should not be used. It may be easily fixed by sedding only the files in lib/ subdirectory. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 13:15 EST --- I forgot to add that the files in public_html/ directory should be listed explicitly. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:15 EST --- Can you tell me why (source) I should list public_html files explicitly? I didn't see anything on http://fedoraproject.org/wiki/Packaging/Guidelines about it. I am not saying I won't do it, I just want to know why. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 14:26 EST --- (In reply to comment #15) Can you tell me why (source) I should list public_html files explicitly? I meant that you ought to sed all files in lib/ and explicit list files to sed in public_html. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pastebin - A collaborative debugging tool
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 15:05 EST ---
Would this be an acceptable way to sed only text files?
for file in `find . -type f`
do
if (file $file | awk -F: '{print $2}' | grep -i text /dev/null) ; then
sed -i 's/\r//g' $file
fi
done
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: pastebin - A collaborative debugging tool https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57 --- Additional Comments From [EMAIL PROTECTED] 2007-01-11 19:13 EST --- Spec URL: http://www.stahnkage.com/rpms/pastebin.spec SRPM URL: http://www.stahnkage.com/rpms/pastebin-0.50-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222257] Review Request: pastebin - A collaborative debugging tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: pastebin - A collaborative debugging tool
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=57
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776 |163778
nThis||
--- Additional Comments From [EMAIL PROTECTED] 2007-01-11 01:21 EST ---
package meets naming and packaging guidelines.
specfile is properly named, is cleanly written and uses macros consistently.
dist tag is present.
build root is correct.
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
license field matches the actual license.
license is open source-compatible. GPL License text included in package.
source files match upstream:
d7b8993f4baed7753fb7c912b06725fb pastebin.tar.gz
d7b8993f4baed7753fb7c912b06725fb ../SOURCES/pastebin.tar.gz
latest version is being packaged.
BuildRequires are proper.
package builds in mock ( FC-6 ).
rpmlint is silent.
final provides and requires are sane
no shared libraries are present.
package is not relocatable.
doesn't own any directories it shouldn't.
file permissions are appropriate.
%clean is present.
no scriptlets present.
code, not content.
documentation is small, so no -docs subpackage is necessary.
%docs are not necessary for the proper functioning of the package.
no headers.
no pkgconfig files.
no libtool .la droppings.
not a GUI app.
Needs fixing
does not own %{_datadir}/%{name}
%{_sysconfdir}/%{name} listed twice
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
