[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-18 15:38 EST --- Imported and built, thanks ! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 --- Additional Comments From [EMAIL PROTECTED] 2007-01-14 06:14 EST --- Thanks for the review. I've added the hicolor-icon-theme dependency, but I'm not sure about the Application category, since the example on the Packaging Guidelines page still has it : http://fedoraproject.org/wiki/Packaging/Guidelines#desktop I've posted on the packaging list for advice, I'll let you know the results. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 --- Additional Comments From [EMAIL PROTECTED] 2007-01-14 06:19 EST --- (In reply to comment #3) Thanks for the review. I've added the hicolor-icon-theme dependency, but I'm not sure about the Application category, since the example on the Packaging Guidelines page still has it : http://fedoraproject.org/wiki/Packaging/Guidelines#desktop So that should be fixed. There's desktop-file-utils-0.12 in fc7 and its desktop-file-validate shows the following error: [EMAIL PROTECTED] /download]$ desktop-file-validate /usr/share/applications/fedora- blobby.desktop /usr/share/applications/fedora-blobby.desktop: warning: The 'Application' category is not defined by the desktop entry specification. Please use one of AudioVideo, Audio, Video, Development, Education, Game, Graphics, Network, Office, Settings, System, Utility instead -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 --- Additional Comments From [EMAIL PROTECTED] 2007-01-14 07:43 EST --- OK then, thanks. * Sun Jan 14 2007 Aurelien Bompard [EMAIL PROTECTED] 0.6-0.2.a - add dependency on hicolor-icon-theme (#222547) - removed the Application category from the desktop file http://gauret.free.fr/fichiers/rpms/fedora/blobby.spec http://gauret.free.fr/fichiers/rpms/fedora/blobby-0.6-0.2.a.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163778 |163779 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-14 12:21 EST --- Approved. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO|163779 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-14 12:45 EST --- Just something I caught at the last minute: * Sun Jan 14 2007 Aurelien Bompard [EMAIL PROTECTED] 0.6-0.3.a - patch it to obey RPM_OPT_FLAGS http://gauret.free.fr/fichiers/rpms/fedora/blobby.spec http://gauret.free.fr/fichiers/rpms/fedora/blobby-0.6-0.3.a.src.rpm Please tell if you still approve it with this change. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-01-14 13:06 EST --- Please don't use autotool when possible. It seems that the flag -Os is used only at one point in configure, so making a patch for configure, not for configure.in should be easy. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 --- Additional Comments From [EMAIL PROTECTED] 2007-01-14 13:47 EST --- Sure, I don't mind, but why ? What's the problem with it ? Anyway, I've patched configure instead : http://gauret.free.fr/fichiers/rpms/fedora/blobby.spec http://gauret.free.fr/fichiers/rpms/fedora/blobby-0.6-0.4.a.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 --- Additional Comments From [EMAIL PROTECTED] 2007-01-14 14:11 EST --- (In reply to comment #9) Sure, I don't mind, but why ? What's the problem with it ? Well, * A weak reason is just please don't use which is not needed actually. * Another reason is that using autotool easily may generate files which upstream (or someone else) may not desire, especially when the version of autotool differ between which upstream used and which you used. This is once discussed when autotools are removed from minimum buildroot, starting from http://www.redhat.com/archives/fedora-maintainers/2006-September/msg00146.html -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 --- Additional Comments From [EMAIL PROTECTED] 2007-01-14 14:41 EST --- Fine, thanks for this clear reply. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 --- Additional Comments From [EMAIL PROTECTED] 2007-01-14 15:26 EST --- Package is still approved, of course. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] OtherBugsDependingO|163776 |163778 nThis|| --- Additional Comments From [EMAIL PROTECTED] 2007-01-13 17:45 EST --- I'll review it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 222547] Review Request: blobby - Blobby Volley 2, a volley-ball game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: blobby - Blobby Volley 2, a volley-ball game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=222547
--- Additional Comments From [EMAIL PROTECTED] 2007-01-13 18:24 EST ---
REVIEW:
* sources match upstream (md5: fdef3e59f0870d890be8dffaccd773ca)
* package meets all guidelines it should
* correct build root: %{_tmppath}/%{name}-%{version}-%{release}-
root-%(%{__id_u} -n)
* package is licensed under a GPL license and license text is included in
package
* the latest version is being packaged
* no shared libraries
* no duplicates in %files
* %clean is present
* proper scriptlets
* no need to any subpackages
* rpmlint is silent
* final provides and requires are sane
!* desktop file:
Category Application is deprecated and should be removed.
https://www.redhat.com/archives/fedora-extras-list/2006-October/msg00723.html
* BRs listed good
* mock builds fine (fc6/x86_64)
* all directories are owned well
!* a lack of Requires:
you should add hicolor-icon-theme dependency:
https://www.redhat.com/archives/fedora-extras-list/2006-September/msg00282.html
THINGS to do:
- get rid of an Application category
- add hicolor-icon-theme dependency
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
