[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-05-23 10:25 EST --- Thanks for review. Tagged and built. Closing -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: glob2 - An innovative RTS game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2007-05-22 09:51 EST ---
MUST:
=
* rpmlint output is:
This is normal for this package and can be ignored
* Package and spec file named appropriately
* Packaged according to packaging guidelines
* License ok
* spec file is legible and in Am. English.
* Source matches upstream
* Compiles and builds on devel x86_64
* BR: ok
* No locales
* No shared libraries
* Not relocatable
* Package owns / or requires all dirs
* No duplicate files Permissions
* %clean macro usage OK
* Contains code and permissable content
* %doc does not affect runtime, and isn't large enough to warrent a sub package
* no -devel package needed
* .desktop file as required and properly installed
Should FIX
==
* Change not working Source0 URL from:
http://globulation2.org/releases/%{version}/%{name}-%{version}.tar.gz
to the new / working:
http://dl.sv.nongnu.org/releases/glob2/%{version}/%{name}-%{version}.tar.gz
No blockers, approved!
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-05-22 14:31 EST --- New Package CVS Request === Package Name: glob2 Short Description: An innovative RTS game Owners: [EMAIL PROTECTED] Branches: FC-6 F-7 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-05-22 15:13 EST --- CVS done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: glob2 - An innovative RTS game
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
OtherBugsDependingO|163776 |
nThis||
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2007-05-10 15:05 EST ---
(In reply to comment #18)
Updated to 0.8.23
Spec URL: http://rafalzaq.nonlogic.org/fedora/glob2/glob2.spec
SRPM URL: http://rafalzaq.nonlogic.org/fedora/glob2/glob2-0.8.23-1.src.rpm
I have problems with campaign. First mission doesn't end. I'll ask upstream
what's going on.
Hmm,
I've just compared you're package with the mandrake package hosted on the
homepage, and I noticed that mandrake uses autoreconf -f -i, you could try
adding that to end of %prep instead of this hack:
%{__sed} -i '1871d' configure
touch -c -r aclocal.m4 configure configure.in
You can also try commenting %patch0, the mandrake srpm doesn't have any patches.
Maybe that will fix things. As said I would be happy to review this, but if it
doesn't work, its little good. If all else fails downgrade to .22 or .21
Some other initial review remarks:
Merge the -data package into the main, having a seperate data package when its
in the same srpm is of no use.
Move the icon from /usr/share/pixmaps to /usr/share/icons/hicolor/size/apps
and add iconcache update scripts.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-05-09 04:26 EST --- I built .23 locally, and it doesn't show any campaign (while .21 does). I am running on x86_64. Other then that it is a very nice game! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-05-04 09:56 EST --- Updated to 0.8.23 Spec URL: http://rafalzaq.nonlogic.org/fedora/glob2/glob2.spec SRPM URL: http://rafalzaq.nonlogic.org/fedora/glob2/glob2-0.8.23-1.src.rpm I have problems with campaign. First mission doesn't end. I'll ask upstream what's going on. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 [EMAIL PROTECTED] changed: What|Removed |Added Priority|normal |medium --- Additional Comments From [EMAIL PROTECTED] 2007-05-03 14:07 EST --- Rafal, Ping? I can review this for you, but first please provide an updated spec / srpm for the latest upstream version (23 now). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-04-17 14:04 EST --- Rafal, if you can create and upload an updated version, then maybe we can exchange reviews? I myself also have several game packages awaiting review: * asc-music - Background music for the game asc - https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233256 - requires asc * vegastrike - 3D OpenGL spaceflight simulator - https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233782 * vegastrike-data - Data files for Vega Strike - https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=233783 * ballz - Platform game with some puzzle elements - https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=236798 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-04-10 07:54 EST --- As someone just sticking their nose in, (I pretty much made a spec file and was about to submit it for review (as a first review) and happened to stumble on this bug), I've noticed that the -data package does not seem to take ownership of dirs (use %dir dirname). Also, the Glob2 dev team released a .22 version (it appears that maps were accidently omitted, you may need to pack them in as a seperate tarball - I was advised this is okay in the case of genuine omissions). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-03-22 06:48 EST --- You can do the review. It doesn't matter for me who will review glob2. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-03-18 15:31 EST --- Rafal, Since Nikolais is not responding (and has a history of not doing so, hence his submission of glob2 had stalled), I suggest moving on without him. Shall I review this for you? (as time permits). Or maybe Chris wants to review this? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-02-16 09:45 EST --- Rafat, About closing bug 191005 as a dup of this, that review was actually still active I must admit it didn't look like that, that is because most of the discussion was taking place elsewhere as Nikolai needed (and still needs) sponsering. I didn't get around to reviewing one of his other packages and sponser him because of various circumstances. AFAIK Nikolai still wants to become an FE contributer and is still interested in maintaining glob2. Nikolai I've added you to the CC for this, what do you think about this? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-02-16 10:16 EST --- Ok, I'll wait for Nikolais reply. If he is really interested in maintaining glob2 I'll let him to do it. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-02-16 10:50 EST --- Erm, thats not completely what I had in mind, what I had in mind (but didn't write) is that you and Nikolai could co-maintain it. Since Nikolai is somewhat new to all this I think co-maintaining would be a good idea! Now lets hope Nikolai responds soon. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-01-30 17:12 EST --- Why do you split this into two packages? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-01-30 17:36 EST --- It's recommended by the games Packaging Guidelines: Package game files and data files separately, if possible, to reduce size of bugfix updates. This must be done if upstream packages game data in separate tarballs, and should be done even if upstream uses one tarball for game source and data. See Nazghul and tong for examples. http://fedoraproject.org/wiki/Extras/SIGs/Games -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-01-30 18:29 EST --- I think they meant in seperate spec files. If you bug fix the glob2 source and update your release number, then the data package also gets the updated releace number because they are in the same spec file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-01-30 18:34 EST --- Although looking at nazghul and tong, they both do the same thing you are doing, so I am confused by this guideline. I'm going to try and clarify this on the fedora-games mailing list. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-01-29 12:15 EST --- Thanks for these patches. Spec URL: http://rafalzaq.nonlogic.org/fedora/glob2/glob2.spec SRPM URL: http://rafalzaq.nonlogic.org/fedora/glob2/glob2-0.8.21-2.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-01-29 00:03 EST --- One remark: - MUSTFIX: package doesn't honor RPM_OPT_FLAGS -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-01-29 00:05 EST --- Created an attachment (id=146809) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=146809action=view) Patch to prevent configure from overriding CXXFLAGS This patch hacks configure/configure.in to not override CXXFLAGS. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 --- Additional Comments From [EMAIL PROTECTED] 2007-01-29 00:07 EST --- Created an attachment (id=146810) -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=146810action=view) Patch glob2.spec to use *-configure.diff -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225010] Review Request: glob2 - An innovative RTS game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: glob2 - An innovative RTS game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225010 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-01-27 08:07 EST --- *** Bug 191005 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
