[Bug 225248] Merge Review: ant

2007-06-21 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ant


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225248


[EMAIL PROTECTED] changed:

   What|Removed |Added

Product|Fedora Extras   |Fedora

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225248] Merge Review: ant

2007-05-22 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ant


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225248





--- Additional Comments From [EMAIL PROTECTED]  2007-05-22 10:42 EST ---
Please close this bug after building the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225248] Merge Review: ant

2007-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ant


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225248


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-25 12:50 EST ---
God:
+ BR fixed.
+ Rpmlint was OK (with warnings)

*** APPrOVED ***

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225248] Merge Review: ant

2007-04-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ant


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225248





--- Additional Comments From [EMAIL PROTECTED]  2007-04-24 18:06 EST ---
(In reply to comment #2)
> Good:
> + Naming seems ok.
> + Tar ball matches with upstream.
> + Mock build works fine for FC6 and rawhide.
> 
> Bad:
> - BR coreutils is not be included.
BR coreutils removed.
> - warning from rpmlint ant-manual:
> 
> rpmlint of ant-manual:
> W: ant-manual dangling-symlink /usr/share/doc/ant-manual-1.6.5/manual/api
> /usr/share/javadoc/ant-1.6.5
> W: ant-manual symlink-should-be-relative
> /usr/share/doc/ant-manual-1.6.5/manual/api /usr/share/javadoc/ant-1.6.5
These are needed so that different versions of docs can be installed on the same
machine. The symlink points to a macro, so it cannot be make relative.
> W: ant-manual file-not-utf8
> /usr/share/doc/ant-manual-1.6.5/manual/tutorial-tasks-filesets-properties.zip
This zip is taken directly from the source tar ball.

> - Errors/warnings on rpmlint ant:
> E: ant devel-dependency java-devel
ant needed java-devel to run some of its tasks.
> W: ant non-standard-group Development/Build Tools
The group warning is OK.
> W: ant incoherent-version-in-changelog 1.6.5-4jpp.2 0:1.6.5-4jpp.2.fc6
Fixed
> W: ant obsolete-not-provided ant-optional
> W: ant obsolete-not-provided ant-optional-full
I tried adding these Provides, but then the main package conflicts with the
sub-packages, so these were removed.
> E: ant useless-explicit-provides ant
That Provides: allows subpackages not in Fedora to be installed from JPackage.

Updates srpm and spec file at the same location.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225248] Merge Review: ant

2007-04-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ant


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225248


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2007-04-23 15:39 EST ---
Good:
+ Naming seems ok.
+ Tar ball matches with upstream.
+ Mock build works fine for FC6 and rawhide.

Bad:
- BR coreutils is not be included.
- warning from rpmlint ant-manual:

rpmlint of ant-manual:
W: ant-manual dangling-symlink /usr/share/doc/ant-manual-1.6.5/manual/api
/usr/share/javadoc/ant-1.6.5
W: ant-manual symlink-should-be-relative
/usr/share/doc/ant-manual-1.6.5/manual/api /usr/share/javadoc/ant-1.6.5
W: ant-manual file-not-utf8
/usr/share/doc/ant-manual-1.6.5/manual/tutorial-tasks-filesets-properties.zip
- Errors/warnings on rpmlint ant:
E: ant devel-dependency java-devel
W: ant non-standard-group Development/Build Tools
W: ant incoherent-version-in-changelog 1.6.5-4jpp.2 0:1.6.5-4jpp.2.fc6
W: ant obsolete-not-provided ant-optional
W: ant obsolete-not-provided ant-optional-full
E: ant useless-explicit-provides ant






-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 225248] Merge Review: ant

2007-04-23 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: ant


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225248


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|normal  |medium
   Priority|normal  |medium

[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2007-04-23 13:38 EST ---
New spec file and srpm at:
https://pcheung.108.redhat.com/files/documents/174/375/ant.spec
https://pcheung.108.redhat.com/files/documents/174/376/ant-1.6.5-4jpp.2.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review