[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2008-03-16 13:11 EST --- All my concerns are fixed, now, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2008-02-28 11:10 EST --- Will do, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: lftp
https://bugzilla.redhat.com/show_bug.cgi?id=225984
--- Additional Comments From [EMAIL PROTECTED] 2008-02-27 14:33 EST ---
lftp is in good shape now, however I would use the %{_prefix} macro
here:
%configure --with-modules --disable-static --with-openssl=/usr --with-debug
--disable-rpath
like this:
%configure --with-modules --disable-static --with-openssl=%{_prefix}
--with-debug --disable-rpath
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2008-02-25 04:55 EST --- Hm, yes, a bit weird that it was not announced. I rebased anyway, thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2008-02-23 18:05 EST --- The latest version seems to be 3.6.3, although there was no announcement. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2008-01-25 08:34 EST --- (In reply to comment #25) I have made yet another srpm: http://people.redhat.com/mnagy/lftp-3.6.1-1.fc9.src.rpm > I think that the DEBUG stuff should be removed. I see no reason for it to be there, so done. > The > LDFLAGS="-L`pwd`/src/.libs $LDFLAGS"; > certainly needs an explanation. I tried without and it built fine. This is a bit odd, it's been there for a longer time than it is in CVS, so no idea who put it there. Anyway, I removed it and it built fine for me too. > Also why use the system libtool? Is it to avoid the rpath? If it > doesn't work is it useful to keep it? And also is it really > useful to use system libtool for the install? Hmm, good idea, I'll ask the previous maintainer if he remembers (this was done 6 years ago) why are we using system libtool. I fixed this in srpm. > I also suggest doing > iconv -f ISO88591 -t UTF8 NEWS -o NEWS.tmp > touch -r NEWS NEWS.tmp > mv -f NEWS.tmp NEWS > to keep the NEWS file timestamp. My fault, sorry about that, fixed. > The postun is wrong, it should be run each time. Fixed as well. I also changed the patch which is better now. Patrice: Thanks for spotting these. Ruben: I still haven't commited the changes into cvs, could you please review if these changes are good? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: lftp
https://bugzilla.redhat.com/show_bug.cgi?id=225984
--- Additional Comments From [EMAIL PROTECTED] 2008-01-24 17:08 EST ---
Are you sure that files in %{_libdir}/lftp/%{version}/ are
not dlopened and that /etc/ld.so.conf.d/%{name}-%{_arch}.conf
is useful?
I think that the DEBUG stuff should be removed.
The
LDFLAGS="-L`pwd`/src/.libs $LDFLAGS";
certainly needs an explanation. I tried without and it built fine.
Also why use the system libtool? Is it to avoid the rpath? If it
doesn't work is it useful to keep it? And also is it really
useful to use system libtool for the install?
I also suggest doing
iconv -f ISO88591 -t UTF8 NEWS -o NEWS.tmp
touch -r NEWS NEWS.tmp
mv -f NEWS.tmp NEWS
to keep the NEWS file timestamp.
The postun is wrong, it should be run each time.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-01-24 16:35 EST --- I've just rebuild the latest version in mock, and only see one warning: [EMAIL PROTECTED] ~]$ rpmlint reports/lftp/lftp-3.6.1-1.fc9.i386.rpm lftp.i386: W: conffile-without-noreplace-flag /etc/ld.so.conf.d/lftp-i386.conf But that's ok, and this package is approved. Thanks Martin and Terje for your time. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2008-01-24 15:52 EST --- I guess you must install the package and then run $ rpmlint lftp to see these warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2008-01-24 15:34 EST --- That's strange, I only see the one warning about conffile I mentioned earlier. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2008-01-24 15:16 EST --- Yes, works fine now, thanks! rpmlint gives some warnings about "unused-direct-shlib-dependency", I leave those to the reviewer (Ruben). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2008-01-24 09:09 EST --- This was a bug in 3.6.1, this srpm contains fix, please test, thanks. http://people.redhat.com/mnagy/lftp-3.6.1-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2008-01-23 13:33 EST --- Would be more easy if you could upload a srpm, well, well. spec seems fine, however it's crashing, try this: $ gdb (gdb) exec-file /usr/bin/lftp (gdb) run http://ftp.uninett.no/ (gdb) ls I get: cd ok, cwd=/ lftp ftp.uninett.no:/> ls `ls' at 0 [Waiting for response...] Program received signal SIGSEGV, Segmentation fault. parse_html ( buf=0x96f1987 "\n\n\n\n\n"..., buf_len=1645, eof=false, [EMAIL PROTECTED], set=0x0, all_links=0x96cd1d0, prefix=0x96cd078, base_href=0x96cd1fc, lsopt=0x96cd200, color=1) at HttpDir.cc:732 732 while(*scan && is_ascii_digit(*scan)) Current language: auto; currently c++ (gdb) bt #0 parse_html ( buf=0x96f1987 "\n\n\n\n\n"..., buf_len=1645, eof=false, [EMAIL PROTECTED], set=0x0, all_links=0x96cd1d0, prefix=0x96cd078, base_href=0x96cd1fc, lsopt=0x96cd200, color=1) at HttpDir.cc:732 #1 0x004fb00a in HttpDirList::Do (this=0x96cd188) at HttpDir.cc:1239 #2 0x0018b7a9 in SMTask::Schedule () at SMTask.cc:226 #3 0x001415af in Job::WaitDone (this=0x96a9ea0) at Job.cc:522 #4 0x0804c37e in ?? () #5 0x096a9ea0 in ?? () #6 0x096b91f0 in ?? () #7 0x in ?? () -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide --- Additional Comments From [EMAIL PROTECTED] 2008-01-23 04:52 EST --- Hi, I rebased to 3.6.1 and have committed changes to CVS, rpmlint now finds only this: lftp.i686: W: conffile-without-noreplace-flag /etc/ld.so.conf.d/lftp-i386.conf This is okay, as it is a configuration file, but not to be changed by the user and it can be changed in the future. Please review, thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-11-27 04:05 EST --- Hi Ruben, I was planning, but I'm no longer the maintainer of lftp. I'm sure Martin will take care of it. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2007-11-26 15:58 EST --- Hi Maros, Are you planning on rebasing to 3.6.1? There are still a few things left to do: Source RPM: lftp.src: W: mixed-use-of-spaces-and-tabs (spaces: line 181, tab: line 1) lftp.src: W: invalid-license GPL I think this should be GPLv2+ Binary RPM: [EMAIL PROTECTED] reports]$ rpmlint lftp/lftp-3.5.14-2.fc9.i386.rpm lftp.i386: W: file-not-utf8 /usr/share/doc/lftp-3.5.14/NEWS lftp.i386: W: invalid-license GPL lftp.i386: E: binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.14/proto-ftp.so ['/usr/lib/lftp/3.5.14', '/usr/lib'] lftp.i386: E: binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.14/proto-fish.so ['/usr/lib/lftp/3.5.14', '/usr/lib'] lftp.i386: E: binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.14/proto-http.so ['/usr/lib/lftp/3.5.14', '/usr/lib'] lftp.i386: E: binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.14/liblftp-network.so ['/usr/lib'] lftp.i386: E: binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.14/proto-sftp.so ['/usr/lib/lftp/3.5.14', '/usr/lib'] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo? | --- Additional Comments From [EMAIL PROTECTED] 2007-10-04 08:35 EST --- Version: 3.5.14-2 /sbin/ldconfig -p | grep lftp liblftp-tasks.so.0 (libc6,x86-64) => /usr/lib64/liblftp-tasks.so.0 liblftp-jobs.so.0 (libc6,x86-64) => /usr/lib64/liblftp-jobs.so.0 There are libraries in the standard paths: /usr/lib64/liblftp-*.so.0.0.0 and therefore rpmlint yells, when there are no ldconfig postin(un) calls. chkconfig is removed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora Bug 225984 depends on bug 203574, which changed state. Bug 203574 Summary: remove liblftp-jobs.so and liblftp-tasks.so for internal libraries https://bugzilla.redhat.com/show_bug.cgi?id=203574 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO --- Additional Comments From [EMAIL PROTECTED] 2007-06-17 03:00 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 Bug 225984 depends on bug 203574, which changed state. Bug 203574 Summary: remove liblftp-jobs.so and liblftp-tasks.so for internal libraries https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203574 What|Old Value |New Value Resolution|WONTFIX | Status|CLOSED |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added Priority|normal |medium Bug 225984 depends on bug 203574, which changed state. Bug 203574 Summary: remove liblftp-jobs.so and liblftp-tasks.so for internal libraries https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203574 What|Old Value |New Value Resolution||WONTFIX Status|NEW |CLOSED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2007-04-12 06:05 EST --- I'd like to repeat comment #9: lftp provides no libraries in the standard paths and doesn't add a new path in /etc/ld.so.conf.d. Therefore ldconfig in post/postun isn't required lftp isn't a daemon, running chkconfig in post/postun isn't required. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2007-04-09 17:39 EST --- Also, there really shouldn't be a -devel subpackage for lftp. It does not provide an API for external things to use. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-04-05 18:31 EST --- > Running Transaction > ... > Updating : lftp ### [ 3/10] > error reading information on service lftp: No such file or directory > Updating : yum-updatesd ### [ 4/10] Yeah , coming from the calls to chkconfig in scripts. BTW: i guess automake and autoconf should be removed as buildreq? More strange things: (rpath issue?): # ldd /usr/lib/lftp/3.5.10/proto-file.so |grep ncur libncurses.so.5 => /lib/libncurses.so.5 (0x00fad000) # /usr/lib/lftp/3.5.10/proto-http.so /usr/lib/lftp/3.5.10/proto-http.so: error while loading shared libraries: /usr/lib/libncurses.so.5: file too short All lftp libs should be linked against libncurses in /lib, however because of rpath libncurses in /usr/lib is used by some libs: proto-sftp.so, proto-ftp.so, proto-fish.so liblftp-network.so proto-http.so Please read: http://fedoraproject.org/wiki/Packaging/Guidelines#head-a1dfb5f46bf4098841e31a75d833e6e1b3e72544 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2007-04-05 17:03 EST --- Error message produced by the previous script during a yum update transaction ([EMAIL PROTECTED]): ... Finished Transaction Test Transaction Test Succeeded Running Transaction ... Updating : lftp ### [ 3/10] error reading information on service lftp: No such file or directory Updating : yum-updatesd ### [ 4/10] ... -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2007-04-05 11:37 EST --- From https://www.redhat.com/archives/fedora-cvs-commits/2007-April/msg00189.html : +%post +/sbin/chkconfig --add lftp +/sbin/ldconfig + +%postun +if [ "$1" = 0 ]; then +/sbin/chkconfig --del lftp +/sbin/ldconfig +fi +exit 0 + Why the call the to /sbin/chkconfig ? There are no servers in the lftp packagew? Cut-paste error? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added Flag|needinfo? | --- Additional Comments From [EMAIL PROTECTED] 2007-03-30 16:06 EST --- Upstream has released a new lftp version (3.5.10). * Short changelog (http://lftp.yar.ru/news.html) Version 3.5.10 - 2007-03-26 * fixed core dump when doing ls on file: connection. * fixed core dump when doing pget to write-protected directory. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag|fedora-review- |fedora-review?, needinfo? --- Additional Comments From [EMAIL PROTECTED] 2007-03-23 04:55 EST --- mbarabas, can you please create a new spec based on the comments above? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2007-02-04 09:32 EST --- (In reply to comment #5) > Instead of "Requires: perl-String-CRC32" prefer: > > Requires: perl(String::CRC32) A even better solution would be to drop this explicit requirement as rpmbuild has no problem in detecting and adding it to the requirements list. jpo -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2007-02-04 06:32 EST --- Instead of "Requires: perl-String-CRC32" prefer: Requires: perl(String::CRC32) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: lftp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984
--- Additional Comments From [EMAIL PROTECTED] 2007-02-04 05:11 EST ---
Ah, you're right, my mistake.
That leaves us with:
* RPM name is OK
* Source lftp-3.5.9.tar.bz2 is the same as upstream
* This is the latest version
* Builds fine in mock
* File list looks OK
Needs work:
* BuildRoot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
(wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
(wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
(wiki: QAChecklist item 7)
* BuildRequires: gettext is missing (required to build the translations)
* The %makeinstall macro should not be used
(wiki: PackagingGuidelines#MakeInstall)
* Preserve timestamps when installing files
(wiki: PackagingGuidelines#Timestamps
Minor:
* Duplicate BuildRequires: autoconf (by automake), automake (by libtool)
Rpmlint output:
Source RPM:
W: lftp mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)
rpmlint of lftp:
W: lftp incoherent-version-in-changelog 3.5.9 3.5.9-1.fc6
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.9/proto-ftp.so
['/usr/lib/lftp/3.5.9', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.9/proto-fish.so
['/usr/lib/lftp/3.5.9', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.9/proto-http.so
['/usr/lib/lftp/3.5.9', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.9/liblftp-network.so
['/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.9/proto-sftp.so
['/usr/lib/lftp/3.5.9', '/usr/lib']
W: lftp conffile-without-noreplace-flag /etc/lftp.conf
W: lftp devel-file-in-non-devel-package /usr/lib/liblftp-jobs.so
W: lftp devel-file-in-non-devel-package /usr/lib/liblftp-tasks.so
E: lftp library-without-ldconfig-postin /usr/lib/liblftp-jobs.so.0.0.0
E: lftp library-without-ldconfig-postun /usr/lib/liblftp-jobs.so.0.0.0
E: lftp library-without-ldconfig-postin /usr/lib/liblftp-tasks.so.0.0.0
E: lftp library-without-ldconfig-postun /usr/lib/liblftp-tasks.so.0.0.0
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 --- Additional Comments From [EMAIL PROTECTED] 2007-02-03 12:14 EST --- Ruben, Why did you review lftp 3.5.1 from FC-6? Should you have reviewed lftp 3.5.9 available in rawhide (the patches have already been removed) ? jpo -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: lftp
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED]
CC||[EMAIL PROTECTED]
Flag|fedora-review? |fedora-review-
--- Additional Comments From [EMAIL PROTECTED] 2007-02-03 12:03 EST ---
* RPM name is OK
* Source lftp-3.5.1.tar.bz2 is the same as upstream
* Builds fine in mock
* File list looks OK
Needs work:
* BuildRoot should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
(wiki: PackagingGuidelines#BuildRoot)
* Missing SMP flags. If it doesn't build with it, please add a comment
(wiki: PackagingGuidelines#parallelmake)
* Spec file: some paths are not replaced with RPM macros
(wiki: QAChecklist item 7)
* BuildRequires: gettext is missing (required to build the translations)
* The %makeinstall macro should not be used
(wiki: PackagingGuidelines#MakeInstall)
* rpmlint is not silent, see below
Minor:
* Duplicate BuildRequires: autoconf (by automake), automake (by libtool)
* Please honor $RPM_OPT_FLAGS
rpmlint of lftp-3.5.1-2.fc6.i386.rpm:E: lftp binary-or-shlib-defines-rpath
/usr/lib/liblftp-tasks.so.
0.0.0 ['/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.1/proto-ftp.so
['/usr/lib/lftp/3.5.1', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.1/proto-fish.so
['/usr/lib/lftp/3.5.1', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.1/proto-http.so
['/usr/lib/lftp/3.5.1', '/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.1/liblftp-network.so
['/usr/lib']
E: lftp binary-or-shlib-defines-rpath /usr/lib/lftp/3.5.1/proto-sftp.so
['/usr/lib/lftp/3.5.1', '/usr/lib']
W: lftp conffile-without-noreplace-flag /etc/lftp.conf
W: lftp devel-file-in-non-devel-package /usr/lib/liblftp-jobs.so
W: lftp devel-file-in-non-devel-package /usr/lib/liblftp-tasks.so
E: lftp library-without-ldconfig-postin /usr/lib/liblftp-jobs.so.0.0.0
E: lftp library-without-ldconfig-postun /usr/lib/liblftp-jobs.so.0.0.0
E: lftp library-without-ldconfig-postin /usr/lib/liblftp-tasks.so.0.0.0
E: lftp library-without-ldconfig-postun /usr/lib/liblftp-tasks.so.0.0.0
[EMAIL PROTECTED] lftp]$ rpmlint lftp-3.5.1-2.fc6.src.rpm
W: lftp mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 1)
W: lftp patch-not-applied Patch2: lftp-3.4.1-dont_core.patch
W: lftp patch-not-applied Patch181694: lftp-3.4.2-fix-redirect-coredump.patch
W: lftp patch-not-applied Patch173276: lftp-3.3.5-bz173276.patch
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-02-03 11:47 EST --- Pending issues from ticket https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211483 * Requirements and build requirement: comment #7 * Rpath problems: comments #9 and # 10 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 225984] Merge Review: lftp
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lftp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225984 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
