[Bug 226314] Merge Review: prctl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: prctl https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226314 --- Additional Comments From [EMAIL PROTECTED] 2007-02-21 10:38 EST --- prctl-1.5-2 prepared for review -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226314] Merge Review: prctl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226314 --- Comment #4 from Karsten Hopp 2009-01-28 06:25:33 EDT --- The only parameters of prctl that do anything other than printing help are --unaligned= and --fpemu=. Both work only on ia64, on other archs you'll get this output: 'ERROR: Kernel on this platform may not implement this prctl feature.' I've added this as a comment before the ExclusiveArch: in the spec file and commited it to CVS. As IA64 is a secondary arch in Fedora, a build will need to be done by the secondary arch maintainers. See https://fedoraproject.org/wiki/Architectures/IA64 for more info about Fedora-IA64 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226314] Merge Review: prctl
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226314
--- Comment #5 from Orcan 'oget' Ogetbil 2009-01-28
11:48:53 EDT ---
Thanks for the explanation.
So I can't to do a test to evaluate the software but I could do a generic
package review since it is a simple one.
There is one minor issue and a few suggestions. Let me know whenever you update
the package so we can close the bug.
* rpmlint says
prctl.src:22: W: setup-not-quiet
You need to use
%setup -q
! no disttag. I think it could be better to have a disttag to avoid
incompatibilities between the binaries produced by different versions of the
compiler. What do you think?
! The patch is trivial. I don't think it is necessary to submit upstream. It
would be nice though.
! You can make use of the %{name} macro a little more frequent
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226314] Merge Review: prctl
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226314
--- Comment #6 from Karsten Hopp 2009-01-28 12:05:52 EDT
---
I've added changes for those in CVS:
- added disttag
- setup -q
- frequent use of %{name} macro with the exception of the URL, because that's
the string I use with cut&paste and firefox to check if there's a new
version.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226314] Merge Review: prctl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226314 Orcan 'oget' Ogetbil changed: What|Removed |Added Status|NEW |CLOSED Resolution||RAWHIDE AssignedTo|nob...@fedoraproject.org|oget.fed...@gmail.com Flag||fedora-review+ --- Comment #7 from Orcan 'oget' Ogetbil 2009-01-28 12:16:45 EDT --- Great! Thanks. - This Merge Review (prctl) is APPROVED by oget - -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226314] Merge Review: prctl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226314 Orcan 'oget' Ogetbil <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #2 from Orcan 'oget' Ogetbil <[EMAIL PROTECTED]> 2008-11-13 17:31:50 EDT --- Why is there an explicit ExclusiveArch: ia64 ? I can't find any documentation that indicates this software is only for ia64. Also, do we have a branch for the ia64 architecture at Fedora? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226314] Merge Review: prctl
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226314 --- Comment #3 from Orcan 'oget' Ogetbil 2009-01-16 15:06:23 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
