[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Flag|fedora-review? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added AssignedTo|sandm...@redhat.com |tyler.l.o...@gmail.com --- Comment #12 from Fabian Affolter fab...@bernewireless.net 2009-07-18 05:58:48 EDT --- Sorry, reassign to tyler.l.owen gmail.com since this is not a bug report but a 'Merge review' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added AssignedTo|tyler.l.o...@gmail.com |sandm...@redhat.com --- Comment #11 from Fabian Affolter fab...@bernewireless.net 2009-07-18 05:56:05 EDT --- The last build: rdesktop-1.6.0-5.fc12 ssp 2009-05-01 20:17:58 Assignee changed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 --- Comment #10 from Fabian Affolter fab...@bernewireless.net 2009-05-12 18:22:22 EDT --- Check https://bugzilla.redhat.com/show_activity.cgi?id=226358 ;-) He/she was added to cc a long time ago -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 --- Comment #9 from Behdad Esfahbod besfa...@redhat.com 2009-05-11 15:48:44 EDT --- Fabian, the package is owned by Soeren Sandmann these days, not me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 --- Comment #8 from Fabian Affolter fab...@bernewireless.net 2009-05-06 09:48:25 EDT --- Behdad, I requested commit access for this package a while ago, but nothing happen. In fact the package maintainer should patch the spec file, build the package, and a packager should do the merge review ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 --- Comment #6 from Fabian Affolter fab...@bernewireless.net 2009-03-09 11:06:22 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 Behdad Esfahbod besfa...@redhat.com changed: What|Removed |Added Attachment #323691|application/octet-stream|text/plain mime type|| Attachment #323691|0 |1 is patch|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 --- Comment #7 from Behdad Esfahbod besfa...@redhat.com 2009-03-09 13:34:44 EDT --- Fabian, commit please. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC||sandm...@redhat.com --- Comment #5 from Fabian Affolter fab...@bernewireless.net 2009-01-08 07:56:50 EDT --- I guess the owner is Soren Sandmann Pedersen. Added as cc. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 --- Comment #4 from Fabian Affolter [EMAIL PROTECTED] 2008-11-15 08:29:00 EDT --- Created an attachment (id=323691) -- (https://bugzilla.redhat.com/attachment.cgi?id=323691) Patch file for the rdesktop spec file This patch should fix the issues mentioned in Comment #1. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226358 Fabian Affolter [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #3 from Fabian Affolter [EMAIL PROTECTED] 2008-10-28 05:17:53 EDT --- (In reply to comment #1) * License needs updating to new format - This was fixed from Tom spot Callaway http://cvs.fedora.redhat.com/viewvc/devel/rdesktop/rdesktop.spec?r1=1.30r2=1.31 * Source0 does not contain full URL - not fixed * Desktop file not installed correctly - not fixed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: rdesktop https://bugzilla.redhat.com/show_bug.cgi?id=226358 --- Additional Comments From [EMAIL PROTECTED] 2008-01-11 10:41 EST --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: rdesktop https://bugzilla.redhat.com/show_bug.cgi?id=226358 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226358] Merge Review: rdesktop
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Merge Review: rdesktop
https://bugzilla.redhat.com/show_bug.cgi?id=226358
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2007-12-03 22:32 EST ---
---
Summary:
---
* rpmlint not silent
* License needs updating to new format
* Source0 does not contain full URL
* Desktop file not installed correctly
---
Details:
---
OK - Mock : Built on Koji dist-f8 dist-f9
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name.
OK - Spec has consistant macro usage.
OK - Meets Packaging Guidelines.
FIX - License field in spec matches
FIX - License in new format
OK - License matches Fedora packaging policy licenses allowed
OK - License file is included in package
OK - Spec in American English
OK - Spec is legible.
FIX - Sources SHOULD match upstream md5sum:
433546f60fc0f201e99307ba188369ed rdesktop-1.5.0.tar.gz
* Source tag missing full path to source. Should be:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
OK - Package has correct buildroot.
OK - BuildRequires are not redundant.
OK - %build and %install stages are correct and work.
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories that other packages own.
OK - Changelog section is correct.
OK - Should function as described.
OK - Should package latest version
---
Rpmlint output:
---
FIX - SRPM
rdesktop.src: W: invalid-license GPL
FIX - RPM
rdesktop.i386: W: file-not-utf8 /usr/share/doc/rdesktop-1.5.0/licensing.txt
rdesktop.i386: W: file-not-utf8 /usr/share/doc/rdesktop-1.5.0/AUTHORS
rdesktop.i386: W: invalid-license GPL
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
