[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide --- Additional Comments From [EMAIL PROTECTED] 2007-12-18 15:00 EST --- Ruben: Is the package fine now? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-12-18 17:57 EST --- Thanks, approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 --- Additional Comments From [EMAIL PROTECTED] 2007-11-27 09:06 EST --- i now have added explicit correct %attr for those files. It should be fine now in which-2_18-4_fc9. Could you please check again. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 --- Additional Comments From [EMAIL PROTECTED] 2007-11-27 13:45 EST --- The warning is not about the permissions on the files after they are installed, it's about how they are stored in the srpm: [EMAIL PROTECTED] devel]$ rpmlint -i which-2.18-4.fc9.src.rpm which.src: W: strange-permission which-2.csh 0775 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. which.src: W: strange-permission which-2.sh 0775 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. [EMAIL PROTECTED] devel]$ ls -l which-2.*sh -rwxrwxr-x 1 ruben ruben 162 2007-04-23 15:04 which-2.csh -rwxrwxr-x 1 ruben ruben 170 2004-09-09 16:18 which-2.sh -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 --- Additional Comments From [EMAIL PROTECTED] 2007-11-27 17:56 EST --- ok, i have renamed which-2.*sh to which2.*sh with the correct permission. It's fixed in which-2_18-5_fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 --- Additional Comments From [EMAIL PROTECTED] 2007-11-26 10:27 EST --- The list of licenses rpmlint checks for can be found in /usr/share/rpmlint/config. I think GPLv2+ is the one you need (based on the text in which.c) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo? --- Additional Comments From [EMAIL PROTECTED] 2007-11-26 10:37 EST --- it's now fixed in which-2.18-2.fc9. could you please verify again? Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo? | --- Additional Comments From [EMAIL PROTECTED] 2007-11-26 15:25 EST --- Ok, that looks good, thanks. Now those warnings returned: which.src: W: strange-permission which-2.csh 0775 which.src: W: strange-permission which-2.sh 0775 I'm not sure, but maybe a CVS admin has to set the permissions in the repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo? --- Additional Comments From [EMAIL PROTECTED] 2007-11-20 08:31 EST --- which.src: W: strange-permission which-2.csh 0775 which.src: W: strange-permission which-2.sh 0775 strange, it's already fixed in this version. I didn't see this Warning here! could you please check again? Thanks Can you replace /etc with %{sysconfdir} in the spec? it's fixed in which-2.18-2.fc9. which.src: W: invalid-license GPL I have taken a look at COPYING here. It's GPL! What is wrong here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo? | --- Additional Comments From [EMAIL PROTECTED] 2007-11-20 08:46 EST --- it's fixed in which-2.18-2.fc9. could you please review it again. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 --- Additional Comments From [EMAIL PROTECTED] 2007-11-20 08:49 EST --- which.src: W: invalid-license GPL I have taken a look at COPYING here. It's GPL! What is wrong here? It has to be GPL, GPL+, GPLv2, GPLv2+, GPLv3 or GPLv3+ http://fedoraproject.org/wiki/Licensing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Flag|needinfo?([EMAIL PROTECTED]) | --- Additional Comments From [EMAIL PROTECTED] 2007-11-19 18:26 EST --- Hi Than, Still rpmlint errors: [EMAIL PROTECTED] devel]$ rpmlint which-2.18-1.fc9.src.rpm which.src: W: invalid-license GPL which.src: W: strange-permission which-2.csh 0775 which.src: W: strange-permission which-2.sh 0775 Can you replace /etc with %{sysconfdir} in the spec? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 --- Additional Comments From [EMAIL PROTECTED] 2007-11-13 07:14 EST --- (In reply to comment #5) /profile.d/which-2.csh W: which conffile-without-noreplace-flag /etc/profile.d/which-2.sh Use %config(noreplace) in your file section Ruben: I think these are not configuration files and are meant to be replaced with updates. It is just safe to ignore the rpmlint warning. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo?([EMAIL PROTECTED]) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] Flag|fedora-review- |fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Status|CLOSED |ASSIGNED Keywords||Reopened Resolution|RAWHIDE | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226539 --- Additional Comments From [EMAIL PROTECTED] 2007-07-05 14:02 EST --- Review for release 9: * RPM name is OK * Source which-2.16.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * File list looks OK Rpmlint is not clean. Source RPM: W: which strange-permission which-2.csh 0775 W: which strange-permission which-2.sh 0775 0644 will do just fine, the files are sourced. rpmlint of which: E: which executable-marked-as-config-file /etc/profile.d/which-2.csh E: which executable-sourced-script /etc/profile.d/which-2.csh 0755 E: which executable-marked-as-config-file /etc/profile.d/which-2.sh E: which executable-sourced-script /etc/profile.d/which-2.sh 0755 Solved quite easy by setting permissions to 0644 W: which incoherent-version-in-changelog 2.16-9.fc7 2.16-9.fc8 Don't use the disttag in the changelog W: which conffile-without-noreplace-flag /etc/profile.d/which-2.csh W: which conffile-without-noreplace-flag /etc/profile.d/which-2.sh Use %config(noreplace) in your file section -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|CLOSED Resolution||RAWHIDE Flag|needinfo? | --- Additional Comments From [EMAIL PROTECTED] 2007-04-23 09:04 EST --- all above bugs are fixed in rawhide. thanks -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added Severity|normal |medium Priority|normal |medium [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO Flag||needinfo? --- Additional Comments From [EMAIL PROTECTED] 2007-04-20 18:36 EST --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226539 --- Additional Comments From [EMAIL PROTECTED] 2007-02-18 17:43 EST --- Isn't a which-2.csh script missing? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226539] Merge Review: which
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: which https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226539 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED] |[EMAIL PROTECTED] CC||[EMAIL PROTECTED] Flag|fedora-review? |fedora-review- --- Additional Comments From [EMAIL PROTECTED] 2007-02-04 06:53 EST --- Review for release 8: * RPM name is OK * Source which-2.16.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * File list looks OK Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * The %makeinstall macro should not be used (wiki: PackagingGuidelines#MakeInstall) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) COPYING is included in the source, please add it to %doc * Please change hardcoded paths with macro's * Preserve timestamps when installing files * Please consider using {?dist} in the Release Tag (http://fedoraproject.org/wiki/DistTag) Rpmlint is not silent: Source RPM: W: which summary-ended-with-dot Displays where a particular program in your path is located. W: which strange-permission which-2.sh 0775 W: which redundant-prefix-tag W: which prereq-use /sbin/install-info W: which prereq-use dev Use Requires(post) and Requires(preun). What's the prereq dev for? rpmlint of which: W: which summary-ended-with-dot Displays where a particular program in your path is located. W: which conffile-without-noreplace-flag /etc/profile.d/which-2.sh E: which executable-marked-as-config-file /etc/profile.d/which-2.sh E: which executable-sourced-script /etc/profile.d/which-2.sh 0755 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review