[Bug 226659] Merge Review: xsri
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226659 --- Comment #5 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-12-09 22:29:21 EDT --- re-re-re-ping? Any particular reason why this merge review is being ignored? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226659] Merge Review: xsri
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226659 --- Comment #6 from Jason Tibbitts ti...@math.uh.edu 2009-12-09 23:16:17 EDT --- Just looking back at comment #1, I have no idea at all why you would think I am the last known maintainer. I've never had anything to do with the maintenance of this package. I fixed the license tag ages ago, but I fixed the license tags of many packages. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226659] Merge Review: xsri
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226659 --- Comment #7 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-12-09 23:21:46 EDT --- and how would I know that you fixed license tag of many packages? :) I just saw your name in the changelog as the last human who edited the package. I am sorry, my bad. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226659] Merge Review: xsri
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226659 Orcan 'oget' Ogetbil oget.fed...@gmail.com changed: What|Removed |Added CC||a...@redhat.com, ||mcla...@redhat.com --- Comment #4 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-06-09 15:01:59 EDT --- re-re-ping? I added two other previous maintainers to CC. Please do not ignore! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226659] Merge Review: xsri
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226659 --- Comment #3 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-04-04 01:41:14 EDT --- re-ping? shall I add someone else to CC? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226659] Merge Review: xsri
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226659 --- Comment #2 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-01-16 15:05:27 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 226659] Merge Review: xsri
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226659 Orcan 'oget' Ogetbil [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED CC||[EMAIL PROTECTED], ||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Comment #1 from Orcan 'oget' Ogetbil [EMAIL PROTECTED] 2008-12-02 22:47:39 EDT --- Here is the long awaited review for this package: * Description: The description is insufficient. The term root window does not mean much to most people. What does displays images on the root window mean? I think it should be replaced by modern day terms such as sets the wallpaper. * rpmlint says: xsri.spec:20: W: setup-not-quiet Use a -q flag on %setup macro xsri.spec: E: no-cleaning-of-buildroot %install buildroot must be cleaned at the beginning of %install xsri.src: W: no-url-tag I guess this package does not have an URL at all, so this is fine. xsri.x86_64: E: zero-length /usr/share/doc/xsri-2.1.0/NEWS The file NEWS is empty, doesn't need to be packaged. xsri.x86_64: W: incoherent-version-in-changelog 2.1.0-15 ['1:2.1.0-15.fc10', '1:2.1.0-15'] Typo? Can be fixed easily. * Group: System Environment/Base Is this the best one to pick? * We prefer %defattr(-,root,root,-) * BuildRequires: gtk2-devel = 1.3.13 From the guidelines: if the lowest possible requirement is so old that nobody has a version older than that installed on any target distribution release, there's no need to include the version in the dependency at all. gtk2-1.3 is ancient, so no need to use the specific version here. * Parallel make must be supported whenever possible. If it is not supported, this should be noted in the SPEC file as a comment. I added Jason Tibbitts to the CC since he's the last known maintainer. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
