[Bug 234717] Review Request: python-spambayes - Bayesian anti-spam filter

2007-04-27 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-spambayes - Bayesian anti-spam filter
Alias: spambayes

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234717


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |NEEDINFO
 CC||[EMAIL PROTECTED]
   Flag||needinfo?([EMAIL PROTECTED]
   ||com)




--- Additional Comments From [EMAIL PROTECTED]  2007-04-28 00:00 EST ---
Before we add this, a question.

python-$name naming was originally intended to be used mainly for libraries, not
the leaf-node applications.
yum isn't called python-yum.
system-config-securitylevel is not called python-system-config-security level.

It might be best to name the Fedora package just plain spambayes because that
matches the upstream name, and that is what people would expect it be called
when they try to install it?


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234717] Review Request: python-spambayes - Bayesian anti-spam filter

2007-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-spambayes - Bayesian anti-spam filter
Alias: spambayes

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234717


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Priority|normal  |medium




--- Additional Comments From [EMAIL PROTECTED]  2007-04-25 15:03 EST ---
Trond, did you get your bugzilla accounts sorted out?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234717] Review Request: python-spambayes - Bayesian anti-spam filter

2007-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-spambayes - Bayesian anti-spam filter
Alias: spambayes

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234717





--- Additional Comments From [EMAIL PROTECTED]  2007-04-25 15:19 EST ---
fwiw, rpmlint is clean on both src.rpm and built .noarch rpm.  neat.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234717] Review Request: python-spambayes - Bayesian anti-spam filter

2007-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-spambayes - Bayesian anti-spam filter
Alias: spambayes

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234717


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2007-04-25 15:34 EST ---
(In reply to comment #5)
 Trond, did you get your bugzilla accounts sorted out?

Indeed I did! Sorry for the slow progress. I will finish the review today.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234717] Review Request: python-spambayes - Bayesian anti-spam filter

2007-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-spambayes - Bayesian anti-spam filter
Alias: spambayes

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234717





--- Additional Comments From [EMAIL PROTECTED]  2007-04-25 15:42 EST ---
Created an attachment (id=153445)
 -- (https://bugzilla.redhat.com/bugzilla/attachment.cgi?id=153445action=view)
Complete review report.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234717] Review Request: python-spambayes - Bayesian anti-spam filter

2007-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-spambayes - Bayesian anti-spam filter
Alias: spambayes

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234717


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2007-04-25 15:44 EST ---
Package looks good to me! APPROVED by Trond Danielsen.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234717] Review Request: python-spambayes - Bayesian anti-spam filter

2007-04-25 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-spambayes - Bayesian anti-spam filter
Alias: spambayes

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234717


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2007-04-25 16:39 EST ---
New Package CVS Request
===
Package Name: python-spambayes
Short Description: Bayesian anti-spam filter
Owners: [EMAIL PROTECTED]
Branches: FC-5 FC-6 EL-5
InitialCC:

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234717] Review Request: python-spambayes - Bayesian anti-spam filter

2007-04-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-spambayes - Bayesian anti-spam filter
Alias: spambayes

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234717





--- Additional Comments From [EMAIL PROTECTED]  2007-04-08 13:46 EST ---
The package looks good to me, but I cannot assign the package to my self.
Shouldn't the package block FE_NEW?

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234717] Review Request: python-spambayes - Bayesian anti-spam filter

2007-04-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-spambayes - Bayesian anti-spam filter


https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234717





--- Additional Comments From [EMAIL PROTECTED]  2007-04-05 13:24 EST ---
Spec URL: http://tkmame.retrogames.com/fedora-extras/python-spambayes.spec
SRPM URL:
http://tkmame.retrogames.com/fedora-extras/python-spambayes-1.0.4-2.src.rpm

%changelog
* Thu Apr 05 2007 Christopher Stone [EMAIL PROTECTED] 1.0.4-2
- %%exclude pyo and pyc files from %%{_bindir}
- Add scriptlet to remove shebangs


Okay, added some stuff to remove the rpmlint warnings.  Still need to test this
out to make sure everything still works.

-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234717] Review Request: python-spambayes - Bayesian anti-spam filter

2007-04-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-spambayes - Bayesian anti-spam filter
Alias: spambayes

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234717


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Alias||spambayes




-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 234717] Review Request: python-spambayes - Bayesian anti-spam filter

2007-04-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: python-spambayes - Bayesian anti-spam filter
Alias: spambayes

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=234717


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
   ||t.org




--- Additional Comments From [EMAIL PROTECTED]  2007-04-05 14:38 EST ---
During byte compiling I get errors like this:

-
  File /usr/lib/python2.5/site-packages/spambayes/Corpus.py, line 81
SyntaxError: ('from __future__ imports must occur at the beginning of the file',
('/usr/lib/python2.5/site-packages/spambayes
/Corpus.py', 81, None, None))
-

It might not be a problem, but I fixed it by removing the line that tries to
import __future__ since it is no longer needed. I added this line to the %prep
section:

-
# Fixes warnings during byte compiling.
sed -i s/from __future__ import generators// spambayes/*.py
-

I've tested it and it builds in mock on rawhide i386. I've also tested building
it on fc6 x86_64. No problems so far.


-- 
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review