[Bug 235236] Review Request: vblade - Virtual EtherDrive (R) blade daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vblade - Virtual EtherDrive (R) blade daemon Alias: vblade https://bugzilla.redhat.com/show_bug.cgi?id=235236 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-11-30 12:29 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235236] Review Request: vblade - Virtual EtherDrive (R) blade daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vblade - Virtual EtherDrive (R) blade daemon Alias: vblade https://bugzilla.redhat.com/show_bug.cgi?id=235236 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-11-30 11:05 EST --- Package Change Request == Package Name: vblade New Branches: EL-4 EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235236] Review Request: vblade - Virtual EtherDrive (R) blade daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vblade - Virtual EtherDrive (R) blade daemon Alias: vblade https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235236 --- Additional Comments From [EMAIL PROTECTED] 2007-04-22 00:08 EST --- Note in F7 release notes under PackageNotes. Thanks for thinking of us. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235236] Review Request: vblade - Virtual EtherDrive (R) blade daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vblade - Virtual EtherDrive (R) blade daemon Alias: vblade https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235236 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235236] Review Request: vblade - Virtual EtherDrive (R) blade daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vblade - Virtual EtherDrive (R) blade daemon Alias: vblade https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235236 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE Flag|fedora-cvs+ |fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-04-09 11:25 EST --- vblade-14-2 built in devel just fine; closing this review out. Thanks again! -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235236] Review Request: vblade - Virtual EtherDrive (R) blade daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vblade - Virtual EtherDrive (R) blade daemon Alias: vblade https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235236 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? | --- Additional Comments From [EMAIL PROTECTED] 2007-04-09 11:36 EST --- Oops, Firefox caching seemed to reset fedora‑cvs to ?; unsetting. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235236] Review Request: vblade - Virtual EtherDrive (R) blade daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vblade - Virtual EtherDrive (R) blade daemon Alias: vblade https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235236 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235236] Review Request: vblade - Virtual EtherDrive (R) blade daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vblade - Virtual EtherDrive (R) blade daemon Alias: vblade https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235236 --- Additional Comments From [EMAIL PROTECTED] 2007-04-08 14:16 EST --- There is a contrib directory -- but as it's a source patch, it's probably not something to stick in %doc. Not that it is, I'm just saying. :) + source files match upstream: c5c7ed7b859d6d74575dd9facd82e2a1 vblade-14.tgz c5c7ed7b859d6d74575dd9facd82e2a1 rpms/vblade/vblade-14.tgz + package meets naming and versioning guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. (GPL) License text included. + latest version is being packaged. + BuildRequires are proper. + compiler flags are appropriate (as tweaked :) ) + %clean is present. + package installs properly + debuginfo package looks complete. + rpmlint is silent. + final provides and requires are sane: ** vblade-14-2.fc6.x86_64.rpm == rpmlint == provides config(vblade) = 14-2.fc6 vblade = 14-2.fc6 == requires /bin/sh /sbin/chkconfig /sbin/service config(vblade) = 14-2.fc6 libc.so.6()(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.4)(64bit) rtld(GNU_HASH) ** vblade-debuginfo-14-2.fc6.x86_64.rpm == rpmlint == provides vblade-debuginfo = 14-2.fc6 == requires O no %check -- but no tests either. + no shared libraries are added to the regular linker search paths. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + scriptlets look sane. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235236] Review Request: vblade - Virtual EtherDrive (R) blade daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vblade - Virtual EtherDrive (R) blade daemon Alias: vblade https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235236 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora_requires_release_note ||?, fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-04-08 16:39 EST --- Did someone get the license plate of that reviewer? Came outta nowhere... Thanks for the speedy review. Flagging CVS and release notes (again, having this in Fedora might be worth noting). -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235236] Review Request: vblade - Virtual EtherDrive (R) blade daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vblade - Virtual EtherDrive (R) blade daemon Alias: vblade https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235236 --- Additional Comments From [EMAIL PROTECTED] 2007-04-08 16:43 EST --- The template might help, sorry: New Package CVS Request === Package Name: vblade Short Description: Virtual EtherDrive (R) blade daemon Owners: [EMAIL PROTECTED] Branches: FC-5, FC-6, devel InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235236] Review Request: vblade - Virtual EtherDrive (R) blade daemon
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: vblade - Virtual EtherDrive (R) blade daemon https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235236 --- Additional Comments From [EMAIL PROTECTED] 2007-04-07 18:13 EST --- As cweyl found in this package's sibling review (aoetools, BZ#235234), the Fedora compiler flags weren't being honored, so I've released the following update: http://beer.tclug.org/fedora-extras/vblade/vblade.spec http://beer.tclug.org/fedora-extras/vblade/vblade-14-2.fc6.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
