[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list [EMAIL PROTECTED] http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-04-07 12:58 EST --- New Package CVS Request === Package Name: ocsinventory-ipdiscover Short Description: Open Computer and Software Inventory Next Generation client Owners: [EMAIL PROTECTED] Branches: devel FC-6 FC-5 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2007-04-07 12:32 EST --- I've noticed your patch in the first place. I think that the buffer you allocate is way too large when compared to the 50 chars needed for storing a netmask+the text of the error message. However it definitely does not break anything, so I did not comment over it. Since Patrice did not notice anything wrong either (btw, thank you for verifying ), the package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376 --- Additional Comments From [EMAIL PROTECTED] 2007-04-07 11:28 EST --- Thanks Manuel for looking at that. Upon reading the spec I didn't found anything wrong. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376 --- Additional Comments From [EMAIL PROTECTED] 2007-04-07 02:13 EST --- Thank's for the review Mock log devel/x86_64 : http://remi.collet.free.fr/rpms/extras/ocsinventory-ipdiscover-build2.log The patch used has been send upstream and is commited to the CVS. I've add your proposal for README in the spec file (no release bump) About the test, ocsinventory-client (with ipdiscover) is available in the Extras for a while : no bug filed. And i used it in a production environment (FC 3-6, RHEL 2-4) ;) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2007-04-06 19:05 EST --- GOOD - rpmlint checks do not return anything - package meets naming guidelines - package meets packaging guidelines - license (GPL ) OK, matches source; upstream did not include the full license, but the only existing doc (a README) mentions that the license is GPL and points to the URL - spec file legible, in am. english - source matches upstream, sha1sum 06acb6c071040d2ae6d3c26109e526afba660835 OCSNG_LINUX_AGENT_1.01.tar.gz - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all files and directories that it creates; does not take ownership of foreign files and directories - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - not a GUI, so no need for .desktop file - no static content. no libtool / pkgconfig files SHOULD - compiles and builds in mock/devel/x86_64 - there are no translations available, but %description is also in French - no scriptlets - the program does start and seems to run without problems. I cannot do full tests because I do not have the other needed programs (the agents). If someone else could test this, please give us a hand. Unless someone steps in pointing to problems that I have not spotted, Wednesday I will approve this package (I think it's a good idea to wait till after Easter). Meanwhile, Remi, please think of a method to preserve the timestamp of the README file. Using perl to remove the CR/LF line endings affects it. Maybe using "touch -r" before and after modifying the file ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376 --- Additional Comments From [EMAIL PROTECTED] 2007-04-06 11:32 EST --- Spec URL: http://remi.collet.free.fr/rpms/extras/ocsinventory-ipdiscover.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/ocsinventory-ipdiscover-1.01-2.fc7.src.rpm * Fri Apr 06 2007 Remi Collet <[EMAIL PROTECTED]> 1.01-2 - change source URL - add ocsinventory-ipdiscover.patch -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software
Inventory Next Generation client
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376
--- Additional Comments From [EMAIL PROTECTED] 2007-04-05 12:53 EST ---
Please note that according to http://fedoraproject.org/wiki/PackagingDrafts one
should use downloads.sourceforge.net instead of an arbitrarily chosen mirror, so
a better source url would be:
Source0:
http://downloads.sourceforge.net/sourceforge/ocsinventory/%{tarname}.tar.gz
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376 --- Additional Comments From [EMAIL PROTECTED] 2007-04-05 10:53 EST --- I don't have much time to devote to reviewing these days, but given the nature of the package I'll try to do the review by the end of the week. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 235376] Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ocsinventory-ipdiscover - Open Computer and Software Inventory Next Generation client https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=235376 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-04-05 10:37 EST --- Patrice, as you've done the review of ocsinventory-client, can you have a look to this one ? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
