[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 --- Additional Comments From [EMAIL PROTECTED] 2007-11-20 12:58 EST --- gst-inspector-0.3-5.fc7 has been pushed to the Fedora 7 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 --- Additional Comments From [EMAIL PROTECTED] 2007-11-20 13:02 EST --- gst-inspector-0.3-5.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 [EMAIL PROTECTED] changed: What|Removed |Added Status|CLOSED |CLOSED Resolution|NEXTRELEASE |ERRATA Fixed In Version||0.3-5.fc7 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 --- Additional Comments From [EMAIL PROTECTED] 2007-11-09 18:58 EST --- gst-inspector-0.3-5.fc7 has been pushed to the Fedora 7 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gst-inspector' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 --- Additional Comments From [EMAIL PROTECTED] 2007-11-06 11:06 EST --- gst-inspector-0.3-5.fc8 has been pushed to the Fedora 8 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update gst-inspector' -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2007-11-03 00:59 EST --- Packages imported, built, and pushed requested. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-10-26 08:01 EST --- Thanks for the review! I'll change that macro as requested. Package Change Request == Package Name: gst-inspector New Branches: F-7 F-8 devel Updated Fedora Owners: jcollie Updated Description: An introspection data viewer for the GStreamer multimedia framework -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 --- Additional Comments From [EMAIL PROTECTED] 2007-10-25 09:12 EST --- Thanks for the review! I've fixed up the problems that were identified and posted new spec/SRPM: Spec URL: http://repo.ocjtech.us/misc/fedora/7/SRPMS/gst-inspector-0.3-2.fc7.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/7/SRPMS/gst-inspector-0.3-2.fc7.src.rpm * Thu Oct 25 2007 Jeffrey C. Ollie [EMAIL PROTECTED] - 0.3-2 - Add postun and redo post section to match - Require hicolor-icons-theme - Change category for desktop entry -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gst-inspector - An introspection data viewer for the
GStreamer multimedia framework
https://bugzilla.redhat.com/show_bug.cgi?id=243576
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2007-10-26 01:09 EST ---
Approved
okay 0.3.2 looks good to me.. except one thing.
Please use %{SOURCE1} instead of %{S:1} for legibility in the spec before you
commit to cvs.
-jef
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 --- Additional Comments From [EMAIL PROTECTED] 2007-10-24 07:34 EST --- Yeah, I'd love to have a formal review... I noticed that there was a newer version out, so I updated the package and fixed the license tag. It's GPLv3+ now... Spec URL: http://repo.ocjtech.us/misc/fedora/7/SRPMS/gst-inspector-0.3-1.fc7.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/7/SRPMS/gst-inspector-0.3-1.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gst-inspector - An introspection data viewer for the
GStreamer multimedia framework
https://bugzilla.redhat.com/show_bug.cgi?id=243576
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2007-10-24 18:31 EST ---
The GOOD:
rpmlint runs clean
fits naming guidelines
specfile naming good
Licensing good: GPLv3+ and tag matches
Copying file included in docs as required
spec written in english-ese and is legible
md5sum for source matches upstream location:
69bcc7a8939582ebdb806579947b316c gst-inspector-0.3.tar.gz
builds noarch in mock against f7 and program runs
buildrequires look sane
no locales to worry about
no libs installed that need ldconfig
relocatable n/a
no duplicate file entries
owns all directories it creates
clean section is good
macro usage consistent
no content issues
no need for a docs subpackage
all doc files are non-essential
no need for -devel package
no static libs
install section looks good
desktop file included for gui application.
The BAD:
directory ownership chain issue
Need to require hicolor-icon-theme since you are installing icons in
/usr/share/icons/hicolor/
need a postun section for the icon cache updating. You have the post you just
need the corresponding postun as well:
%postun
touch --no-create %{_datadir}/icons/hicolor
if [ -x %{_bindir}/gtk-update-icon-cache ]; then
%{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || :
fi
The UGLY:
Are you sure you want to put gst-inspector in audio/video? I would have thought
this would be better in Programming menu since this isn't so much an aid to
end-users but an aid to people developing gst based scripts and applications.
-jef
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-10-23 15:02 EST --- Ping Are you still in the market for a formal review of this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/show_bug.cgi?id=243576 --- Additional Comments From [EMAIL PROTECTED] 2007-10-23 16:19 EST --- One quick note you need to update the license tag in the spec file to read GPLv2+since the text of the header in the source files reads version 2 of the License, or (at your option) any later version. The licensing guidelines changed since the ticket was opened. If you haven't done so you should review the new licensing guidance. Don't spin up a new srpm and spec for just this change. I'll make a formal review and you can spin a new spec and srpm with all changes. -jef -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243576 --- Additional Comments From [EMAIL PROTECTED] 2007-07-17 12:37 EST --- Spec URL: http://repo.ocjtech.us/misc/fedora/7/SRPMS/gst-inspector-0.2-1.fc7.spec SRPM URL: http://repo.ocjtech.us/misc/fedora/7/SRPMS/gst-inspector-0.2-1.fc7.src.rpm Update to 0.2 -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243576] Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gst-inspector - An introspection data viewer for the GStreamer multimedia framework https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243576 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] ||rge.net --- Additional Comments From [EMAIL PROTECTED] 2007-06-21 13:42 EST --- Seems good to me : built on Mock rpmlint is silent Package Guidelines seems to be followed except on two points : If the package doesn't already include and install its own .desktop file, you need to make your own, and include it as a Source If upstream uses vendor_id, leave it intact, otherwise use fedora as vendor_id -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
