[Bug 243642] Review Request: schroedinger - Portable libraries for the high quality Dirac video codec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: schroedinger - Portable libraries for the high quality Dirac video codec https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243642 --- Additional Comments From [EMAIL PROTECTED] 2007-06-21 08:49 EST --- (In reply to comment #7) Can you tell me why this package do not BuildRequires dirac-devel ? Because schroedinger doesn't use the dirac libraries, it's a complete re-implementation. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243642] Review Request: schroedinger - Portable libraries for the high quality Dirac video codec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: schroedinger - Portable libraries for the high quality Dirac video codec https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243642 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-06-20 02:07 EST --- David, are you reviewing this? If so, please set fedora-review to '?'. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243642] Review Request: schroedinger - Portable libraries for the high quality Dirac video codec
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: schroedinger - Portable libraries for the high quality
Dirac video codec
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243642
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag||fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2007-06-20 03:52 EST ---
GOOD:
- rpmlint is silent
- Follows naming guidelines
- %{name} matches base package
- Meets packaging guidelines
- License is OSI approved or compatible
- %doc's all required files
- SPEC is in US English
- SPEC is both beautiful and fully readable
- source matches upstream release
- Compile tested fine on x86_64
- All BuildRequires present
- Locale handled correctly
- Owns all files and directories
- ldconfig called in both post and postun
- Appears relocatable
- No duplicate entries in %files
- all %files sections contain %defattr and permissions appear correct
- Contains %clean and removes buildroot
- consistent use of macros
- package contains actual code
- runs without documentation
- Headers are in -devel
- library files with a suffix are in -devel
- -devel requires %{name} = %{version}-%{release}
- no -la files
- does not own files or directories already owned by other packages
- cleans out buildroot before install
- SPEC is valid UTF-8
BAD:
- License field should read LGPL/MIT/MPL as reported by upstream
- -devel package must Requires: pkgconfig as it contains a .pc file
APPROVED, just fix the license field and the Requires before checking this in.
Thank you, if you need a comaintainer for those vacation times and such I'll
happily help out.
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 243642] Review Request: schroedinger - Portable libraries for the high quality Dirac video codec
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: schroedinger - Portable libraries for the high quality Dirac video codec https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=243642 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2007-06-14 22:44 EST --- Yeah that will teach me to search _before_ packaging something, ah well your spec is a bit more correct than mine anyways. I'll do the review once I unbork mock. At a casual glance though it looks to be in great shape and it compiles beautifully on my F8 x86_64 box. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
