[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2007-06-13 19:28 EST ---
On Fedora Core 7:
* rpmlint is silent
* RPM/specfile name looks good
* Group looks good
* License is open-source compatible (GPL)
* COPYING included in source and included in %doc
* SPEC file is in English
- FIX : SPEC file %description not legible
it does not read very well (which I saw is directly from the README in the
upstream tarball)
* Source is the same as upstream
* Package builds cleanly in mock for Fedora 7 i386
* Handles locales properly (uses %find_lang)
* Package not relocatable
* Package owns all directories it creates
* No dupes in %files
* Files section contains %defattr(-,root,root,-)
* Valid clean section
* Macro usage looks good
* No large docs
* No shared libs
* No header files, static libs or *.pc files
* No libtool archives
* .desktop file included as Source1
- FIX: set to blank ("") in desktop-file-install, per packaging
guidelines (http://fedoraproject.org/wiki/Packaging/Guidelines#desktop) should
be fedora is not specified by upstream
* Install starts with rm -rf $RPM_BUILD_ROOT
* RPM installs and runs without an issue on Fedora 7 i386
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086 --- Additional Comments From [EMAIL PROTECTED] 2007-06-14 07:01 EST --- * Thu Jun 14 2007 Damien Durand <[EMAIL PROTECTED]> - 0.0.2-2 - Fix spec file description - Fix desktop file Spec URL: http://glive.tuxfamily.org/fedora/gconf-cleaner/gconf-cleaner.spec SRPM URL: http://glive.tuxfamily.org/fedora/gconf-cleaner/gconf-cleaner-0.0.2-2.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086 [EMAIL PROTECTED] changed: What|Removed |Added Product|Fedora Extras |Fedora --- Additional Comments From [EMAIL PROTECTED] 2007-06-19 07:21 EST --- ping? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086 --- Additional Comments From [EMAIL PROTECTED] 2007-06-19 07:36 EST --- My review was not an official review as I am not sponsored. Sorry for the confusion. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086 --- Additional Comments From [EMAIL PROTECTED] 2007-07-08 03:23 EST --- It is a simple and small package :) For KDE users, there is a package "kmenu-gnome". It installs all gnome/gtk applications in a seperate menu if GNOME;GTK; are in the Categories of the desktop file. Edit your desktop file so that the category line looks as follows: Categories=GNOME;GTK;X-Fedora;System; Because right now, gnome/gtk applications are mixed up with kde/qt applications in kmenu. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086 --- Additional Comments From [EMAIL PROTECTED] 2007-07-09 14:33 EST --- It's fixed SPEC URL: http://glive.tuxfamily.org/fedora/gconf-cleaner/gconf-cleaner.spec SRPMS URL: http://glive.tuxfamily.org/fedora/gconf-cleaner/gconf-cleaner-0.0.2-3.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag|fedora-review? |fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2007-07-11 07:30 EST ---
MUST Items:
- MUST: rpmlint's output is clean
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matches the base package %{name}
- MUST: The package meets the Packaging Guidelines.
- MUST: The package is licensed (GPL) with an open-source compatible license
and meet other legal requirements as defined in the legal section of Packaging
Guidelines.
- MUST: The License field in the package spec file matches the actual license.
- MUST: the source package includes the text of the license(s) in its own
file, then that file, containing the text of the license(s) for the package is
included in %doc.
- MUST: The spec file must be written in American English.
- MUST: The spec file for the package is be legible.
- MUST: The sources used to build the package must matches the upstream
source, as provided in the spec URL.
- MUST: The package successfully compiles and builds into binary rpms on at
least i386.
- MUST: All build dependencies is listed in BuildRequires.
- MUST: The spec file handles locales properly.
- MUST: If the package does not contain shared library files located in the
dynamic linker's default paths
- MUST: the package is not designed to be relocatable
- MUST: the package owns all directories that it creates.
- MUST: the package does not contain any duplicate files in the %files
listing.
- MUST: Permissions on files are set properly.
- MUST: The package has a %clean section, which contains rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
- MUST: The package consistently uses macros, as described in the macros
section of Packaging Guidelines.
- MUST: The package contains code, or permissable content. This is described
in detail in the code vs. content section of Packaging Guidelines.
- MUST: There are no Large documentation files
- MUST: %doc does not affect the runtime of the application. To summarize: If
it is in %doc, the program must run properly if it is not present.
- MUST: There are no Header files or static libraries
- MUST: The package does not contain library files with a suffix
- MUST: Package does NOT contain any .la libtool archives
- MUST: Package containing GUI applications includes a %{name}.desktop file,
and
that file must be properly installed with desktop-file-install in the %install
section.
- MUST: Package does not own files or directories already owned by other
packages.
SHOULD Items:
- SHOULD: The source package does include license text(s)
- SHOULD: mock builds succcessfully in i386.
- SHOULD: The reviewer tested that the package functions as described. A
package should not segfault instead of running, for example.
- SHOULD: No scriptlets were used, those scriptlets must be sane.
- SHOULD: No subpackages present.
APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the QA contact for the bug, or are watching the QA contact.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2007-07-11 07:40 EST --- New Package CVS Request === Package Name: gconf-cleaner Short Description: A Cleaning tool for GConf Owners: [EMAIL PROTECTED] Branches: F-7 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2007-07-11 21:43 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 244086] Review Request: gconf-cleaner - A Cleaning tool for GConf
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gconf-cleaner - A Cleaning tool for GConf https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244086 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA contact for the bug, or are watching the QA contact. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
