[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Ruben Kerkhof ru...@rubenkerkhof.com changed: What|Removed |Added Flag||needinfo?(o...@geek.co.il) --- Comment #20 from Ruben Kerkhof ru...@rubenkerkhof.com 2009-04-29 09:39:55 EDT --- Ping again -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Ruben Kerkhof [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? --- Comment #19 from Ruben Kerkhof [EMAIL PROTECTED] 2008-10-19 06:42:33 EDT --- Ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #18 from Ruben Kerkhof [EMAIL PROTECTED] 2008-10-04 09:58:59 EDT --- Hi Odel, do you have time to look at this again? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Itamar Reis Peixoto [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Alias||python-html5lib -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Ruben Kerkhof [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #16 from Ruben Kerkhof [EMAIL PROTECTED] 2008-08-24 06:54:45 EDT --- Hi Odel, Now that 0.11 is distributed in a normal zip file, is it possible to just use %setup -q to extract it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Comment #17 from Oded Arbel [EMAIL PROTECTED] 2008-08-24 16:00:38 EDT --- Yes, thanks for catching that. I'll fix this as soon as I have the time. Unfortunately I'll be out of the office in the next 4 weeks, so I probably won't have time to fix this before then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=252108 Rakesh Pandit [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEW --- Comment #15 from Rakesh Pandit [EMAIL PROTECTED] 2008-08-23 11:23:42 EDT --- Why was status ASSIGNED? @Oded My review was unofficial as I am not a sponsor. Are you still interested in package? if yes, you will need to look at this then: https://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer
https://bugzilla.redhat.com/show_bug.cgi?id=252108
--- Additional Comments From [EMAIL PROTECTED] 2008-07-06 03:52 EST ---
Thanks for the feedback.
Regarding the %{?fedora} conditional - it is required if I want to support
Fedora versions older then 8 (do I?), and Fedora 9 at least seems to still
support it. I would be very surprised if it would be dropped from future Fedora
versions.
I'll contact upstream and see if I can get them to add a license file.
Regarding the rpmlint output:
* I didn't understand the %doc output from rpmlint - I'm using %doc because I
want to package the README and examples, I don't see how it relates to headers
or static libraries. BTW - my rpmlint doesn't report that.
* The uncompressed zip file is an issue with upstream - I decided not to
repack upstream for obvious reasons. The new 0.11.1 version seems to fix this.
I've repacked and published a new version of the SPEC and package for a new
upstream version, and for Fedora 9 (which I'm currently running):
SRPM: http://rpms.geek.co.il/fc9/python-html5lib-0.11.1-1.fc9.src.rpm
SPEC: http://rpms.geek.co.il/fc9/python-html5lib.spec
RPM: http://rpms.geek.co.il/fc9/python-html5lib-0.11.1-1.fc9.noarch.rpm
The new SPEC file work seamlessly for Fedora 8 and an update package will be
available at http://rpms.geek.co.il/fc8 shortly.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer
https://bugzilla.redhat.com/show_bug.cgi?id=252108
--- Additional Comments From [EMAIL PROTECTED] 2008-07-06 04:22 EST ---
I think I should have been more clear about keys I am using
x = Checked, - = Problem, ? = No idea. :-)
Regarding the rpmlint output:
* I didn't understand the %doc output from rpmlint - I'm using %doc because I
want to package the README and examples, I don't see how it relates to headers
or static libraries. BTW - my rpmlint doesn't report that.
rpmlint out does not mention it for me either.
* The uncompressed zip file is an issue with upstream - I decided not to
repack upstream for obvious reasons. The new 0.11.1 version seems to fix this
What is fixed by 0.11.1? zip format seems to be still there.
You forget to remove tests/ folder as it is not required.
For trigger I suggest you to refer to reviewer or list or #fedora-devel %if
0%{?fedora} = 8. I will also try to verify, what is correct?
Other then these two points package looks okay to me.
Thanks.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 06:35 EST --- Ok, thanks for your comments and for checking up on the python-setuptools. I've removed the Fedora 8 test, and have new files at: SRPM: http://rpms.geek.co.il/fc9/python-html5lib-0.11.1-2.fc9.src.rpm SPEC: http://rpms.geek.co.il/fc9/python-html5lib.spec RPM: http://rpms.geek.co.il/fc9/python-html5lib-0.11.1-2.fc9.noarch.rpm Uncompressed zip: Version 0.10's zip file had all files in stored mode, meaning they are uncompressed. The current 0.11 zip file have all the files compressed properly, so the uncompressed zip warning is no longer relevant. tests/ folder: I'm not sure what you refer to - the tests folder is not packaged into the binary. It /is/ in the upstream source package, but then again I'm providing a pristine source package for obvious reasons so I can't remove it. Currently we're not running the tests as part of the build process because they cause external dependencies to be downloaded automatically (and I don't know how to turn it off), but we would probably want to do it in the future. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 05:09 EST --- Searching in 'Package source' at http://cvs.fedoraproject.org/viewcvs/rpms/ python-setuptools it looks like we don't need this trigger as python-setuptools- devel is available for FC-7 and FC-6 since 9 months now. We don't need to anyway worry about FC-6 ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 07:46 EST --- Package looks ready to me. I agree with you, about keeping pristine source, as it is not anyway in binary rpm. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer
https://bugzilla.redhat.com/show_bug.cgi?id=252108
--- Additional Comments From [EMAIL PROTECTED] 2008-07-05 06:38 EST ---
I am not sponsored. So my review is just to help this package go through
process:
You can drop the %if 0%{?fedora} = 8, conditional stuff is no longer needed as
new releases wouldn't trigger it -- verify from reviewer or on #fedora-devel
You should remove tests/ folder.
[X] rpmlint output:
python-html5lib.src: W: uncompressed-zip /html5lib-0.10.zip
The zip file is not compressed.
-- ignored Check
[X] md5sum -- matches Check
[X] version guideline naming convention -- Check
[X] spec file name -- Check
[X] description and summary -- Check
[X] build root -- Check
[X] spec license field and compatibility -- Checked
[X] license file -- absent in source -- Check
[X] readable and American language -- Check
[X] %clean -- present -- Check
[X] compile and build using koji -- Check
[X] rpmlint is silent except one message above -- Check
[X] %docs not required, no headers, no static libraries
Optional:
you may query upstream about including license text as a separate file.
Package looks okay to me.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Additional Comments From [EMAIL PROTECTED] 2008-01-28 18:18 EST --- Hi Odel, thanks for updating the package. I'm a bit busy atm, but I'll try to have another look later this week. Someone else has to sponsor you however. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/show_bug.cgi?id=252108 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |NEEDINFO Flag||needinfo?([EMAIL PROTECTED]) --- Additional Comments From [EMAIL PROTECTED] 2008-01-27 14:58 EST --- Oded, are you still interested in submitting this package? BTW, you can ignore the uncompressed-zip complaint; if that's what upstream decides to ship for whatever crazy reason, then that's what we'll take. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/show_bug.cgi?id=252108 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED]) | --- Additional Comments From [EMAIL PROTECTED] 2008-01-27 16:14 EST --- Yes, I am interested in submitting this package - how should I proceed? Also - there's a new upstream release, so I want to try to submit a package (with all the spec fixes) based on the latest release. I've repackaged html5lib 0.10 with the updated spec file and its available here: SRPM: http://rpms.geek.co.il/fc8/python-html5lib-0.10-1.fc8.src.rpm SPEC: http://rpms.geek.co.il/fc8/python-html5lib.spec RPM: http://rpms.geek.co.il/fc8/python-html5lib-0.10-1.fc8.noarch.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Additional Comments From [EMAIL PROTECTED] 2008-01-27 16:48 EST --- I'll let Ruben have first crack at this, but first some bureaucracy. I can't seem to find you in the Fedora account system at all; is this your first package for Fedora? If so, you will need a sponsor before you can be granted access to the internals of the Fedora build and release systems. Please see http://fedoraproject.org/wiki/PackageMaintainers/Join and specifically http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/show_bug.cgi?id=252108 --- Additional Comments From [EMAIL PROTECTED] 2008-01-27 17:01 EST --- Yes, this is my first package. I'll read up on this and see what I can do. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/show_bug.cgi?id=252108 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/show_bug.cgi?id=252108 [EMAIL PROTECTED] changed: What|Removed |Added Version|devel |rawhide --- Additional Comments From [EMAIL PROTECTED] 2008-01-19 19:00 EST --- Created an attachment (id=292281) -- (https://bugzilla.redhat.com/attachment.cgi?id=292281action=view) cleanup spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/show_bug.cgi?id=252108 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-01-19 19:01 EST --- Hi Odel, W: ipython-html5lib uncompressed-zip /html5lib-0.9.zip Please consider reporting this upstream. I've attached a patch to get the spec up-to-date with the latest guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 252108] Review Request: python-html5lib - A python based HTML5 parser/tokenizer
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: python-html5lib - A python based HTML5 parser/tokenizer https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=252108 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: python- |Review Request: python- |html5lib - A python based |html5lib - A python based |HTML5 parser/tokenizer |HTML5 parser/tokenizer --- Additional Comments From [EMAIL PROTECTED] 2007-08-13 18:20 EST --- rpmlint output: W: python-html5lib uncompressed-zip /html5lib-0.9.zip I can recompress the source zip file, but that would break the requirement for the source file to be md5sum identical to the upstream source, here - http://fedoraproject.org/wiki/Packaging/ReviewGuidelines -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
