[Bug 432262] Review Request: flobopuyo - 2-player falling bubbles game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flobopuyo - 2-player falling bubbles game https://bugzilla.redhat.com/show_bug.cgi?id=432262 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-03-24 05:00 EST --- New Package CVS Request === Package Name: flobopuyo Short Description: A two-player falling bubbles game. The goal is to make groups of four or more Owners: musuruan Branches: F-7 F-8 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432262] Review Request: flobopuyo - 2-player falling bubbles game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flobopuyo - 2-player falling bubbles game https://bugzilla.redhat.com/show_bug.cgi?id=432262 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-24 12:52 EST --- I assume the description here should be A two-player falling bubbles game. If thats not the case, reset the fedora-cvs flag and I will update it. cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432262] Review Request: flobopuyo - 2-player falling bubbles game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flobopuyo - 2-player falling bubbles game https://bugzilla.redhat.com/show_bug.cgi?id=432262 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432262] Review Request: flobopuyo - 2-player falling bubbles game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flobopuyo - 2-player falling bubbles game https://bugzilla.redhat.com/show_bug.cgi?id=432262 --- Additional Comments From [EMAIL PROTECTED] 2008-03-23 05:33 EST --- Spec URL: http://www.webalice.it/musuruan/RPMS/reviews/flobopuyo.spec SRPM URL: http://www.webalice.it/musuruan/RPMS/reviews/flobopuyo-0.20-2.fc8.src.rpm changelog * Sun Mar 23 2008 Andrea Musuruane [EMAIL PROTECTED] 0.20-3 - Fixed License tag - Improved macro usage I had to change LGPL+ to LGPLv2+. Rpmlint was complaining for good. There is no LGPLv1. BTW Good catch Ian! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432262] Review Request: flobopuyo - 2-player falling bubbles game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flobopuyo - 2-player falling bubbles game https://bugzilla.redhat.com/show_bug.cgi?id=432262 --- Additional Comments From [EMAIL PROTECTED] 2008-03-23 11:25 EST --- (In reply to comment #2) 1. The files glSDL.h and glSDL.c are marked as LGPL, so the license field might need to be: # glSDL.h and glSDL.c are LGPL+, all others are GPLv2+ License:GPLv2+ and LGPL+ Erm GPL trumps LGPL (as in the whole is distributed under the LGPL clause which says LGPL may be converted to GPL if you wish) so the whole can only be distributed under the GPL, and as such the license field should be just GPLv2+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432262] Review Request: flobopuyo - 2-player falling bubbles game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flobopuyo - 2-player falling bubbles game https://bugzilla.redhat.com/show_bug.cgi?id=432262 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-03-23 15:57 EST --- (In reply to comment #3) LGPLv1. BTW Good catch Ian! Ugh, apparently not. BTW I think so you posted the wrong URL so I used. http://www.webalice.it/musuruan/RPMS/reviews/flobopuyo-0.20-3.fc8.src.rpm Looks good. No need to post another update, just revert the license back to GPLv2+ (sorry!) before import. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432262] Review Request: flobopuyo - 2-player falling bubbles game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: flobopuyo - 2-player falling bubbles game
https://bugzilla.redhat.com/show_bug.cgi?id=432262
--- Additional Comments From [EMAIL PROTECTED] 2008-03-22 19:33 EST ---
* rpmlint: No Problems
* Package named correctly: Yes
* Patches named correctly: Yes
* Spec file named correctly: Yes
* Licence(s) acceptable: Yes
* Licence field matches: Not Quite (!!) See below
* Licence file installed: Yes and included upstream
* Spec file in American English: Yes
* Source matches upstream: Yes
* Locales use %find_lang: N/A
* Contains %clean: Yes
* %install contain rm -rf %{buildroot} or similar: Yes
* Specfile legible: Yes
* Compiles and builds ok: Yes (mock i386/ppc/x86_64 in devel)
* Calls ldconfig in %post/%postun for shlibs: N/A
* Owns directories it creates: Yes
* Duplicate files: No
* Permissions set correctly: Yes
* Consistent macro use: Generally yes (!!) see comments
* Separate -doc needed (for large docs): N/A
* %doc affects runtime: N/A
* Headers and static libs in -devel: N/A
* .pc files in -devel: N/A
* .so in -devel: N/A
* -devel requires base: N/A
* Contains .la files: N/A
* Owns files it didn't create: No
* .desktop files included and installed correctly: Yes
* Filenames valid UTF8: Yes
1. The files glSDL.h and glSDL.c are marked as LGPL, so the license field
might need to be:
# glSDL.h and glSDL.c are LGPL+, all others are GPLv2+
License:GPLv2+ and LGPL+
2. Not a blocker, but macro usage could be improved a little, for example when
referring to the man page.
Damn, I was playing this game for over an hour, before I remembered I was in the
middle of a review! :-)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432262] Review Request: flobopuyo - 2-player falling bubbles game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flobopuyo - 2-player falling bubbles game https://bugzilla.redhat.com/show_bug.cgi?id=432262 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 432262] Review Request: flobopuyo - 2-player falling bubbles game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flobopuyo - 2-player falling bubbles game https://bugzilla.redhat.com/show_bug.cgi?id=432262 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-03-02 07:22 EST --- Andrea, do you want to swap reviews with one of these? : * lbrickbuster2 - popular brickbusting arcadegame from lgames - bug 435514 * lure - Lure of the Temptress - Adventure Game - bug 435564 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
