[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442233 Parag AN(पराग) panem...@gmail.com changed: What|Removed |Added CC||guido.grazi...@gmail.com --- Comment #16 from Parag AN(पराग) panem...@gmail.com 2009-03-18 05:47:40 EDT --- *** Bug 490835 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442233 Dave Jones da...@redhat.com changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||WORKSFORME -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442233 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #15 from Kevin Fenzi ke...@tummy.com 2009-02-01 13:43:49 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442233 Dave Jones da...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? --- Comment #14 from Dave Jones da...@redhat.com 2009-01-30 11:56:10 EDT --- New Package CVS Request === Package Name: oprofileui Short Description: GTK2 user interface for oprofile Owners: da...@redhat.com Branches: devek InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442233 Dave Jones da...@redhat.com changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442233 Kevin Fenzi ke...@tummy.com changed: What|Removed |Added Flag|fedora-cvs? | --- Comment #13 from Kevin Fenzi ke...@tummy.com 2009-01-28 19:25:05 EDT --- Please add a cvs template here so we know what branches you want, etc. Reset the fedora-cvs flag when thats ready. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442233 --- Comment #12 from Terje Røsten terje...@phys.ntnu.no 2008-12-27 08:12:22 EDT --- Please make a cvs request: https://fedoraproject.org/wiki/PackageMaintainers/CVSAdminProcedure -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442233 Terje Røsten [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #11 from Terje Røsten [EMAIL PROTECTED] 2008-10-20 14:04:22 EDT --- I would prefer davej to post links to spec and srpm, however it's not strictly needed: APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442233 Terje Røsten [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=442233 --- Comment #10 from Dave Jones [EMAIL PROTECTED] 2008-10-08 15:42:18 EDT --- looks great to me. Thanks Terje. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oprofileui - user interface for analysing oprofile data https://bugzilla.redhat.com/show_bug.cgi?id=442233 --- Additional Comments From [EMAIL PROTECTED] 2008-07-22 07:45 EST --- ping davej This pkg seems near to be finished, need your review of Terje's SRPM spec. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oprofileui - user interface for analysing oprofile data https://bugzilla.redhat.com/show_bug.cgi?id=442233 --- Additional Comments From [EMAIL PROTECTED] 2008-07-02 07:15 EST --- (In reply to comment #5) - remove vendor in desktop-file-install Why's that? In ./data/oprofile-viewer.desktop.in there's no vendor-related info and according to http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage there should be one. Am I missing something? BuildRequires: libxml-devel Shouldn't it be libxml2-devel? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oprofileui - user interface for analysing oprofile data https://bugzilla.redhat.com/show_bug.cgi?id=442233 --- Additional Comments From [EMAIL PROTECTED] 2008-07-02 07:31 EST --- Am I missing something? See #447766 comment #5, and http://fedoraproject.org/wiki/Packaging/Minutes20080603#t12:15 Shouldn't it be libxml2-devel? You are right. (Some other dep pulled in libxml2-devel, as seen from the koji logs). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oprofileui - user interface for analysing oprofile data https://bugzilla.redhat.com/show_bug.cgi?id=442233 --- Additional Comments From [EMAIL PROTECTED] 2008-07-02 10:45 EST --- apologies for my lack of updates on this, I've been busy with some other stuff. I hope to get back to this soon. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oprofileui - user interface for analysing oprofile data https://bugzilla.redhat.com/show_bug.cgi?id=442233 --- Additional Comments From [EMAIL PROTECTED] 2008-06-30 15:03 EST --- - [OK] License Field in spec - [-] License text in %doc Ok, however not correct version. * Add it as SourceX and copy-in in installation process. This is in fact ok already, my bad, sorry. Would be nice if original reporter could fix the issues, they are all EasyFix... To help the reporter I have created a updated package: - add desktop-file-utils - remove vendor in desktop-file-install - remove libglade2 and libxml from reqs (picked up by rpm) - fix macro usage - fix timestamp on sources and installed files - fix docs - add %%post/%%postun scripts - license is GPLv2 spec: http://terjeros.fedorapeople.org/oprofileui/oprofileui.spec srpm: http://terjeros.fedorapeople.org/oprofileui/oprofileui-0.2.0-2.fc9.src.rpm koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=687854 Could you please have a look Dave? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: oprofileui - user interface for analysing oprofile data
https://bugzilla.redhat.com/show_bug.cgi?id=442233
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2008-06-25 17:15 EST ---
oprofileui.x86_64: E: explicit-lib-dependency libglade2
oprofileui.x86_64: E: explicit-lib-dependency libxml
* No. Can't be. This means that you can omit it from spec file ('Requires:')
because RPMbuild found them while creating package and thus added it to the RPM
automatically.
- [OK] License Field in spec
- [-] License text in %doc
Ok, however not correct version.
* Add it as SourceX and copy-in in installation process.
Would be nice if original reporter could fix the issues, they are all EasyFix...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: oprofileui - user interface for analysing oprofile data https://bugzilla.redhat.com/show_bug.cgi?id=442233 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-12 05:14 EST --- Review in progress... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 442233] Review Request: oprofileui - user interface for analysing oprofile data
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: oprofileui - user interface for analysing oprofile data
https://bugzilla.redhat.com/show_bug.cgi?id=442233
[EMAIL PROTECTED] changed:
What|Removed |Added
Flag|fedora-review+ |fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2008-05-12 05:17 EST ---
Review Guidelines MUST items:
- [?] rpmlint output:
oprofileui.x86_64: E: explicit-lib-dependency libglade2
oprofileui.x86_64: E: explicit-lib-dependency libxml
Can be ignored?
- [OK] package name
- [OK] %{name}.spec
- [OK] Packaging Guidelines
- [-] Licensing Guidelines
Seems like GPLv2, not GPLv2+ to me.
COPYING has 2+. however all files has GPLv2 only.
- [OK] License Field in spec
- [-] License text in %doc
Ok, however not correct version.
- [OK] Spec file in en_US
- [OK] legible spec file
- [-] source matches upstream
4ebd15796d44f2fd29ecd37c77021d41 oprofileui-0.2.0.tar.gz
4ebd15796d44f2fd29ecd37c77021d41 oprofileui-0.2.0.tar.gz.1
source is ok, however fix timestamp with e.g.
wget -N http://labs.o-hand.com/sources/oprofileui/oprofileui-0.2.0.tar.gz
- [-] compiles successfully
- [-] BuildRequires
Add desktop-file-utils to BuildRequires, now build stops with:
/var/tmp/rpm-tmp.67346: line 32: desktop-file-install: command not found
See: http://koji.fedoraproject.org/koji/taskinfo?taskID=604356
- N/A %find_lang
- N/A shared libs
- N/A not relocatable
- [OK] directory ownership
- [OK] no duplicate files in %files
- [OK] proper permissions on files, %defattr present
- [OK] %clean section cleans %{buildroot}
- [-] consistently uses macros
Change $RPM_OPT_FLAGS to %{optflags}
- [OK] package contains code
- N/A large docs
- [OK] %doc files do not affect runtime behaviour
- N/A header files in -devel
- N/A static libs in -static
- N/A foo.pc files
- N/A libfoo.so.1.1
- N/A no devel package
- N/A no .la archives
- [OK] desktop file
- [OK] Does not own files/dirs owned by other packages
- [OK] %install cleans out %{buildroot} first
- [OK] all filenames are valid ASCII and thus UTF-8
- [-] Scriptlets
Add script to cache the shipped icons:
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda
Review Guidelines SHOULD items:
- [-] license text, not correct, ping upstream?
- N/A no translated descriptions available
- [-] don't build in mock:
http://koji.fedoraproject.org/koji/taskinfo?taskID=604356
- [-] build on all arch
- [OK] appears to work
- N/A no scriptlets (yet)
- N/A no sub-packages
- N/A no foo.pc
- N/A no file dependencies
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
