[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 --- Additional Comments From [EMAIL PROTECTED] 2008-05-28 11:34 EST --- (In reply to comment #2) > I have never heard that noarch package should not use parallel > make. You're absolutely right, sorry, temporary brain outage... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl
applications
https://bugzilla.redhat.com/show_bug.cgi?id=446414
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2008-05-28 11:18 EST ---
+ source files match upstream : 904f6fe4b94248b56507710b29a53873
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text included in package.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock ( ).
+ package installs properly
- rpmlint is silent :
file-not-utf8 /usr/share/man/man3/Gtk2::Ex::FormFactory::*.3pm.gz
- final provides and requires are sane:
These provides are bogus :
perl(Music::Album)
perl(Music::Artist)
perl(Music::Config)
perl(Music::DBI)
perl(Music::Genre)
perl(Music::Song)
This is weird as the doc files that induce that are not executable.
+ %check is present and all tests pass
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
Also, package is noarch, replace "make %{?_smp_mflags}" by a simple "make"
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 --- Additional Comments From [EMAIL PROTECTED] 2008-05-28 11:28 EST --- I have never heard that noarch package should not use parallel make. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 --- Additional Comments From [EMAIL PROTECTED] 2008-05-28 11:55 EST --- Spec URL: http://kwizart.fedorapeople.org/SPECS/perl-Gtk2-Ex-FormFactory.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-Gtk2-Ex-FormFactory-0.65-2.fc8.kwizart.src.rpm Description: Framework for Gtk2 perl applications Changelog - Fix man3 encoding - Fix unwanted perl provides (Music::*) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-05-28 15:45 EST --- All the .pm under lib/ are iso8859, so rather than fixing the man page encoding in %install, I would move all of them to utf-8 in %prep. not sure this is really a blocker, I don't find anything in the guidelines. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl
applications
https://bugzilla.redhat.com/show_bug.cgi?id=446414
--- Additional Comments From [EMAIL PROTECTED] 2008-05-29 04:10 EST ---
Something like that should do :
for f in $(find lib/ -name *.pm) README tutorial/README; do
cp -p ${f} ${f}.noutf8
iconv -f ISO-8859-1 -t UTF-8 ${f}.noutf8 > ${f}
touch -r ${f}.noutf8 ${f}
rm ${f}.noutf8
done
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 --- Additional Comments From [EMAIL PROTECTED] 2008-05-29 13:25 EST --- Spec URL: http://kwizart.fedorapeople.org/SPECS/perl-Gtk2-Ex-FormFactory.spec SRPM URL: http://kwizart.fedorapeople.org/SRPMS/perl-Gtk2-Ex-FormFactory-0.65-3.fc8.kwizart.src.rpm Description: Framework for Gtk2 perl applications -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-29 18:31 EST --- looks good, APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-05-29 19:50 EST --- New Package CVS Request === Package Name: perl-Gtk2-Ex-FormFactory Short Description: Framework for Gtk2 perl applications Owners: kwizart Branches: F-8 F-9 EL-4 EL-5 InitialCC: perl-sig Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-05-30 16:04 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 446414] Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Gtk2-Ex-FormFactory - Framework for Gtk2 perl applications https://bugzilla.redhat.com/show_bug.cgi?id=446414 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
