[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 Peter Robinson <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Comment #24 from Peter Robinson <[EMAIL PROTECTED]> 2008-10-27 06:45:16 EDT --- Built and in rawhide -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 Kevin Fenzi <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |ASSIGNED Flag|fedora-cvs? |fedora-cvs+ --- Comment #23 from Kevin Fenzi <[EMAIL PROTECTED]> 2008-10-23 16:05:46 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #22 from Denis Leroy <[EMAIL PROTECTED]> 2008-10-21 18:11:08 EDT --- > I'll include the patch but as specified above it was causing me problems This one won't, as it checks whether the init call is needed or not, as suggested by the API documentation. I didn't pursue further why it's needed on my F-10 system and not on my other F-9 server, but it's related to ATK and Gnome assistive setups. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 Peter Robinson <[EMAIL PROTECTED]> changed: What|Removed |Added Flag|needinfo? | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 Peter Robinson <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||needinfo?, fedora-cvs? --- Comment #21 from Peter Robinson <[EMAIL PROTECTED]> 2008-10-21 17:56:08 EDT --- New Package CVS Request === Package Name: gupnp-tools Short Description: GUPnP-tools is a collection of dev tools utilising GUPnP and GTK+ Owners: pbrobinson Branches: F-9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #20 from Peter Robinson <[EMAIL PROTECTED]> 2008-10-21 17:53:29 EDT --- I'll include the patch but as specified above it was causing me problems and if others report the issues I saw I will revert it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 Denis Leroy <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||fedora-review+ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #19 from Denis Leroy <[EMAIL PROTECTED]> 2008-10-21 17:30:55 EDT --- If you include the patch I provided, yes that's APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #18 from Peter Robinson <[EMAIL PROTECTED]> 2008-10-21 15:36:49 EDT --- So is that approved? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #17 from Denis Leroy <[EMAIL PROTECTED]> 2008-10-21 07:08:28 EDT --- > Actually according to the packaging guidelines the Vendor should only be set > if > there isn't one already in use. They already use 'gupnp' Sounds good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=447456
--- Comment #16 from Peter Robinson <[EMAIL PROTECTED]> 2008-10-21 06:38:30
EDT ---
> - according to guidelines, "--vendor=fedora" should be used for
> desktop-file-install
Actually according to the packaging guidelines the Vendor should only be set if
there isn't one already in use. They already use 'gupnp'
https://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
> - the %files section could be written with just 3 lines:
> %{_datadir}/gupnp-tools
> %{_bindir}/gupnp*
> %{_datadir}/applications/*.desktop
Yes, I'm aware of that but the reason I tend to do it the other way is that you
don't get unexpected files that may be introduced on a new release. Its one of
those 6 to one, hlaf a dozen to the other things.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=447456
--- Comment #15 from Denis Leroy <[EMAIL PROTECTED]> 2008-10-21 03:27:02 EDT
---
- License is GPLv2+
- rpmlint ok
- spec file is good
- source md5sum good
- packages build
- utilities function correctly , i386 and x86_64
2 minor things:
- according to guidelines, "--vendor=fedora" should be used for
desktop-file-install
- the %files section could be written with just 3 lines:
%{_datadir}/gupnp-tools
%{_bindir}/gupnp*
%{_datadir}/applications/*.desktop
If you're ok with the patch I submitted, consider the package APPROVED. I've
tested the package on F-9 x86_64 and F10 i386.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #14 from Denis Leroy <[EMAIL PROTECTED]> 2008-10-11 12:10:31 EDT --- > So either change your call to g_thread_init() to check whether > threads are already supported. Yes I read the API doc as well, and that's exactly what the patch I attached does. What I don't understand is why gtk_init() calls g_thread_init() on my system and not on Peter's system... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #13 from Bastien Nocera <[EMAIL PROTECTED]> 2008-10-11 10:36:06 EDT --- >From the API docs: g_thread_init() might only be called once. On the second call it will abort with an error. If you want to make sure that the thread system is initialized, you can do this: if (!g_thread_supported ()) g_thread_init (NULL); So either change your call to g_thread_init() to check whether threads are already supported, or run g_thread_init() before anything else (and if it still crashes, file a bug against whatever is not checking for g_thread_supported() before calling g_thread_init). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 Denis Leroy <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #12 from Denis Leroy <[EMAIL PROTECTED]> 2008-10-11 09:54:53 EDT --- Matthias, I was wondering if you could shed some light on this. Peter and I are seeing a different runtime behavior of these gupnp tools. On my f10-system, the uv tools immediately abort because g_thread_init() is called twice. If I run the tool from the debugger, the gupnp tool explicitly calls gtk_init(), then g_thread_init() right below. On my system, gtk_init() also calls g_thread_init() (through atk_bridge_init(), bonobo_activation_init() and corba orb init()), hence the abort. Any insights ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #11 from Peter Robinson <[EMAIL PROTECTED]> 2008-10-11 09:33:17 EDT --- Yes, I've tested it on F-10 on both i386 (netbook) and x86_64 (VM) and wasn't seeing any crash when running on F-10. The VM is setup with 2 cores, and the netbook while not real dual core is hyperthreaded. I'll test it later today. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #10 from Denis Leroy <[EMAIL PROTECTED]> 2008-10-11 09:25:17 EDT --- Created an attachment (id=320093) --> (https://bugzilla.redhat.com/attachment.cgi?id=320093) Patch to fix g_thread_init crash issue Peter, do you have a F-10 system to test this ? I've upgraded my system to F-10, and the GThread init crash still exist for all 3 utilities here. That's working on F-10 for you ? Maybe I'm seeing a different glib behavior because my system is dual-core, I don't know. I'm attaching the patch required for it to work on my system. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #9 from Peter Robinson <[EMAIL PROTECTED]> 2008-10-08 06:32:07 EDT --- Hi Denis, Any chance to retest this? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #8 from Peter Robinson <[EMAIL PROTECTED]> 2008-09-29 07:15:57 EDT --- OK. There's a new 0.6.1 release out. I've tested this and it build and runs fine on the current rawhide. I've done a scratch build in koji and tested the resulting binaries work on i386 rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=849551 New SRPM. http://pbrobinson.fedorapeople.org/gupnp-tools-0.6.1-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #7 from Peter Robinson <[EMAIL PROTECTED]> 2008-09-17 08:04:43 EDT --- Hi Denis, Removing the calls to g_thread_init on 0.6 had the apps crash for me with the following error on universal-cp and av-cp, network-light segfaulted on rawhide (all 3 gave the error on F-9 but ran fine without the patch): # gupnp-universal-cp GLib-ERROR **: The thread system is not yet initialized. aborting... Aborted So it looks like there is other issues. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Comment #6 from Denis Leroy <[EMAIL PROTECTED]> 2008-09-10 04:47:48 EDT --- Hi Peter, The 0.6.1 release is not available on the download site, which prevents me from verifying the tarball as part of the review process. Also, the calls to g_thread_init() are still there and the tools still crash on startup. I would recommend to base the review on 0.6 for now and to write a patch to remove the 3 calls to g_thread_init(). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=447456 Bug 447456 depends on bug 446639, which changed state. Bug 446639 Summary: Review Request: gupnp - GUPnP is an framework for creating UPnP devices & control points https://bugzilla.redhat.com/show_bug.cgi?id=446639 What|Old Value |New Value Status|NEW |ASSIGNED Resolution||NEXTRELEASE Status|ASSIGNED|CLOSED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+ https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Additional Comments From [EMAIL PROTECTED] 2008-07-01 15:54 EST --- New location SPEC: http://pbrobinson.fedorapeople.org/gupnp-tools.spec SRPM: http://pbrobinson.fedorapeople.org/gupnp-tools-0.6-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+ https://bugzilla.redhat.com/show_bug.cgi?id=447456 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||447457 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+ https://bugzilla.redhat.com/show_bug.cgi?id=447456 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||446639 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 447456] Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gupnp-tools: a collection of dev tools utilising GUPnP and GTK+ https://bugzilla.redhat.com/show_bug.cgi?id=447456 --- Additional Comments From [EMAIL PROTECTED] 2008-06-17 05:42 EST --- New version, new srpm. Spec is the same location SRPM URL: http://fedora.roving-it.com/rawhide/gupnp-tools-0.6-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
