[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs https://bugzilla.redhat.com/show_bug.cgi?id=448215 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 15:25 EST --- Upstream released a new version and basically used my path patch, so no patching is needed anymore. Updated spec: http://vpv.fedorapeople.org/packages/mozvoikko/mozvoikko.spec New SRPM: http://vpv.fedorapeople.org/packages/mozvoikko/mozvoikko-0.9.4.1.3-0.1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs https://bugzilla.redhat.com/show_bug.cgi?id=448215 --- Additional Comments From [EMAIL PROTECTED] 2008-06-24 16:54 EST --- Upstream released a new version, this is the first "official" release via Sourceforge. There were only a couple of small changes, here's the updated package. Updated SPEC: http://vpv.fedorapeople.org/packages/mozvoikko/mozvoikko.spec New SRPM: http://vpv.fedorapeople.org/packages/mozvoikko/mozvoikko-0.9.5-0.1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs https://bugzilla.redhat.com/show_bug.cgi?id=448215 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-07 14:53 EST --- I finally got around to updating to F-9 and thus reviewing this. If I understand correctly, using xulrunner-unstable makes this prone to breakage on updates - is there some versioned dependency towards some package that could be used so that it would be easier to notice such cases? The dependency on libvoikko works, but as the sources hardcode libvoikko.so.1 and libmalaga.so.7, it could be good to have the dependency to those sonames. I've done that in the pcsc-perl package, check it out for an example if you agree implementing that would be feasible. Would Applications/Internet be a better Group: value? Aren't all Mozilla apps this package works with Internet related ones? When other Mozilla apps that can use this are shipped in Fedora, the dependency on firefox should probably be dropped, right? None of the above are blockers but just comments and food for thought, approved as is. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs https://bugzilla.redhat.com/show_bug.cgi?id=448215 --- Additional Comments From [EMAIL PROTECTED] 2008-07-14 17:15 EST --- Thanks for the review. I think you have made some important points here and I probably won't build the package until I have at least some sort of answers for those questions. Unfortunately I've been a bit busy lately, I will try to make time to work on this package this week. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs https://bugzilla.redhat.com/show_bug.cgi?id=448215 --- Additional Comments From [EMAIL PROTECTED] 2008-07-18 12:55 EST --- Just an update, I'm currently working on the xulrunner-unstable/dependency issue. There was an update to Firefox today in F-9, which caused a dependency issue with nspluginwrapper (it had gecko-libs = 1.9 as a dependency). I had the mozvoikko package installed, which has an unversioned dependency on xulrunner and it worked normally after the update. My current suggestion is to leave it as is and if there is actual breakage, I'll just have to rebuild the package. Apparently you can't count that much on version numbers with xulrunner. A new testing version with some Makefile changes was released today, I'll have to test that on Fedora, but it seems like the package could BuildRequire just xulrunner-devel instead of xulrunner-devel-unstable. But still some of the headers mozvoikko needs are apparently classified as unstable upstream, I'm not sure why they are in the "regular" devel package on Fedora. I'll probably post about this on the fedora-devel mailing list. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for
Mozilla programs
https://bugzilla.redhat.com/show_bug.cgi?id=448215
--- Additional Comments From [EMAIL PROTECTED] 2008-07-18 16:00 EST ---
Updated spec: http://vpv.fedorapeople.org/packages/mozvoikko/mozvoikko.spec
New SRPM:
http://vpv.fedorapeople.org/packages/mozvoikko/mozvoikko-0.9.5-0.2.fc9.src.rpm
(In reply to comment #9)
> If I understand correctly, using xulrunner-unstable makes this prone to
> breakage
> on updates - is there some versioned dependency towards some package that
> could
> be used so that it would be easier to notice such cases?
I've now asked about this on fedora-devel, we'll see if there are any comments.
Voikko upstream developers told me there's quite rarely breakage with the
unstable headers mozvoikko uses. I've added a patch which modifies
Makefile.xulrunner so that xulrunner-devel-unstable is not needed anymore, but I
think that won't actually change the situation, because the same headers are
just included from a different directory now.
(The new testing version which was released today just modified
Makefile.xulrunner in a way which made it simpler for Debian, but it didn't work
on Fedora, so upstream will continue with 0.9.5.)
> The dependency on libvoikko works, but as the sources hardcode libvoikko.so.1
> and libmalaga.so.7, it could be good to have the dependency to those sonames.
> I've done that in the pcsc-perl package, check it out for an example if you
> agree implementing that would be feasible.
Done, I haven't yet built the package on 64 bit, though, but it should work
there as well.
> Would Applications/Internet be a better Group: value? Aren't all Mozilla apps
> this package works with Internet related ones?
Changed. To me it doesn't really matter that much, but this is probably better.
> When other Mozilla apps that can use this are shipped in Fedora, the
> dependency
> on firefox should probably be dropped, right?
Yes. My current plan of doing this is to put the files into
%{_libdir}/mozilla/extensions/%{firefox_app_id}/%{firefox_ext_id} as is done now
and then symlink them to %{_libdir}/mozilla/extensions/<{thunderbird, seamonkey}
app id here>/%{firefox_ext_id}. This would mean that the mozvoikko package would
have to co-own those directories together with the firefox, thunderbird and
seamonkey packages, but then any actual dependencies to the applications (except
xulrunner of course) could be dropped.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs https://bugzilla.redhat.com/show_bug.cgi?id=448215 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-07-21 14:12 EST --- Since I have not gotten any feedback on my fedora-devel post about this package and xulrunner, I'll request CVS and build the package. For F-9 I'll probably keep it in updates-testing until I get some feedback from users that it works with their Mozilla profiles and so on. Here's the request: New Package CVS Request === Package Name: mozvoikko Short Description: Finnish Voikko spell-checker extension for Mozilla programs Owners: vpv Branches: F-9 Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs https://bugzilla.redhat.com/show_bug.cgi?id=448215 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-07-22 11:46 EST --- I wonder if it would be worth checking with the fedora-packaging list to see if anyone had thoughts on xulrunner/extension packaging before importing this? There was some discussion last year on fedora-devel: https://www.redhat.com/archives/fedora-devel-list/2007-April/msg00855.html -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs https://bugzilla.redhat.com/show_bug.cgi?id=448215 --- Additional Comments From [EMAIL PROTECTED] 2008-07-23 13:19 EST --- If you ask me, no need to hold the import for that; I think this is nothing new and there are already packages in the distro in a similar situation with xulrunner. Not sure about extension packaging but anyway, the plan in comment 13 sounds perfectly reasonable to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs https://bugzilla.redhat.com/show_bug.cgi?id=448215 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-24 13:52 EST --- I suppose not, just would be good to do moving forward... cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448215] Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: mozvoikko - Finnish Voikko spell-checker extension for Mozilla programs https://bugzilla.redhat.com/show_bug.cgi?id=448215 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-07-25 16:02 EST --- The package has been built and should (soon) be in Rawhide and F9 updates-testing. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
