[Bug 448422] Review Request: trophy - Car racing game with special features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||RAWHIDE --- Additional Comments From [EMAIL PROTECTED] 2008-06-02 15:57 EST --- Imported and build, updates pushed for F-8 and F-9, closing. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448422] Review Request: trophy - Car racing game with special features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-06-01 13:32 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448422] Review Request: trophy - Car racing game with special features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-06-01 03:37 EST --- New Package CVS Request === Package Name: trophy Short Description: Car racing game with special features Owners:jwrdegoede Branches: F-8 F-9 InitialCC: Cvsextras Commits: Yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448422] Review Request: trophy - Car racing game with special features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-06-01 03:13 EST --- this package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448422] Review Request: trophy - Car racing game with special features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 14:59 EST --- (In reply to comment #1) > formal review: > Thanks! > > => only the BR: needs fixing Duh / oops, fixed version here: Spec URL: http://people.atrpms.net/~hdegoede/trophy.spec SRPM URL: http://people.atrpms.net/~hdegoede/trophy-1.1.5-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448422] Review Request: trophy - Car racing game with special features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 05:35 EST --- formal review: OK source files match upstream: 11fbf36691e4db909d7a641daa8e5983431ce6f0 trophy-1.1.5.tar.gz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. OK license field matches the actual license. OK license is open source-compatible (GPL). License text included in package. OK latest version is being packaged. BAD BuildRequires are proper - ClanLib-devel is missing OK compiler flags are appropriate. OK %clean is present. OK package builds in mock (Rawhide/x86_64) OK debuginfo package looks complete. OK rpmlint is silent. OK final provides and requires look sane. N/A %check is present and all tests pass. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets for updating the icon cache are present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. OK is a GUI app, desktop file is installed => only the BR: needs fixing -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448422] Review Request: trophy - Car racing game with special features
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
