[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 04:29 EST --- Wanna swap reviews? : * elice - Elice is a PureBasic to c++ translator / compiler https://bugzilla.redhat.com/show_bug.cgi?id=448310 * lostlabyrinth - Lost Labyrinth is a coffeebreak dungeon crawling game https://bugzilla.redhat.com/show_bug.cgi?id=448311 * lostlabyrinth-sounds - Lost Labyrinth sounds https://bugzilla.redhat.com/show_bug.cgi?id=448312 * lostlabyrinth-graphics - Lost Labyrinth graphics https://bugzilla.redhat.com/show_bug.cgi?id=448313 * trophy - Car racing game with special features https://bugzilla.redhat.com/show_bug.cgi?id=448422 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: cylindrix - 3 degrees of freedom combat game
https://bugzilla.redhat.com/show_bug.cgi?id=448748
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2008-06-14 14:28 EST ---
Full review done, must fix:
* You don't BuildRequire anything you need at least allegro-devel
* Currently you copy everything to %{_datadir} and then remove what you don't
need, thats really the wrong way around, esp you mostly need to copy a few
dirs.
* crashes on x86_64 (I'll investigate this and see if I can come up with a fix)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-14 14:29 EST --- More must fix: * Remove bogus ChangeLog INSTALL NEWS README files from %doc, they are all useless. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-15 17:45 EST --- Created an attachment (id=309415) --> (https://bugzilla.redhat.com/attachment.cgi?id=309415&action=view) cylindrix-1.0-fix-packing.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-15 17:46 EST --- Created an attachment (id=309416) --> (https://bugzilla.redhat.com/attachment.cgi?id=309416&action=view) cylindrix-1.0-arch-independ-file-read.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-15 17:44 EST --- OKay, I now have it working on x86_64, and with these it should work on ppc too, I've already submitted these patches upstream. cylindrix-1.0-fix-packing.patch: Change #ifdef so that packing of applicable structures gets enabled, remove PACKED_STRUCT macro from struct members which have 1 byte alignment by default to shut up warnings. This fixes playback of the cylindrix logo fli on startup cylindrix-1.0-arch-independ-file-read.patch: reading a memory dump of a struct from disk, will only work on the same machine as the struct was created, replace the simple fread(struct) calls with code which knows the data on disk is an intel struct dump and reads it in such a way it will work on any platform cylindrix-1.0-use-int-not-long.patch: cylindrix uses longs all over the place in the sourcecode where it wants 32 bits integers, however longs are 64 bit on 64 bit machines wrecking havoc, this patch replaces all use of long with int. Note, Even with these we are still not good to go, I need to also make the writing of the overal stats system independent and currently saving any settings / stats will not work at all when run as user, because you are starting cylindrix under /usr/share/cylindrix where it cannot write its settings. Instead from the script you should create a ~/.cylindrix, symlink the relevant data dirs under there, and copy the config / pilot files, so that they can be overridden and then start cylindrix-bin under ~/.cylindrix. I'll be waiting for a new version from you to review with all the mentioned Must FIX items fixed, these patches applied and the startup script modified so that settings cna be saved. Once that is done I'll start working on making the overal stat saving platform agnostic. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-15 17:46 EST --- Created an attachment (id=309417) --> (https://bugzilla.redhat.com/attachment.cgi?id=309417&action=view) cylindrix-1.0-use-int-not-long.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-16 12:02 EST --- All the above addressed. Thanks for the massive amount of work! SRPM: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix-1.0-2.fc9.src.rpm SPEC: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-16 14:08 EST --- Much better, but still needs a tiny bit of work: MUST FIX * Don't install cylindrix.rc, cylindrix.dsp and cylindrix.ico, those are visual studio project files * When an icon is installed in the fdo icon hierarchy it should be named without extension in the .desktop file * Apply one more patch to fix writing of overal stats on non i386 machines (I'll start working on this now, so don't expect it to be attached immediately). SHOULD FIX -- * Change: 'make CFLAGS="$RPM_OPT_FLAGS"' to 'make CFLAGS="$RPM_OPT_FLAGS -Wno-pointer-sign"' This way only the usefull warnings remain. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-16 14:30 EST --- Corrected VS files, icon extension, cflags. SRPM: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix-1.0-3.fc9.src.rpm SPEC: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-16 15:23 EST --- Created an attachment (id=309525) --> (https://bugzilla.redhat.com/attachment.cgi?id=309525&action=view) cylindrix-1.0-arch-independ-file-write.patch More MUST FIX: -- * The "if [ ! -a ~/.cylindrix ]; then" line in cylindrix.sh should be if [ ! -d ~/.cylindrix ]; then Now it tries to create all the symlinks each time flooding the terminal with errors * gamedata should be copied and not symlinked, as it contains various files which are written More should fix: * It would be better to at the end of cylindrix.sh, not use: 'cylindrix-bin' but instead use: exec cylindrix-bin "$@" The exec stops from a useless sh process hanging around and the "$@" passes any options passed to the script to the executable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 [EMAIL PROTECTED] changed: What|Removed |Added Attachment #309525|0 |1 is obsolete|| --- Additional Comments From [EMAIL PROTECTED] 2008-06-16 15:32 EST --- Created an attachment (id=309526) --> (https://bugzilla.redhat.com/attachment.cgi?id=309526&action=view) cylindrix-1.0-arch-independ-file-write.patch New version, which does not mess up the displaying of the filenames in the menu, please use this version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-16 15:47 EST --- All addressed, with new patch. SRPM: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix-1.0-4.fc9.src.rpm SPEC: http://zanoni.jcomserv.net/fedora/cylindrix/cylindrix.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-06-16 16:04 EST --- Perfect: approved! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-06-16 16:18 EST --- New Package CVS Request === Package Name: cylindrix Short Description: 3 degrees of freedom combat game Owners: limb Branches: devel F-9 F-8 InitialCC: Cvsextras Commits: yes Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-06-16 16:48 EST --- CVS Done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-17 09:08 EST --- cylindrix-1.0-4.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-06-17 09:10 EST --- Imported, built, updates submitted. Thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-17 09:09 EST --- cylindrix-1.0-4.fc8 has been submitted as an update for Fedora 8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-17 23:15 EST --- cylindrix-1.0-4.fc8 has been pushed to the Fedora 8 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-06-17 23:16 EST --- cylindrix-1.0-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 448748] Review Request: cylindrix - 3 degrees of freedom combat game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cylindrix - 3 degrees of freedom combat game https://bugzilla.redhat.com/show_bug.cgi?id=448748 --- Additional Comments From [EMAIL PROTECTED] 2008-07-26 02:10 EST --- cylindrix-1.0-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
