[Bug 449151] Review Request: pyodbc - Python DB API 2.0 Module for ODBC

2008-06-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyodbc - Python DB API 2.0 Module for ODBC


https://bugzilla.redhat.com/show_bug.cgi?id=449151


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449151] Review Request: pyodbc - Python DB API 2.0 Module for ODBC

2008-06-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyodbc - Python DB API 2.0 Module for ODBC


https://bugzilla.redhat.com/show_bug.cgi?id=449151


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-06-03 12:24 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449151] Review Request: pyodbc - Python DB API 2.0 Module for ODBC

2008-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyodbc - Python DB API 2.0 Module for ODBC


https://bugzilla.redhat.com/show_bug.cgi?id=449151


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




--- Additional Comments From [EMAIL PROTECTED]  2008-06-02 14:57 EST ---
(In reply to comment #0)
 Spec URL: http://www.bludgeon.org/~rayvd/rpms/pyodbc/pyodbc.spec
 SRPM URL: http://www.bludgeon.org/~rayvd/rpms/pyodbc/pyodbc-2.0.58-1.src.rpm

Looks OK for first look. rpmlint is clean, spec file is simple.

But does not build in mock:

DEBUG: /var/tmp/rpm-tmp.46918: line 27: /usr/bin/python: No such file or 
directory

I think python-devel or something similar is missing from BuildRequires.
Please fix this.

 Questions:
 - Should I included text of the MIT license even though source package doesn't
 include it?

I think no. You should ask developers to add license into package, but do not
include other license files into rpm.

- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.

- SHOULD: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449151] Review Request: pyodbc - Python DB API 2.0 Module for ODBC

2008-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyodbc - Python DB API 2.0 Module for ODBC


https://bugzilla.redhat.com/show_bug.cgi?id=449151





--- Additional Comments From [EMAIL PROTECTED]  2008-06-02 15:25 EST ---
I'll poke upstream on this and add it when they do.

Updated files:

http://www.bludgeon.org/~rayvd/rpms/pyodbc/pyodbc.spec
http://www.bludgeon.org/~rayvd/rpms/pyodbc/pyodbc-2.0.58-2.src.rpm

(This builds for me in mock for EL5-i386, my Fedora mock setup is broken 
currently)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449151] Review Request: pyodbc - Python DB API 2.0 Module for ODBC

2008-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyodbc - Python DB API 2.0 Module for ODBC


https://bugzilla.redhat.com/show_bug.cgi?id=449151





--- Additional Comments From [EMAIL PROTECTED]  2008-06-02 15:55 EST ---
Although there are many of warnings compiling on Fedora 9, I can build it for F8
and F9.

This is a warning on F9:
cursor.cpp:1159: warning: deprecated conversion from string constant to 'char*'
You can send this warning upstream, may be they know how to fix this.

Please, remove Buildrequire for python, it is automatically required by
python-devel, which is enough. Just fix this in spec file and I will approve
this package.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449151] Review Request: pyodbc - Python DB API 2.0 Module for ODBC

2008-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyodbc - Python DB API 2.0 Module for ODBC


https://bugzilla.redhat.com/show_bug.cgi?id=449151





--- Additional Comments From [EMAIL PROTECTED]  2008-06-02 16:56 EST ---
Thanks Jan; d'oh on the python BuildRequire.  This has been addressed.

http://www.bludgeon.org/~rayvd/rpms/pyodbc/pyodbc.spec
http://www.bludgeon.org/~rayvd/rpms/pyodbc/pyodbc-2.0.58-3.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449151] Review Request: pyodbc - Python DB API 2.0 Module for ODBC

2008-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyodbc - Python DB API 2.0 Module for ODBC


https://bugzilla.redhat.com/show_bug.cgi?id=449151


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-06-03 00:24 EST ---
Thank you for new package. :-)

APPROVED


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 449151] Review Request: pyodbc - Python DB API 2.0 Module for ODBC

2008-06-02 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: pyodbc - Python DB API 2.0 Module for ODBC


https://bugzilla.redhat.com/show_bug.cgi?id=449151


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-06-03 00:57 EST ---
New Package CVS Request
===
Package Name: pyodbc
Short Description: Python DB API 2.0 Module for ODBC
Owners: rayvd
Branches: F-8 F-9 EL-5
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review