[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies https://bugzilla.redhat.com/show_bug.cgi?id=449234 --- Additional Comments From [EMAIL PROTECTED] 2008-05-31 15:14 EST --- http://koji.fedoraproject.org/koji/taskinfo?taskID=638376 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies https://bugzilla.redhat.com/show_bug.cgi?id=449234 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||449251 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies https://bugzilla.redhat.com/show_bug.cgi?id=449234 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies https://bugzilla.redhat.com/show_bug.cgi?id=449234 --- Additional Comments From [EMAIL PROTECTED] 2008-06-01 00:00 EST --- New Package CVS Request === Package Name: perl-Catalyst-Plugin-Session-State-Cookie Short Description: Maintain session IDs using cookies Owners: cweyl Branches: F-7, F-8, F-9, devel InitialCC: perl-sig -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain
session IDs using cookies
https://bugzilla.redhat.com/show_bug.cgi?id=449234
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
Flag||fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2008-05-31 22:39 EST ---
Review:
+ package builds in mock (rawhide i386).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=638376
+ rpmlint is silent for SRPM but NOT for RPM.
perl-Catalyst-Plugin-Session-State-Cookie.src:38: W: rpm-buildroot-usage %prep
FOO=`perl -p -e 's|%{buildroot}%{_docdir}/%{name}-%{version}\S+||'`
$RPM_BUILD_ROOT should not be touched during %build or %prep stage, as it
will break short circuiting.
==> I think this will not be a problem.
+ source files match upstream url
0eb184e081051ca284c2952ba6db59f7
Catalyst-Plugin-Session-State-Cookie-0.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
All tests successful.
Files=5, Tests=32, 3 wallclock secs ( 1.16 cusr + 0.21 csys = 1.37 CPU)
+ Package perl-Catalyst-Plugin-Session-State-Cookie-0.09-1.fc10 =>
Provides: perl(Catalyst::Plugin::Session::State::Cookie) = 0.09
Requires: perl(:MODULE_COMPAT_5.10.0) perl(Catalyst::Plugin::Session) >= 0.19
perl(Catalyst::Utils) perl(NEXT) perl(base) perl(strict) perl(warnings)
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies https://bugzilla.redhat.com/show_bug.cgi?id=449234 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-06-01 13:35 EST --- cvs done. (Except for F-7, as we are no longer doing F-7 branches.) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 449234] Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Catalyst-Plugin-Session-State-Cookie - Maintain session IDs using cookies https://bugzilla.redhat.com/show_bug.cgi?id=449234 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-06-01 14:12 EST --- Imported and built for rawhide. Thanks for the review! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
