[Bug 450481] libibcommon package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450481 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Status|ASSIGNED|CLOSED CC||lemen...@gmail.com Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450481] libibcommon package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450481 Bug 450481 depends on bug 450470, which changed state. Bug 450470 Summary: RDMA kernel stack initializing package https://bugzilla.redhat.com/show_bug.cgi?id=450470 What|Old Value |New Value Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450481] libibcommon package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libibcommon package https://bugzilla.redhat.com/show_bug.cgi?id=450481 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-06-30 09:19 EST --- New Package CVS Request === Package Name: libibcommon Short Description: OpenFabrics Alliance InfiniBand management common library Owners: dledford Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450481] libibcommon package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libibcommon package https://bugzilla.redhat.com/show_bug.cgi?id=450481 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-06-30 12:16 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450481] libibcommon package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libibcommon package https://bugzilla.redhat.com/show_bug.cgi?id=450481 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-06-29 09:30 EST --- OK, its APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450481] libibcommon package
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: libibcommon package
https://bugzilla.redhat.com/show_bug.cgi?id=450481
[EMAIL PROTECTED] changed:
What|Removed |Added
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
Status|NEW |ASSIGNED
Flag||fedora-review?
--- Additional Comments From [EMAIL PROTECTED] 2008-06-28 12:01 EST ---
Here's a review (this time pasted into the correct bz entry!):
GOOD:
+ source matches upstream SHA1SUM:
1a2b36d0f309690ad660c9c1ff177f76c2484104 libibcommon-1.1.0.tar.gz
1a2b36d0f309690ad660c9c1ff177f76c2484104 libibcommon-1.1.0.tar.gz.UP
+ license is correct and correctly included in the main package
+ specfile looks clean and macros sane
+ proper use of ldconfig
+ *.la files are removed
+ proper use of -devel and -static
+ has %clean
+ builds in mock F8 x86_64
+ rpmlint reports just two ignore-able warnings:
libibcommon-devel.x86_64: W: no-documentation
libibcommon-static.x86_64: W: no-documentation
+ dir ownership looks good
+ permissions look good
NEEDSWORK:
- according to the review guidelines, the spec must have:
rm -rf %{buildroot}
or the equivalent at the start of %install section.
- Is the ExclusiveArch really necessary? Could it just be deleted?
I'm only asking because the review guidelines now include specific
rules concerning ExcludeArch and, if the ExclusiveArch is removed,
then I think the package will be fine wrt those guidelines. Maybe
a comment such as is known to work on arches ... but has not been
tested on ... would be enough?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450481] libibcommon package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libibcommon package https://bugzilla.redhat.com/show_bug.cgi?id=450481 --- Additional Comments From [EMAIL PROTECTED] 2008-06-28 22:15 EST --- Fixed the %install section Removed the ExclusiveArch. The software can be built anywhere, but obviously without a hardware driver, it's useless. The ExclusiveArch just mimicked what I knew to be working architectures as far as the kernel and the driver situation is concerned. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450481] libibcommon package
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: libibcommon package https://bugzilla.redhat.com/show_bug.cgi?id=450481 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||450482 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
