[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450539 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added CC|fedora-package-rev...@redha | |t.com | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450539 Till Maas opensou...@till.name changed: What|Removed |Added CC||opensou...@till.name Status Whiteboard||NotReady --- Comment #12 from Till Maas opensou...@till.name 2009-04-18 10:50:06 EDT --- Please clear NotReady from the whiteboard when this request is ready for a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450539 Fabian Affolter fab...@bernewireless.net changed: What|Removed |Added Flag||needinfo?(t...@niemueller.de ||) --- Comment #8 from Fabian Affolter fab...@bernewireless.net 2009-01-12 05:08:09 EDT --- Is there any progress with this bug? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450539 --- Comment #9 from Noel J. Bergman n...@devtech.com 2009-01-12 09:34:18 EDT --- For what it is worth, I have a replacement for the VNC plugin. Trying to get it into upstream, and will post here for your convenience. It handles three of the common VNC viewers, so it is more distro and version independent, and provides an easy means to plugin any other VNC viewer that someone might want. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450539 Noel J. Bergman n...@devtech.com changed: What|Removed |Added External Bug ID||Ubuntu Launchpad 130334 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450539 --- Comment #10 from Noel J. Bergman n...@devtech.com 2009-01-12 09:37:12 EDT --- Created an attachment (id=328742) -- (https://bugzilla.redhat.com/attachment.cgi?id=328742) Replacement VNC plugin for Service Discovery Applet This replaces vncviewer.py.in. It autodetects which vnc viewer is available, and handles the difference in command line parameters including the port / screen difference between XVNC and Vinagre. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450539 Tim Niemueller t...@niemueller.de changed: What|Removed |Added Flag|needinfo?(t...@niemueller.de | |) | --- Comment #11 from Tim Niemueller t...@niemueller.de 2009-01-12 13:34:18 EDT --- I'm currently short in time. I still think the service-discovery-applet should be in Fedora. My time constraints (thesis) will not allow me to do this before March though. Either we wait or someone else takes over. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=450539 Fabian Affolter [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #7 from Fabian Affolter [EMAIL PROTECTED] 2008-12-08 06:56:27 EDT --- An other small thing...I would suggest to switch the URL from 'http://0pointer.de/cgi-bin/viewcvs.cgi/?root=service-discovery-applet' to 'http://avahi.org', the upstream website. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel https://bugzilla.redhat.com/show_bug.cgi?id=450539 --- Additional Comments From [EMAIL PROTECTED] 2008-07-04 17:48 EST --- (In reply to comment #3) - intltool already requires gettext and perl(XML::Parser) I have to correct myself: The F-8 intltool package doesn't require gettext (the Requirements are completely messed up on F-8), so it's better to BuildRequire it explicitly. Tim, are there any problems with my suggestions/feedback? If so, please let me know. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel https://bugzilla.redhat.com/show_bug.cgi?id=450539 --- Additional Comments From [EMAIL PROTECTED] 2008-07-04 18:10 EST --- I'll be out of the country for the next weeks, I'll be back at the end of July and then I'll work on this again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: service-discovery-applet - Service discovery applet
based on Avahi for the Gnome panel
https://bugzilla.redhat.com/show_bug.cgi?id=450539
--- Additional Comments From [EMAIL PROTECTED] 2008-06-30 19:51 EST ---
(In reply to comment #2)
My first search was for
service-discovery-applet so I wouldn't have found it with that name. Would yum
search provides lines to remedy this problem?
No, unfortunately not. 'yum install service-discovery-applet' would work but not
'yum search'. IMO this is something that should be fixed in yum. Nevertheless we
should stick to the naming guidelines I think.
So you can with the date, just use svn co -r{DATE}... Having a date usually
makes it easier to get a feeling how up2date the package really is.
Ok, agreed as it's in line with the naming guidelines.
I usually keep it for easy spawning new packages by copying. I can't see in
the
guidelines that I shouldn't.
It's written in the python spec template from rpmdev-newrpmspec, but in the end
it's your decision.
Ah, needs to require avahi-tools, which contains the Python bindings for some
reason... Thanks for pointing this out!
But I still don't see a Requires: on avahi-tools, only the BuildRequires that
has been there before. :(
I've uploaded a new SPEC (same URL as above) and new SRPM (at
http://fedorapeople.org/~timn/misc/service-discovery-applet-0.4.5-0.3.svn20080609.fc9.src.rpm).
Ok, a few more comments on that one:
Why not change
# cd service-discovery-applet
# svn export service-discovery-applet service-discovery-applet-0.4.5.svn`date
+%Y%m%d`
# cd ..
to
# svn export . ../service-discovery-applet-0.4.5.svn`date +%Y%m%d`
tar cvfz ...
needs to be
tar -cvfz ...
BuildRoot tag is wrong, according to the guidelines it should be
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
BuildRequires perl-XML-Parser should be perl(XML::Parser) instead
Are you sure you need gettext-devel and not only gettext?
You have a lot of redundant build requirements that don't need to be specified
explicitly:
- libtool requires autoconf and automake, automake requires autoconf and perl
- GConf2-devel requires automake and glib2-devel
- intltool already requires gettext and perl(XML::Parser)
- perl(XML::Parser) of course requires perl
As long as you don't specify a version it is not necessary to list all these
BRs.
Use export GCONF_DISABLE_MAKEFILE_SCHEMA_INSTALL=1 to avoid error messages due
to missing permissions during %install. You are also missing the necessary
scriptlets to (un)install the gconf schemas, see
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets#GConf
Use make %{?_smp_mflags}, although it won't make much difference.
Please fix %defattr to (-,root,root-). Only cosmetics, I know. ;)
%{_libdir}/bonobo/servers/GNOME_ServiceDiscoveryApplet.server
%{_libdir} will become /usr/lib64 on x86_64, so this package cannot be noarch.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel https://bugzilla.redhat.com/show_bug.cgi?id=450539 --- Additional Comments From [EMAIL PROTECTED] 2008-06-30 20:15 EST --- (In reply to comment #3) Why not change # cd service-discovery-applet # svn export service-discovery-applet service-discovery-applet-0.4.5.svn`date +%Y%m%d` # cd .. to # svn export . ../service-discovery-applet-0.4.5.svn`date +%Y%m%d` Oops, I 'fixed' the wrong line. ;( Should read: Why not change # cd service-discovery-applet # svn export . ../service-discovery-applet-0.4.5.svn`date +%Y%m%d` # cd .. to # svn export service-discovery-applet service-discovery-applet-0.4.5.svn`date +%Y%m%d` -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel https://bugzilla.redhat.com/show_bug.cgi?id=450539 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-06-29 11:07 EST --- Not an official review, just a few thoughts: I suggest to name this package gnome-applet-service-discovery, see http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28General.29 Better name a svn snapshot after the revision and not the date, because then the reviewer can simply check out the correrct version with svn co -rX svn://svn.0pointer.de/service-discovery-applet/trunk service-discovery-applet I see you define both python_sitelib and python_sitearch. Please remove the unneeded definition. You are missing a requirement: $ service-discovery-applet Traceback (most recent call last): File /usr/bin/service-discovery-applet, line 51, in module error_msg(_(A required python module is missing!\n%s) % (e)) File /usr/bin/service-discovery-applet, line 29, in error_msg d = gtk.MessageDialog(parent=None, flags=gtk.DIALOG_MODAL, NameError: global name 'gtk' is not defined running service-discovery-config gives a messagebox saying: Ein benötigtes Python Modul fehlt! No module named avahi Not sure if we have a python-avahi package -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 450539] Review Request: service-discovery-applet - Service discovery applet based on Avahi for the Gnome panel
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: service-discovery-applet - Service discovery applet
based on Avahi for the Gnome panel
https://bugzilla.redhat.com/show_bug.cgi?id=450539
--- Additional Comments From [EMAIL PROTECTED] 2008-06-29 18:43 EST ---
(In reply to comment #1)
Not an official review, just a few thoughts:
I suggest to name this package gnome-applet-service-discovery, see
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28General.29
Hmm, this is different from upstream. My first search was for
service-discovery-applet so I wouldn't have found it with that name. Would yum
search provides lines to remedy this problem?
Better name a svn snapshot after the revision and not the date, because then
the
reviewer can simply check out the correrct version with
svn co -rX svn://svn.0pointer.de/service-discovery-applet/trunk
service-discovery-applet
So you can with the date, just use svn co -r{DATE}... Having a date usually
makes it easier to get a feeling how up2date the package really is. I've used
this for other packages already. Just assume someone tried to do this on git or
cvs stuff...
I see you define both python_sitelib and python_sitearch. Please remove the
unneeded definition.
I usually keep it for easy spawning new packages by copying. I can't see in the
guidelines that I shouldn't.
You are missing a requirement:
$ service-discovery-applet
Traceback (most recent call last):
File /usr/bin/service-discovery-applet, line 51, in module
error_msg(_(A required python module is missing!\n%s) % (e))
File /usr/bin/service-discovery-applet, line 29, in error_msg
d = gtk.MessageDialog(parent=None, flags=gtk.DIALOG_MODAL,
NameError: global name 'gtk' is not defined
running service-discovery-config gives a messagebox saying:
Ein benötigtes Python Modul fehlt!
No module named avahi
Not sure if we have a python-avahi package
Ah, needs to require avahi-tools, which contains the Python bindings for some
reason... Thanks for pointing this out!
I've uploaded a new SPEC (same URL as above) and new SRPM (at
http://fedorapeople.org/~timn/misc/service-discovery-applet-0.4.5-0.3.svn20080609.fc9.src.rpm).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
