[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||CURRENTRELEASE Fixed In Version||2.5-2.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 02:12 EST --- dbus-java-2.5-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-07-04 09:05 EST --- New Package CVS Request === Package Name: dbus-java Short Description: dbus-java Owners: omajid Branches: F-9 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-04 16:22 EST --- cvs done. I used the Short Description from the spec file Java implementation of the DBus protocol -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 --- Additional Comments From [EMAIL PROTECTED] 2008-07-04 17:23 EST --- dbus-java-2.5-2.fc9 has been submitted as an update for Fedora 9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-03 22:04 EST --- OK, this builds now. I agree about ignoring that rpmlint complaint; it doesn't understand conditional evaulation. The test suite seems to run fine for me. The wrapper scripts look good to me now, although I admit I didn't install and run them. Anyway, everything looks fine. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 --- Additional Comments From [EMAIL PROTECTED] 2008-07-02 15:56 EST --- Well, I tried to reproduce the build failure but couldn't after eight tries. Honestly I've no idea what might have happened So just the test failure remains, which you indicated on IRC was a problem in libmatthew, so I'll just try later after rawhide has updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 --- Additional Comments From [EMAIL PROTECTED] 2008-07-02 01:23 EST --- Hmm, this failed to build for me. I think the error is in %build when generating the documentation. I tried to disable parallel make and the failure disappears, but then the test suite just seems to hang forever. The last command running is: java -Djava.library.path=/usr/lib64/libmatthew-java -classpath :/usr/lib64/libmatthew-java/unix.jar:/usr/lib64/libmatthew-java/hexdump.jar:/usr/lib64/libmatthew-java/debug-disable.jar:libdbus-java-2.5.jar:dbus-java-test-2.5.jar org.freedesktop.dbus.test.test The output at that point is: Creating Connection Exception in thread main java.lang.UnsatisfiedLinkError: Can't load library: /usr/lib/libmatthew-java/libunix-java.so at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1666) at java.lang.Runtime.load0(Runtime.java:787) at java.lang.System.load(System.java:1022) at cx.ath.matthew.unix.UnixSocket.clinit(UnixSocket.java:33) at org.freedesktop.dbus.Transport.connect(Unknown Source) at org.freedesktop.dbus.Transport.init(Unknown Source) at org.freedesktop.dbus.DBusConnection.init(Unknown Source) at org.freedesktop.dbus.DBusConnection.getConnection(Unknown Source) at org.freedesktop.dbus.test.test.main(Unknown Source) So I went back to build the original rpm (with parallel make enabled) and it gets through to the hanging %check section. So I guess there are a couple of problems: some race condition with extremely parallel make (I build on an 8-core system) and the test suite seems busted. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: dbus-java - Java implementation of the DBus protocol
https://bugzilla.redhat.com/show_bug.cgi?id=452688
--- Additional Comments From [EMAIL PROTECTED] 2008-06-30 11:59 EST ---
Updated packages:
Spec URL: http://omajid.fedorapeople.org/dbus-java/dbus-java.spec
SRPM URL: http://omajid.fedorapeople.org/dbus-java/dbus-java-2.5-1.fc9.src.rpm
fixed incoherent name warning, fixed wrapper scripts and added %check (upstream
had one but i hadnt come across %check while reading up on packaging).
rpmlint reports a warning
dbus-java.src:149: W: libdir-macro-in-noarch-package %attr(-,root,root)
%{_libdir}/gcj/%{name}
which i am ignoring because when the package is built as noarch, this
conditional line is not executed
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 --- Additional Comments From [EMAIL PROTECTED] 2008-06-30 12:04 EST --- This package doesn't seem to be any different than the package in comment 1. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: dbus-java - Java implementation of the DBus protocol
https://bugzilla.redhat.com/show_bug.cgi?id=452688
--- Additional Comments From [EMAIL PROTECTED] 2008-06-30 14:49 EST ---
Bumped up the release number
Spec URL: http://omajid.fedorapeople.org/dbus-java/dbus-java.spec
SRPM URL: http://omajid.fedorapeople.org/dbus-java/dbus-java-2.5-2.fc9.src.rpm
copying changes from comment 3:
fixed incoherent name warning, fixed wrapper scripts and added %check (upstream
had one but i hadnt come across %check while reading up on packaging).
rpmlint reports a warning
dbus-java.src:149: W: libdir-macro-in-noarch-package %attr(-,root,root)
%{_libdir}/gcj/%{name}
which i am ignoring because when the package is built as noarch, this
conditional line is not executed
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? Bug 452688 depends on bug 452251, which changed state. Bug 452251 Summary: Review Request: libmatthew-java - collection of java libraries https://bugzilla.redhat.com/show_bug.cgi?id=452251 What|Old Value |New Value Status|NEW |CLOSED Resolution||CURRENTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-06-29 14:50 EST --- This builds fine. The only rpmlint complaint is: dbus-java.x86_64: W: incoherent-version-in-changelog 2.5-1.fc9 2.5-1.fc10 which happens because I'm building this on rawhide. Normally you just don't include the dist tag in your changelog versions. I'm a bit confused by the installed wrapper scripts; they all contain: JARPATH=/usr/local/share/java which doesn't seem correct. Installing and running ListDBus gives me: Exception in thread main java.lang.NoClassDefFoundError: org/freedesktop/dbus/bin/ListDBus Caused by: java.lang.ClassNotFoundException: org.freedesktop.dbus.bin.ListDBus at java.net.URLClassLoader$1.run(URLClassLoader.java:217) [...] The guidelines are unfortunately silent on the subject of symlinking the jar files, but this seems to be common enough. * source files match upstream: 2b2001aa2fccc6cc3eedfeb35d2c7b13e52811c27820f27f0f6ce0e8f547ad65 dbus-java-2.5.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. X rpmlint has one minor complaint which is easy to fix. * final provides and requires are sane: dbus-java-2.5-1.fc10.x86_64.rpm dbus-2.5.jar.so()(64bit) dbus-bin-2.5.jar.so()(64bit) dbus-viewer-2.5.jar.so()(64bit) dbus-java = 2.5-1.fc10 = /bin/sh java-1.6.0-openjdk java-gcj-compat = 1.0.31 jpackage-utils libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcj_bc.so.1()(64bit) libz.so.1()(64bit) dbus-java-javadoc-2.5-1.fc10.x86_64.rpm dbus-java-javadoc = 2.5-1.fc10 = jpackage-utils X %check is not present; no test suite upstream. I'm not sure how to test this, honestly, since I don't know much about dbus, but just running ListDBus seems to fail badly. * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * scriptlets are OK; gcj-rebuild-db stuff. * code, not content. * %docs are not necessary for the proper functioning of the package. * no pre-built jars * single jar, named after the package * jarfiles are under _javadir. * javadocs are under _javadocdir. X wrapper scripts provided, but not working properly. * gcj called properly. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 --- Additional Comments From [EMAIL PROTECTED] 2008-06-26 14:49 EST --- Upstream released a new version. No code changes. Updated spec file and srpm: Spec URL: http://omajid.fedorapeople.org/dbus-java/dbus-java.spec SRPM URL: http://omajid.fedorapeople.org/dbus-java/dbus-java-2.5-1.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452688] Review Request: dbus-java - Java implementation of the DBus protocol
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: dbus-java - Java implementation of the DBus protocol https://bugzilla.redhat.com/show_bug.cgi?id=452688 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||452251 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
