[Bug 452805] Review Request: ember - WorldForge client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452805 --- Comment #2 from Alexey Torkhov [EMAIL PROTECTED] 2008-09-11 08:04:07 EDT --- Spec URL: http://purple.worldforge.org/~alex/fedora/ember.spec SRPM URL: http://purple.worldforge.org/~alex/fedora/ember-0.5.4-1.fc10.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=819928 Update to 0.5.4. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452805] Review Request: ember - WorldForge client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452805 Tom spot Callaway [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Comment #3 from Tom spot Callaway [EMAIL PROTECTED] 2008-09-11 13:10:11 EDT --- REVIEW == Good: - rpmlint checks return: ember.x86_64: W: conffile-without-noreplace-flag /etc/ember/ogre.cfg ember.x86_64: W: conffile-without-noreplace-flag /etc/ember/resources.cfg ember.x86_64: W: conffile-without-noreplace-flag /etc/ember/terrain.cfg Documented why you didn't do this, safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream (f5d94ac46131bcf0bb7788e311331aac523287b8) - package compiles on devel (x86_64, koji scratch) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - desktop file ok Nice job with this package, APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452805] Review Request: ember - WorldForge client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452805 --- Comment #4 from Alexey Torkhov [EMAIL PROTECTED] 2008-09-11 16:26:46 EDT --- Many thanks for review! New Package CVS Request === Package Name: ember Short Description: 3D client for WorldForge Owners: atorkhov wart Branches: F-9 InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 452805] Review Request: ember - WorldForge client
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ember - WorldForge client Alias: ember https://bugzilla.redhat.com/show_bug.cgi?id=452805 --- Additional Comments From [EMAIL PROTECTED] 2008-07-09 16:47 EST --- Spec URL: http://purple.worldforge.org/~alex/fedora/ember.spec SRPM URL: http://purple.worldforge.org/~alex/fedora/ember-0.5.3-1.fc10.src.rpm Update to 0.5.3. All patches are now merged. License upgraded to GPLv3+. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
