[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Additional Comments From [EMAIL PROTECTED] 2008-07-08 05:17 EST --- I think so un-fonts and un-fonts-extra, I wish that I think will be more comfortable. un-fonts-core and un-core-fonts are too uncomfortable or the naming -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 [EMAIL PROTECTED] changed: What|Removed |Added BugsThisDependsOn||453016 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Additional Comments From [EMAIL PROTECTED] 2008-06-28 07:23 EST --- Summary: Un series Korean TrueType fonts Spec URL: http://get9.net/rpm/un-fonts-extra.spec SRPM URL: http://get9.net/rpm/un-fonts-extra-1.0.2.080608-1.fc9.src.rpm Description: This is a set of Korean TrueType fonts. Un-fonts is comes from the HLaTeX as type1 fonts in 1998 by Koaunghi Un It converted to TrueType with the FontForge(PfaEdit) by Won-kyu Park in 2003. This package has only the most common font families. Install un-fonts-core for additional fonts. #1 Rebuild and repackaging for rpmlint #2 Changed package name to Un series Korean TrueType fonts #3 Summary and description of the changes, added to Korean #4 Added %define archiveversion 080608, because 080608 is snapshot version #5 I have a problem in korean spacing words for rpmlint. I don't fix it #6 fixed License: GPLv2+ -- Problem #5 # rpmlint -i un-fonts-extra.spec un-fonts-extra.spec:25: W: non-break-space line 25 The spec file contains a non-break space, which looks like a regular space in some editors but can lead to obscure errors. It should be replaced by a regular space. un-fonts-extra.spec:27: W: non-break-space line 27 The spec file contains a non-break space, which looks like a regular space in some editors but can lead to obscure errors. It should be replaced by a regular space. un-fonts-extra.spec:28: W: non-break-space line 28 The spec file contains a non-break space, which looks like a regular space in some editors but can lead to obscure errors. It should be replaced by a regular space. 0 packages and 1 specfiles checked; 0 errors, 3 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 [EMAIL PROTECTED] changed: What|Removed |Added CC||fedora-fonts-bugs- ||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-07-04 17:16 EST --- 1. Please complete http://fedoraproject.org/wiki/UN_Extra_fonts 2. Please make sure you've performed the other font packager actions documented on phase 2 of http://fedoraproject.org/wiki/Font_package_lifecycle Package review will follow -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Additional Comments From [EMAIL PROTECTED] 2008-07-04 17:31 EST --- 4. and do check your summary and description, so they're different from un-core-fonts -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: un-fonts-extra - Korean TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=453017
--- Additional Comments From [EMAIL PROTECTED] 2008-07-04 17:29 EST ---
Spec review of http://get9.net/rpm/un-fonts-extra.spec-1
I see you've strayed quite a bit from our official template
http://fedoraproject.org/wiki/Annotated_fonts_spec_template
(checked with meld)
1. Most of your changes look harmless but please do make sure you use the
official scriplets and not something else.
2. Also I'm not really sure about the
%build
%{nil}
thing
3. If you can please have upstream publish the sfd files they use and rebuild
the fonts from sfds in your package
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: un-fonts-extra - Korean TrueType fonts
https://bugzilla.redhat.com/show_bug.cgi?id=453017
--- Additional Comments From [EMAIL PROTECTED] 2008-07-04 17:37 EST ---
5. if upstream has not released a 1.0.2 version yet, and 1.0.2.080608 is an
alpha/beta/pre-release of 1.0.2:
A. use 1.0.2 as version
B. use a 0.X.%{alphatag} release with %{alphatag}=080608
( see
http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Pre-Release_packages )
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Additional Comments From [EMAIL PROTECTED] 2008-07-04 17:42 EST --- 6. I'd really name the package un-extra-fonts. un-fonts-extra/un-fonts-core makes it look like they're both subpackages of the same srpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo?([EMAIL PROTECTED]) --- Additional Comments From [EMAIL PROTECTED] 2008-07-04 17:46 EST --- That's all for the informal review. Since a formal review is very time consuming, I'll wait till those first remarks are taken into account before going through the whole http://fedoraproject.org/wiki/Packaging/ReviewGuidelines list -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED])| --- Additional Comments From [EMAIL PROTECTED] 2008-07-05 11:56 EST --- (In reply to comment #4) > 4. and do check your summary and description, so they're different from > un-core-fonts i see, un fonts package will be two kinds of fonts family. un-core-fonts and un-extra-fonts, So I used package name in the original package and i'll repackaging in 1.0 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||fedora-review?, ||needinfo?([EMAIL PROTECTED]) --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 07:33 EST --- Ok. Please ping me there when you have a new spec ready. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED])| --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 08:29 EST --- Summary: Un Extra families Korean TrueType fonts Spec URL: http://get9.net/rpm/1.0/un-extra-fonts.spec SRPM URL: http://get9.net/rpm/1.0/un-extra-fonts-1.0.1-3.fc9.src.rpm Description: This is a set of Korean TrueType fonts. Un-fonts come from the HLaTeX type1 fonts made by Koaunghi Un in 1998. They were converted to TrueType with FontForge(PfaEdit) by Won-kyu Park in 2003. Extra families (10 fonts) * UnPen, UnPenheulim: script * UnTaza: typewriter style * UnBom: decorative * UnShinmun * UnYetgul: old Korean printing style * UnJamoSora, UnJamoNovel, UnJamoDotum, UnJamoBatang Install un-core-fonts for additional fonts. and 1.0.2-pre packaging http://get9.net/rpm/1.0.2-080608/un-extra-fonts-1.0.2-0.3.080608.fc9.src.rpm http://get9.net/rpm/1.0.2-080608/un-extra-fonts.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 08:33 EST --- (In reply to comment #9) > Ok. Please ping me there when you have a new spec ready. revert to the 1.0 stable release -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 11:54 EST --- Created an attachment (id=311102) --> (https://bugzilla.redhat.com/attachment.cgi?id=311102&action=view) spec diff -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 12:03 EST --- So: 1. I've posted a diff you may want to consider, changing your spec a little so it's closer to our templates and easier to review 2. this diff is against the 1.0.2 pre-version spec. I'll let you judge of the version to package, you're better qualified than me and given the timespan between the stable and current version using stable may not necessarily be a good idea. 3. please update http://fedoraproject.org/wiki/UN_Extra_fonts as requested on http://fedoraproject.org/wiki/Font_package_lifecycle#2.a 4. As noted on http://fedoraproject.org/wiki/SIGs/Fonts since upstream chose a GPL license, please get it to clarify its position WRT GPLv3 and at least add the FSF font exception to their GPL text. If they don't answer in a week, proceed as usual (but no embedding exception sucks for korean users) 5. if possible have upstream release sfds and build from them 6. since this font set includes many fonts, it's probably a good idea to write a fontconfig ruleset so fontconfig puts them in the right families (sans-serif, serif, monospace; cursive, fantasy) http://fedoraproject.org/wiki/Fontconfig_packaging_tips -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|NEEDINFO Flag||needinfo?([EMAIL PROTECTED]) --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 12:06 EST --- 3. and 4. are a MUST (for 4. at least asking, since we won't block on no answer) 1. 5. 6. are a SHOULD, but you can pass on them if you don't agree with them Anyway this version is much closer to review acceptance, thank you for your work -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 [EMAIL PROTECTED] changed: What|Removed |Added Status|NEEDINFO|ASSIGNED Flag|needinfo?([EMAIL PROTECTED])| --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 13:07 EST --- 1. ok 3. http://fedoraproject.org/wiki/UN_Extra_fonts -updated wiki page -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 13:41 EST --- Please don't forget to change the wiki page status next time. Anyway, please do 4. and at least look at the others now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Additional Comments From [EMAIL PROTECTED] 2008-07-06 21:09 EST --- Stable release 1.0.1-4 Spec URL: http://get9.net/rpm/4/1.0/un-extra-fonts.spec SRPM URL: http://get9.net/rpm/4/1.0/un-extra-fonts-1.0.1-4.fc9.src.rpm Diff URL: http://get9.net/rpm/4/1.0/un-extra-fonts-1.0.1.spec-4.patch pre-release 1.0.2-0.4.080608 Spec URL: http://get9.net/rpm/4/1.0.2-080608/un-extra-fonts.spec SRPM URL: http://get9.net/rpm/4/1.0.2-080608/un-extra-fonts-1.0.2- 0.4.080608.fc9.src.rpm Diff URL: http://get9.net/rpm/4/1.0.2-080608/un-extra-fonts-1.0.2.spec-4.patch - Refined .spec literal -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Additional Comments From [EMAIL PROTECTED] 2008-07-07 00:48 EST --- Nicolas, thank you for taking this review, but isn't it better we finish un-fonts-core first, otherwise we are going to be duplicating a lot of review work across the two packages. Once the core review is settled the extra package review should be straightforward. I am not sure it is a good idea to rename the package from the upstream name. I feel more comfortable just keeping the upstream naming, and I think our packaging guidelines should allow and encourage that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453017] Review Request: un-fonts-extra - Korean TrueType fonts
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: un-fonts-extra - Korean TrueType fonts https://bugzilla.redhat.com/show_bug.cgi?id=453017 --- Additional Comments From [EMAIL PROTECTED] 2008-07-07 04:30 EST --- (In reply to comment #18) > I am not sure it is a good idea to rename the package from the upstream name. We have the case here of an upstream naming that's very close to our own conventions, so it's not so clear cut. But in other cases we don't hesitate to rename, so I don't see why not there. IMHO (and Debian has gone this way too lately) we'll need someday to review all our font package names to be more strict and consistent. Consistency pays big time with users and upstream namings are sadly not consistent at all. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
