[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2009-11-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109


Miroslav Suchý  changed:

   What|Removed |Added

  Alias||nocpulse-common




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-12-04 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109


Miroslav Suchy <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-11-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109


Dennis Gilmore <[EMAIL PROTECTED]> changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Comment #20 from Dennis Gilmore <[EMAIL PROTECTED]>  2008-11-03 13:38:44 
EDT ---
CVS Done

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-11-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109


Miroslav Suchy <[EMAIL PROTECTED]> changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Comment #19 from Miroslav Suchy <[EMAIL PROTECTED]>  2008-11-03 11:11:21 
EDT ---
New Package CVS Request
===
Package Name: nocpulse-common
Short Description: NOCpulse common
Owners: msuchy
Branches: devel F-9 F-10 EL-4 EL-5 
InitialCC:
Cvsextras Commits: yes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-11-03 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109





--- Comment #18 from Dennis Gilmore <[EMAIL PROTECTED]>  2008-11-03 10:51:18 
EDT ---
ping,  no cvs admin request yet.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-10-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109


Dennis Gilmore <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]  |[EMAIL PROTECTED]




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-10-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109


Dennis Gilmore <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
   Flag|fedora-review?  |fedora-review+




--- Comment #16 from Dennis Gilmore <[EMAIL PROTECTED]>  2008-10-24 11:02:39 
EDT ---
52289f16f8504f954369c6a3f065eec7892d6649  nocpulse-common-2.0.8.tar.gz
52289f16f8504f954369c6a3f065eec7892d6649 
/home/dgilmore/rpmbuild/SOURCES/nocpulse-common-2.0.8.tar.gz

sha1sum of source matches 
rpmlint gives
nocpulse-common.noarch: W: non-standard-uid /var/log/nocpulse nocpulse  
nocpulse-common.noarch: W: non-standard-gid /var/log/nocpulse nocpulse
nocpulse-common.noarch: W: non-standard-uid /var/lib/nocpulse nocpulse
nocpulse-common.noarch: W: non-standard-gid /var/lib/nocpulse nocpulse
nocpulse-common.noarch: W: obsolete-not-provided NPusers
nocpulse-common.noarch: W: obsolete-not-provided np-config


i disagree with not putting provides in  but ill accept it without.

builds in mock on rawhide.

# This src.rpm is cannonical upstream
# You can obtain it using this set of commands
# git clone git://git.fedorahosted.org/git/spacewalk.git/
# cd monitoring/nocpulse-common
# make srpm

needs to be removed from the spec.  but can be done at import time.

Approved

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-10-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109


Dennis Gilmore <[EMAIL PROTECTED]> changed:

   What|Removed |Added

   Flag||fedora-review+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-10-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109





--- Comment #17 from Dennis Gilmore <[EMAIL PROTECTED]>  2008-10-24 11:04:44 
EDT ---
of course that person who approved the package doesnt have the ability to
approve packages.

I do approve it.  with the same conditions

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-10-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109


Dennis Gilmore <[EMAIL PROTECTED]> changed:

   What|Removed |Added

   Flag|fedora-review+  |




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-10-24 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109





--- Comment #15 from Miroslav Suchy <[EMAIL PROTECTED]>  2008-10-24 10:40:57 
EDT ---
Updated SPEC:
http://miroslav.suchy.cz/fedora/nocpulse-common/nocpulse-common.spec
Updated SRPM:
http://miroslav.suchy.cz/fedora/nocpulse-common/nocpulse-common-2.0.8-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-10-17 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109





--- Comment #14 from Miroslav Suchy <[EMAIL PROTECTED]>  2008-10-17 03:59:32 
EDT ---
Hmm, I just wonder why package fedora-release (which is exactly same situation,
fedora is upstream for that package) do not have direct link for tar.gz file?
http://cvs.fedoraproject.org/viewvc/rpms/fedora-release/F-9/fedora-release.spec?revision=1.72&view=markup

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-10-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109





--- Comment #13 from Dennis Gilmore <[EMAIL PROTECTED]>  2008-10-17 02:32:00 
EDT ---
http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream  says "There
is no public revision control system or publically released tarball for these
programs so there is no tarball to list"  there is a public revision control
system, and im saying there should be public tarballs.  this is something that
could be useful and useable by more than spacewalk.  spacewalk could also end
up in other distros. a traball should be provided.

otherwise it looks good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-10-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109





--- Comment #12 from Miroslav Suchy <[EMAIL PROTECTED]>  2008-10-16 11:05:13 
EDT ---
Scriplets fixed in %pre, I left %post as is, becouse in previous version the
indentiry file have been on other place, so we want to check it during upgrade.

docdir removed

I disagree about that tarball. See:
http://fedoraproject.org/wiki/Packaging/SourceURL#We_are_Upstream
We are upstream. And our upstream is src.rpm, not tar.gz
Therefore I provide url to our project and in comment explained how to get this
src.rpm

Updated SPEC:
http://miroslav.suchy.cz/fedora/nocpulse-common/nocpulse-common.spec
Updated SRPM:
http://miroslav.suchy.cz/fedora/nocpulse-common/nocpulse-common-2.0.6-1.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-10-16 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109


Dennis Gilmore <[EMAIL PROTECTED]> changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Comment #11 from Dennis Gilmore <[EMAIL PROTECTED]>  2008-10-16 09:43:28 
EDT ---
have a look at
http://fedoraproject.org/wiki/Packaging/Guidelines#Running_scriptlets_only_in_certain_situations
 i think you should only run the %pre and %post scriptlets on install rather
than checking each time if things are there or not.

you should also remove %define doc_dir %{_docdir}/%{name}  and mkdir -p
$RPM_BUILD_ROOT%{doc_dir}
  from the spec file.  its not needed.

you can and should post a tarball on fedorahosted. please do so and use the
full url to the upstream source.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-10-14 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109





--- Comment #10 from Miroslav Suchy <[EMAIL PROTECTED]>  2008-10-14 08:55:41 
EDT ---
Any update?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-08-12 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109





--- Comment #9 from Miroslav Suchy <[EMAIL PROTECTED]>  2008-08-12 08:14:44 EDT 
---
Updated SPEC:
http://miroslav.suchy.cz/fedora/nocpulse-common/nocpulse-common.spec
Updated SRPM:
http://miroslav.suchy.cz/fedora/nocpulse-common/nocpulse-common-2.0.1-2.src.rpm
$ rpmlint /home/msuchy/rpmbuild/RPMS/noarch/nocpulse-common-2.0.1-2.noarch.rpm
nocpulse-common.noarch: W: non-standard-uid /var/log/nocpulse nocpulse
nocpulse-common.noarch: W: non-standard-gid /var/log/nocpulse nocpulse
^--- nocpulse need to write here
nocpulse-common.noarch: W: non-standard-uid /var/lib/nocpulse nocpulse
nocpulse-common.noarch: W: non-standard-gid /var/lib/nocpulse nocpulse
^--- home dir of nocpulse user
nocpulse-common.noarch: W: obsolete-not-provided NPusers
nocpulse-common.noarch: W: obsolete-not-provided np-config
^--- previous versions is not compatible with this version. see irc log for
reasoning.
1 packages and 0 specfiles checked; 0 errors, 6 warnings.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 453109] Review Request: nocpulse-common - Add NOCpulse users and includes common files for NOCpulse.

2008-08-08 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453109


Miroslav Suchy <[EMAIL PROTECTED]> changed:

   What|Removed |Added

Customer Facing||---
Summary|Review Request: |Review Request:
   |nocpulse-users - Adds   |nocpulse-common - Add
   |NOCpulse user   |NOCpulse users and includes
   ||common files for NOCpulse.




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review