[Bug 453287] Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library https://bugzilla.redhat.com/show_bug.cgi?id=453287 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-04 16:32 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453287] Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library https://bugzilla.redhat.com/show_bug.cgi?id=453287 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-07-04 17:21 EST --- Thanks Kevin Marek. Imported and built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453287] Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library https://bugzilla.redhat.com/show_bug.cgi?id=453287 --- Additional Comments From [EMAIL PROTECTED] 2008-07-02 10:19 EST --- http://netbsd.sk/~lkundrak/SPECS/perl-Term-ReadLine-Gnu.spec http://netbsd.sk/~lkundrak/SRPMS/perl-Term-ReadLine-Gnu-1.17a-4.el5.src.rpm I disabled visual bell test. While I plan to fix it, I don't think it should block the review, as disabling non-critical tests is done for some packages already in Fedora. Note that with perl 5.10.0 older than 5.10.0-30 you'll probably trigger a perl bug during building it. The fixed version of perl is already submitted as an update. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453287] Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library https://bugzilla.redhat.com/show_bug.cgi?id=453287 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-02 13:37 EST --- OK, at this point I'm going to say I'm happy. The failing tests are not due to bugs in this package and indeed things work OK with a different version of Perl. I suppose I could pull the -33.fc10 package out of koji and drop it into my mock config and do a build but I don't really see the point. Please go ahead and get this checked in, and thanks for tracking down the underlying problem. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453287] Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library https://bugzilla.redhat.com/show_bug.cgi?id=453287 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-07-02 20:07 EST --- Thanks for the patience, and the review, Jason. New Package CVS Request === Package Name: perl-Term-ReadLine-Gnu Short Description: Perl extension for the GNU Readline/History Library Owners: lkundrak Branches: F-8 F-9 EL-5 Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453287] Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library https://bugzilla.redhat.com/show_bug.cgi?id=453287 --- Additional Comments From [EMAIL PROTECTED] 2008-07-01 12:53 EST --- So here's my poor attempt for a _temporary_ workaround for the problem. Please note it totally sucks [1], but should not make any harm (unless someone runs valgrind on perl). For more background see perl RT ticket [2], as it's a bug in perl. [1] http://fedorapeople.org/~lkundrak/perl-Term-ReadLine-Gnu-1.17-malloc.patch [2] http://rt.perl.org/rt3/Ticket/Display.html?id=56500 http://netbsd.sk/~lkundrak/SPECS/perl-Term-ReadLine-Gnu.spec http://netbsd.sk/~lkundrak/SRPMS/perl-Term-ReadLine-Gnu-1.17a-3.el5.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453287] Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library https://bugzilla.redhat.com/show_bug.cgi?id=453287 --- Additional Comments From [EMAIL PROTECTED] 2008-07-01 13:30 EST --- Soo there's probably a better solution to this problem: bug #453646 Hopefully the maintainers (I've mailed them) won't mind if that gets fixed with https://admin.fedoraproject.org/updates/F9/FEDORA-2008-5875 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453287] Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library https://bugzilla.redhat.com/show_bug.cgi?id=453287 --- Additional Comments From [EMAIL PROTECTED] 2008-06-29 04:04 EST --- (In reply to comment #2) This is a tough one. Until the bug is fixed, I don't know if we want to have this package in the distro because it may just cause bug reports for any software which might use it. Fair enough; Thanks for the review. Since I mostly care about having this in EPEL (where the bug either doesn't exist, or is mitigated somehow), I'm wondering if I'll get an approval if I promised not to build this in Fedora branches until this gets fixed? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453287] Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library https://bugzilla.redhat.com/show_bug.cgi?id=453287 --- Additional Comments From [EMAIL PROTECTED] 2008-06-28 18:33 EST --- Note that this currently won't build on rawhide (and probably also Fedora 9), unless you comment out the tests. Actually, the test themselves run fine, but cause the interpreter to crash when it terminates. This is not particularly limiting, but an annoyance and has an implication of changing the return value of perl to indeicate failure (which causes the test suite to fail). I'd appreciate if anyone helped me to debug the problem, since Perl internals are not anything I would be especially familiar with. I've been given an advice of recompiling perl with -DDEBUGGING flag, but given my limited computing powers this is not going to happen soon. I have at least reported the issue upstream: #37194: Term::ReadLine::Gnu causes panic during global destruction on perl 5.10 http://rt.cpan.org/Public/Bug/Display.html?id=37194 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453287] Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Term-ReadLine-Gnu - Perl extension for the GNU Readline/History Library https://bugzilla.redhat.com/show_bug.cgi?id=453287 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-06-28 22:07 EST --- This is a tough one. Until the bug is fixed, I don't know if we want to have this package in the distro because it may just cause bug reports for any software which might use it. Below I'll just ignore the test suite, and I wouldn't have any problems with approving it instantly were the test suite to start working, but in the current state I just don't know what to do. Perhaps talk to the fedora-perl-devel list and see if anyone there has an opinion. * source files match upstream: 41206971d87c63cecb6c5892d9cd4c96b53aacd31279db7bf5571662352f9bac Term-ReadLine-Gnu-1.17a.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * compiler flags are appropriate. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * debuginfo package looks complete. * rpmlint is silent. * final provides and requires are sane: Gnu.so()(64bit) perl(Term::ReadLine::Gnu) = 1.17 perl(Term::ReadLine::Gnu::AU) perl(Term::ReadLine::Gnu::Var) perl(Term::ReadLine::Gnu::XS) perl-Term-ReadLine-Gnu = 1.17a-2.fc10 = libreadline.so.5()(64bit) libtinfo.so.5()(64bit) perl(:MODULE_COMPAT_5.10.0) perl(AutoLoader) perl(Carp) perl(DynaLoader) perl(Exporter) perl(Term::ReadLine::Gnu::XS) perl(strict) perl(vars) * no shared libraries are added to the regular linker search paths. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
