[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 zhihe...@hotmail.com changed: What|Removed |Added CC||zhihe...@hotmail.com --- Comment #97 from zhihe...@hotmail.com 2010-01-05 18:30:57 EDT --- all gstreamer libs under lib/ are fault, you need delete all of them to make songbird 1.4.3 to start up, not sure what functions you lost, most likely it will find system gstreamer libs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #95 from Andreas Petzold andreas.petz...@gmail.com 2009-12-24 13:07:19 EDT --- David, I'm aware of your great effort over the last 1.5 years. Keep on and good luck! I was just wondering why the upstream binary tarball seems to work for some and not for others on f12. Anyway, I'll wait for your rpm to make things work. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #96 from Scott Williams vwfoxg...@gmail.com 2009-12-25 01:29:41 EDT --- my best guess as to why it would work for one and not the other from tarball is a dependency issue. Thus an RPM will be nice to have. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 Andreas Petzold andreas.petz...@gmail.com changed: What|Removed |Added CC||andreas.petz...@gmail.com --- Comment #93 from Andreas Petzold andreas.petz...@gmail.com 2009-12-23 05:54:42 EDT --- Reply to comment 92: I've downloaded the binary tarball Songbird_1.4.2-1434_linux-i686.tar.gz yesterday, but it's not working for me on F12: (songbird-bin:21336): GLib-WARNING **: g_set_prgname() called multiple times (songbird-bin:21343): GStreamer-WARNING **: Failed to load plugin '/home/petzold/download/Songbird/gst-plugins/libgstpulse.so': /usr/lib/libsndfile.so.1: undefined symbol: vorbis_version_string (songbird-bin:21343): GStreamer-WARNING **: Failed to load plugin '/usr/lib/gstreamer-0.10/libgstjpeg.so': /usr/lib/gstreamer-0.10/libgstjpeg.so: undefined symbol: _gst_debug_get_category (songbird-bin:21343): GStreamer-WARNING **: Failed to load plugin '/usr/lib/gstreamer-0.10/libgstvideo4linux2.so': /usr/lib/gstreamer-0.10/libgstvideo4linux2.so: undefined symbol: _gst_debug_get_category (songbird-bin:21343): GStreamer-WARNING **: Failed to load plugin '/usr/lib/gstreamer-0.10/libgstapp.so': /usr/lib/libgstapp-0.10.so.0: undefined symbol: gst_buffer_list_get_type (songbird-bin:21343): GStreamer-WARNING **: Failed to load plugin '/usr/lib/gstreamer-0.10/libgstdeinterlace.so': /usr/lib/gstreamer-0.10/libgstdeinterlace.so: undefined symbol: gst_video_format_parse_caps_interlaced (songbird-bin:21343): GStreamer-WARNING **: Failed to load plugin '/usr/lib/gstreamer-0.10/libgstmatroska.so': /usr/lib/gstreamer-0.10/libgstmatroska.so: undefined symbol: gst_util_array_binary_search (songbird-bin:21343): GStreamer-WARNING **: Failed to load plugin '/usr/lib/gstreamer-0.10/libgstpulse.so': /usr/lib/gstreamer-0.10/libgstpulse.so: undefined symbol: gst_message_new_request_state (songbird-bin:21343): GStreamer-WARNING **: Failed to load plugin '/usr/lib/gstreamer-0.10/libgstdv.so': /usr/lib/gstreamer-0.10/libgstdv.so: undefined symbol: gst_tag_list_new_full ././songbird-bin: symbol lookup error: /usr/lib/python2.6/site-packages/gst-0.10/gst/_gst.so: undefined symbol: gst_task_pool_get_type Could not initialize GStreamer: Error re-scanning registry , child terminated by signal Googling these error messages, I've found the advise to set LD_BIND_NOW=1 when running songbird. This seems to help a bit, but songbird is still crashing randomly. Scott, what did you do to make it work for you? :-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #94 from David Halik auralva...@gmail.com 2009-12-23 12:36:41 EDT --- 1.4.3 is on it's way to being released, so I'm going to wait for that. @Scott the svn checkout isn't the same as their officially released source ball (different paths, structure, etc), so I wait for that. Otherwise I have to change the build process to cope and it's a bunch of extra work for nothing. Songbird dev stevel will notify me when the ball is out, so I'll get on it soon after. @Andreas You should probably post your issues on the songbird help list, because what I do here with the respin is very different than what they provide. I use almost all system components from Fedora, except for xulrunner and tagib, they package everything to their own patched copies. It's very likely that gstreamer bugs will not be the same because of the different versions involved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #89 from Sebastian Krämer m...@kraymer.de 2009-12-22 13:55:21 EDT --- 1.4 release? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #90 from David Halik auralva...@gmail.com 2009-12-22 13:59:48 EDT --- The source ball hasn't been released yet. When it is I'll start working on it, but it's going to take time some I'm sure since it's been so long since the last stable release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #91 from Scott Williams vwfoxg...@gmail.com 2009-12-22 16:56:44 EDT --- Looks like 1.4 source is available: http://publicsvn.songbirdnest.com/client/branches/Songbird1.4/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #92 from Scott Williams vwfoxg...@gmail.com 2009-12-22 17:18:27 EDT --- For what it's worth, songbird 1.4 appears to work in f12 by extracting the tarball'd binary and running it, if that's any hope for your packaging of it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 Dean Mander knolderp...@gmail.com changed: What|Removed |Added CC||knolderp...@gmail.com --- Comment #88 from Dean Mander knolderp...@gmail.com 2009-11-24 07:57:26 EDT --- Hi guys, since the last build of F11 wasn't working on my F12 (i686) I've rebuilt the source rpm: http://people.fedoraproject.org/~knol/rpms/songbird/songbird-1.2.0-1.fc12.i686.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 Joel j...@cryregarder.com changed: What|Removed |Added CC||j...@cryregarder.com --- Comment #87 from Joel j...@cryregarder.com 2009-11-16 11:03:01 EDT --- Any progress on songbird? I tried building the latest src.rpm on fc11 but it doesn't go through (can post if not common knowledge). I'm really looking forward to this package in fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=453422
--- Comment #84 from Scott Williams vwfoxg...@gmail.com 2009-10-01 12:51:01
EDT ---
With the RPM you've provided for 1.2.0-1, any playback causes a segfault:
(songbird-bin:20179): GStreamer-WARNING **: Failed to load plugin
'/home/scott/.gstreamer-0.10/plugins/libgstflump3dec.so':
/home/scott/.gstreamer-0.10/plugins/libgstflump3dec.so: wrong ELF class:
ELFCLASS32
/usr/lib64/songbird-1.2.0/songbird: line 134: 20175 Segmentation fault
$prog ${1+$@}
The seg fault does not just happen with mp3 format.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #85 from David Halik auralva...@gmail.com 2009-10-01 12:59:42 EDT --- That looks like an issue with whatever gst plugins you're using. It's basically saying that you're running a 64bit songbird against a 32bit libgstflump3dec.so. Make sure that all your gstreamer packages are 64bit and the latest release if you're on a x86_64 install and try it again. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #86 from Scott Williams vwfoxg...@gmail.com 2009-10-01 13:30:53 EDT --- I regressed to 1.1.2 with the same plugin set and it's working. Looks related to the upstream bug: http://www.getsatisfaction.com/songbird/topics/songbird_segfault_on_fedora_10 I am running fedora 11 x86_64. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #83 from David Halik auralva...@gmail.com 2009-09-18 10:59:05 EDT --- The only place ORIGIN is used is within the xulrunner package itself and only when SunOS is detected. As I stated before, I'm not sure how to fix this if it's not supposed to be used in the first place. I've tried many methods, but none have helped. I can remove the appropriate sections, but considering it's for solaris, I doubt it will make a difference. Someone with more expertise than me would probably be better at fixing the ORIGIN issue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #82 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-09-17 18:29:42 EDT --- Any NEWS from the SongBird Legals (and improvement on the rpath issue for the packaging side)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #80 from Matej Cepl mc...@redhat.com 2009-07-18 05:43:14 EDT --- (In reply to comment #79) One thing I would like to recommend, in the interest of keeping Fedora F/OSS, while providing functionality to those who want it. Could we package songbird without the proprietary plugins, but package those in a separate package and submit that to RPMFusion-nonfree? Read comment 68, codecs themselves (proprietary or free) should not be part of this package. It just uses GStreamer as rhythmbox or totem do. Just apparently upstream wanted to deliver some codecs later and wanted to have approved agreement for its users (read comment 67 for longer tract on the legalese). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #81 from Matej Cepl mc...@redhat.com 2009-07-18 05:51:38 EDT --- (In reply to comment #76) Building in mock for F-11... http://koji.fedoraproject.org/koji/taskinfo?taskID=1458403 Unfortuantely, it seems that RPMs got already garbage collected. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 Scott Williams vwfoxg...@gmail.com changed: What|Removed |Added CC||vwfoxg...@gmail.com --- Comment #79 from Scott Williams vwfoxg...@gmail.com 2009-07-17 19:55:55 EDT --- One thing I would like to recommend, in the interest of keeping Fedora F/OSS, while providing functionality to those who want it. Could we package songbird without the proprietary plugins, but package those in a separate package and submit that to RPMFusion-nonfree? For what it's worth, I've been using Sonbgbird through several songbird releases on Fedora and I have very little to complain about. Generally works and works well here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #77 from Jakub Hrozek jhro...@redhat.com 2009-07-14 04:15:49 EDT --- FWIW, while the package Nicolas built installs fine, it segfaults immediately after you start playing just about any song (this is on x86_64 F11). I experienced the very same behaviour with upstream 1.2.0, so I don't suspect any packaging issue. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #78 from David Halik auralva...@gmail.com 2009-07-14 07:35:31 EDT --- I've been testing the last couple of release on x86_64 F11 and have not seen this problem. If you're also having the segfault from the upstream binaries, it sounds like an issue with the gstreamer installation. If the plugin compliment isn't correct the program does get cranky, although it shouldn't crash, so I suggest opening a bug upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #76 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-07-07 04:30:52 EDT --- (In reply to comment #73) Can anyone give me some pointers on how to scrub the extra $ORIGIN that keeps getting added on? grep \$ORIGIN * -R This will help to find potential place where $ORIGIN rpath will be set. Alfred who runs the Solaris rpm for Songbird essentially disables the rpath, then sets his own afterwards in order to clean anything being added automatically: LDFLAGS=-norunpath -z ignore -R'\$\$ORIGIN:\$\$ORIGIN/..' Overriding environnement value do not always work and may provide undesired effects. You need to patch the Makefile.am or configure.in to have the rpath usage conditionalized as needed. Building in mock for F-11... http://koji.fedoraproject.org/koji/taskinfo?taskID=1458403 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #75 from David Halik auralva...@gmail.com 2009-06-23 16:42:03 EDT --- Thanks for the link, but most of what is in there I was already aware of. It looks like some makefile and cmake hacking will be needed to remove the extra ORIGIN path. I've tried multiple different tricks and I haven't been able to remove it. Unless someone else has a better idea of how to clean the path, I'm leaving this as is for now. Update 1.2.0 links: http://rpm.rutgers.edu/fedora/songbird-1.2.0-1.fc11.src.rpm http://rpm.rutgers.edu/fedora/songbird.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #73 from David Halik auralva...@gmail.com 2009-06-22 12:45:54 EDT --- Can anyone give me some pointers on how to scrub the extra $ORIGIN that keeps getting added on? I spent a bunch of time this weekend trying to remove it from the rpath, but it is continually tacked on at some point. Alfred who runs the Solaris rpm for Songbird essentially disables the rpath, then sets his own afterwards in order to clean anything being added automatically: LDFLAGS=-norunpath -z ignore -R'\$\$ORIGIN:\$\$ORIGIN/..' Is there a way to accomplish this with gcc? -norunpath and -z ignore are Solaris-isms I believe. Any help would be appreciated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #74 from Matej Cepl mc...@redhat.com 2009-06-22 17:28:51 EDT --- http://fedoraproject.org/wiki/Extras/Schedule/RpathCheckBuildsys -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #72 from David Halik auralva...@gmail.com 2009-06-15 12:23:28 EDT --- 1.2 is due out shortly. I'll remove the $ORIGIN rpath in the next build and repost. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #70 from Matej Cepl mc...@redhat.com 2009-06-14 06:42:20 EDT --- Tried to rebuild http://rpm.rutgers.edu/fedora/songbird-1.1.2-2.fc11.src.rpm on Fedora 11 and this is what I get. IMHO, it HAS to go before the review ends: + /usr/lib/rpm/check-rpaths /usr/lib/rpm/check-buildroot *** * * WARNING: 'check-rpaths' detected a broken RPATH and will cause 'rpmbuild' * to fail. To ignore these errors, you can set the '$QA_RPATHS' * environment variable which is a bitmask allowing the values * below. The current value of QA_RPATHS is 0x. * *0x0001 ... standard RPATHs (e.g. /usr/lib); such RPATHs are a minor * issue but are introducing redundant searchpaths without * providing a benefit. They can also cause errors in multilib * environments. *0x0002 ... invalid RPATHs; these are RPATHs which are neither absolute * nor relative filenames and can therefore be a SECURITY risk *0x0004 ... insecure RPATHs; these are relative RPATHs which are a * SECURITY risk *0x0008 ... the special '$ORIGIN' RPATHs are appearing after other * RPATHs; this is just a minor issue but usually unwanted *0x0010 ... the RPATH is empty; there is no reason for such RPATHs * and they cause unneeded work while loading libraries *0x0020 ... an RPATH references '..' of an absolute path; this will break * the functionality when the path before '..' is a symlink * * * Examples: * - to ignore standard and empty RPATHs, execute 'rpmbuild' like * $ QA_RPATHS=$[ 0x0001|0x0010 ] rpmbuild my-package.src.rpm * - to check existing files, set $RPM_BUILD_ROOT and execute check-rpaths like * $ RPM_BUILD_ROOT=top-dir /usr/lib/rpm/check-rpaths * *** ERROR 0008: file '/usr/lib64/songbird-1.1.2/components/sbMetadataHandlerTaglib.so' contains the $ORIGIN rpath specifier at the wrong position in [/usr/lib64/songbird-1.1.2:$ORIGIN/../xulrunner] ERROR 0008: file '/usr/lib64/songbird-1.1.2/xulrunner/mangle' contains the $ORIGIN rpath specifier at the wrong position in [/usr/lib64/songbird-1.1.2:$ORIGIN/../lib64:$ORIGIN/../lib] ERROR 0008: file '/usr/lib64/songbird-1.1.2/xulrunner/mangle' contains the $ORIGIN rpath specifier at the wrong position in [/usr/lib64/songbird-1.1.2:$ORIGIN/../lib64:$ORIGIN/../lib] ERROR 0008: file '/usr/lib64/songbird-1.1.2/xulrunner/shlibsign' contains the $ORIGIN rpath specifier at the wrong position in [/usr/lib64/songbird-1.1.2:$ORIGIN/../lib64:$ORIGIN/../lib] ERROR 0008: file '/usr/lib64/songbird-1.1.2/xulrunner/shlibsign' contains the $ORIGIN rpath specifier at the wrong position in [/usr/lib64/songbird-1.1.2:$ORIGIN/../lib64:$ORIGIN/../lib] chyba: Špatný návratový kód z /var/tmp/rpm-tmp.b5Kpm5 (%install) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #71 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-06-14 11:40:36 EDT --- (In reply to comment #70) Tried to rebuild http://rpm.rutgers.edu/fedora/songbird-1.1.2-2.fc11.src.rpm on Fedora 11 and this is what I get. IMHO, it HAS to go before the review ends: I've made a similar comment as https://bugzilla.redhat.com/show_bug.cgi?id=453422#c59 and #c63 Whereas using rpath is appropriate for the current package (as an application that bundle it own xulrunner - thunderbird does the same for exemple), the $ORIGIN rpath seems only needed for Solaris. Hence, there is a need to clean the $ORIGIN rpath. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #69 from Stephen Lau ste...@songbirdnest.com 2009-06-10 15:07:20 EDT --- (In reply to comment #67) ... Hey Tom, Thanks very much for the detailed reply and points... I'm bringing them up with our lawyers and execs to see what we can and can't address. I expect this will take a while (as anything involving management and/or legal seems to do), but just wanted to let you know I'm looking into it and not ignoring it. cheers, steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #68 from Stephen Lau ste...@songbirdnest.com 2009-06-10 15:05:13 EDT --- (In reply to comment #66) (In reply to comment #65) stuff just for Linux since it's entirely possible we could deliver binary-only components again in the future for Linux users. I don't want to get much involved with this review, but why not just let gstreamer deal with the codecs mess? And if you want to provide some binary-only codecs, why not to make repository of them and let PackageKit use it as (optional of course) additional source of codecs? But, that's just off-topic to the issue of EULA. Sorry for the confusion, but I was talking about proprietary/binary-only add-ons (in the sense of Songbird add-ons which are like Firefox add-ons... packaged in .xpis, that augment the app by giving it new skins, or new functionality). The codecs themselves are all managed by GStreamer as you'd expect. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #66 from Matej Cepl mc...@redhat.com 2009-06-05 05:35:51 EDT --- (In reply to comment #65) stuff just for Linux since it's entirely possible we could deliver binary-only components again in the future for Linux users. I don't want to get much involved with this review, but why not just let gstreamer deal with the codecs mess? And if you want to provide some binary-only codecs, why not to make repository of them and let PackageKit use it as (optional of course) additional source of codecs? But, that's just off-topic to the issue of EULA. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 Tom spot Callaway tcall...@redhat.com changed: What|Removed |Added CC||tcall...@redhat.com Blocks||182235(FE-Legal) --- Comment #67 from Tom spot Callaway tcall...@redhat.com 2009-06-05 10:33:13 EDT --- Well, I've got a few concerns here: * The License for Songbird appears to be GPLv2, which says: 5. You are not required to accept this License, since you have not signed it. The EULA would seem to add this additional requirement that you accept the GPL terms. POTI IS WILLING TO LICENSE THE SONGBIRD MEDIA PLAYER AND SONGBIRD ADD-ONS TO YOU ONLY UPON THE CONDITION THAT YOU ACCEPT ALL THE TERMS CONTAINED IN THIS AGREEMENT. * The EULA covers Songbird Add-Ons without specifying what those are. In addition, you mention that there are Free/Open Source add-ons coming, but this EULA clearly states that all add-ons may not be copied or modified, and imposing commercial use restrictions. All of these EULA overlay restrictions render otherwise Free/Open Source addons non-free. * The EULA requires that the end-user agree to the Fluendo EULA terms, which are most certainly non-free. These three items are showstoppers. While this isn't as bad as what Mozilla originally tried to do with Firefox, the problem is the same. I would suggest that we take a big step back from things and look at specifically what problems that you (Songbird's copyright holder(s)) seem to be trying to solve with this EULA. 1. The source code for the base songbird product is under the GPLv2. No agreement is necessary for anyone to use, copy, modify, distribute, or sell the songbird code. 2. The base songbird product does not come with any addons. Thus, there should not be a need to specify terms for these addons. If a user installs an addon through songbird directly, they should be prompted to agree to downloaded terms before downloading the addon, not at the initial use of songbird. (If addons are manually installed by the user outside of songbird, it is the responsibility of the addon provider to ensure that the terms of that specific addon are either presented to the user before download or before installation). 3. Proprietary Rights: The GPL is effective in providing this coverage, nothing in the GPL takes away the rights that are preserved by copyright law. There is no need for the user to agree to this explicitly. 4. Disclaimer of Warranty: The GPL is effective in providing this coverage, it has a thorough disclaimer of warranty. There is no need for the user to agree to this explicitly. 5. Third-Party Add-Ons: This covers the fact that third-party addons available at the songbird website may have different terms and disclaims warranty. If deemed absolutely necessary, this is something that could be presented in a non-obtrusive way, similar to how firefox handles its third party services, where the user is made aware of these facts, but is not required to agree to them. Realistically, this should be on the songbird website, not embedded in the client. 6. Term and Termination: This legal boilerplate in the EULA arguably conflicts with the GPL, thus, according to the beginning of the EULA (To the extent that any of the terms and conditions of this Agreement conflict with the GPLv2 and POTI's exception, the conflicting terms and conditions of this Agreement shall not apply to the Songbird Media Player.), they don't apply anyway, and serve no purpose. 7. Representations and Warranties. This states that songbird users must comply with the law when using addons (but not the base songbird player?), and that they cannot use the code to infringe other's copyrights. This technically constitutes a use restriction, and conflicts with the GPLv2. In addition, you do not need to force people to agree to follow applicable laws, they're required to do that anyways, no prior agreement necessary. Thus, this entire section is not required. 8. No Obligation: Already covered adequately in GPLv2, not necessary. 9. Government Users. These appear to impose additional rights restrictions upon US goverment use, which may conflict with the GPLv2 and thus be irrelevant. If there are additional US government policies covering the use of specific types of software (I'm assuming this is primarily for cryptographic related matters), you could certainly inform the goverment user in an unobtrusive way that these policies may apply, but this is not something that mandates acceptance. (Alternately, the Mozilla Public License 1.1 (Section 10) has this as part of its license, thus, it may be a better fit for Songbird: http://www.mozilla.org/MPL/MPL-1.1.html ) 10. Export Laws. Requiring
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #65 from Stephen Lau ste...@songbirdnest.com 2009-06-04 19:58:25 EDT --- (In reply to comment #64) In my opinion, there is a problem both with the license advertising and the installation of recommended plugins. That's rather annoying for a newly created users to have all sort of advertising, specially if the user known well the sunbird license and/or other well known modules. I think that previously, the same kind of problem was raised with firefox which ends to have a less interactive with end-user advertise. (I remember some discussion on GPL not been an EULA that end-user need to accept/reject to use the software but a pure information). (full disclosure: I'm a POTI employee working on Songbird - I think I said that up above too, but worth refreshing here so it's clear) The EULA is displayed to the user here since it's possible they might be downloading some closed-source/binary-only add-ons. The EULA also notes that while the player is open source and free, the branding (Songbird icon, name, etc.) are trademarks of POTI, Inc. While this second part is similar to Firefox/Mozilla and arguably could be moved to a hat-like notification system like Mozilla has done with Firefox, it was still worth having the EULA agreement for the user to protect them and give them the rights to use the binary-only add-ons for free (since Songbird can and does license them to partners who build their own players on top of the Songbird source) The binary only add-ons in question are Quicktime, Windows Media, and iPod. The Quicktime Windows Media add-ons are platform-specific to Windows Mac - so they won't be exposed to RH/Fedora users, and the iPod add-on is soon to be open sourced... so this might be a non-issue in a matter of weeks once I'm done open sourcing the iPod add-on. So all that aside, POTI would feel more comfortable having the EULA window and agreement there... it's a requirement for us on Windows/Mac due to the proprietary binary only components, and we'd rather not get into special casing stuff just for Linux since it's entirely possible we could deliver binary-only components again in the future for Linux users. (And, as always, these add-ons will always be optional... the user is free to opt-out of not installing any of them) So to sum-up, I would appreciate to have less interactive information on newly created user (so songbird could be usable directly). But this shouldn't prevent this package to be approved. cheers.. and thanks for the review! -steve -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #63 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-05-07 08:57:30 EDT --- About $ORIGIN, quoting songbird run script: - ## On Solaris we use $ORIGIN (set in RUNPATH) instead of LD_LIBRARY_PATH ## to locate shared libraries. So the ORIGIN rpath seems only used on Solaris System Sorry for the late answear... I miss time. TODO List: review the xulrunner options. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #64 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-05-07 12:22:34 EDT --- songbird once first install wants to install fonts. On my system (F-11 installed from a customized livecd) Not all fonts are installed while running the first time license file. This make songbird to request bengali and other asian fonts (via packagekit) which aren't available while watching the license. Once the installation of the fonts is refused with PackageKit, gpk-update-icon crash with this possible indication: (songbird-bin:2333): PkGtkModule-DEBUG: InstallFontconfRessources method invoked. In my opinion, there is a problem both with the license advertising and the installation of recommended plugins. That's rather annoying for a newly created users to have all sort of advertising, specially if the user known well the sunbird license and/or other well known modules. I think that previously, the same kind of problem was raised with firefox which ends to have a less interactive with end-user advertise. (I remember some discussion on GPL not been an EULA that end-user need to accept/reject to use the software but a pure information). The problem about recommended modules is that: in a ideal packagekit world, they should be provided in an safer way (trusted gpg signed package, such as rpm or whatever, from trusted repositories). But since our firefox package doesn't prevent installation of such extension as end-users level, i think it should be perfectly fine. So to sum-up, I would appreciate to have less interactive information on newly created user (so songbird could be usable directly). But this shouldn't prevent this package to be approved. @David Halik, Usually, in order for you to be sponsored, you need to provide a second review, this review was rather big, so this could be optional but remains at the discretion of the sponsort. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #62 from David Halik auralva...@gmail.com 2009-05-04 09:50:57 EDT --- Any recent thoughts kwizart? Haven't heard any updates from you since the rpmlint issues were fixed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #61 from David Halik auralva...@gmail.com 2009-04-18 12:04:13 EDT --- Ok, I reworked the files section and all of the rpmlint perm errors are fixed, this includes the debuginfo package. Below is the new rpmlint output: # rpmlint songbird-1.1.2-2.fc11.x86_64.rpm songbird.x86_64: W: hidden-file-or-dir /usr/lib64/songbird-1.1.2/.autoreg songbird.x86_64: E: zero-length /usr/lib64/songbird-1.1.2/.autoreg songbird.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/songbird-1.1.2/xulrunner/mangle ['/usr/lib64/songbird-1.1.2', '$ORIGIN/../lib64', '$ORIGIN/../lib'] songbird.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/songbird-1.1.2/xulrunner/shlibsign ['/usr/lib64/songbird-1.1.2', '$ORIGIN/../lib64', '$ORIGIN/../lib'] songbird.x86_64: W: no-soname /usr/lib64/songbird-1.1.2/lib/sbGStreamerMediacore.so songbird.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/songbird-1.1.2/components/sbMetadataHandlerTaglib.so ['/usr/lib64/songbird-1.1.2', '$ORIGIN/../xulrunner'] 1 packages and 0 specfiles checked; 4 errors, 2 warnings. Everything above is accounted for. The .autoreg warning and error are expected. The zero byte file needs to be there for XPCOM registration to happen on first run (I checked with the devs). kwizart, I'm not sure which other RPATH errors you were seeing, but the above three (mangle, shlibsign, sbMetadataHandlerTaglib.so) are the only ones I have seen and all are correct. These three should be pointing back to the internal lib area rather than outside. # rpmlint songbird-debuginfo-1.1.2-2.fc11.x86_64.rpm /usr/share/rpmlint/Pkg.py:16: DeprecationWarning: The popen2 module is deprecated. Use the subprocess module. import popen2 1 packages and 0 specfiles checked; 0 errors, 0 warnings. debuginfo perms are now correct. I posted the update spec and src.rpm: http://rpm.rutgers.edu/fedora/songbird.spec http://rpm.rutgers.edu/fedora/songbird-1.1.2-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #56 from Jasper Capel fedora-jas...@newnewyork.nl 2009-04-17 09:46:29 EDT --- I've tried building the source rpm in mock on my machine. How long is this build supposed to take? I've aborted it after 5 hours, and ended up with a cp process I can't kill which is eating my cpu cycles: jasper9423 90.6 0.0 12364 204 pts/2R10:44 272:01 cp -RLfp bin idl include lib /builddir/build/BUILD/Songbird1.1.2/dependencies/linux-x86_64/mozilla/release/frozen That cp has been running for at least a couple of hours, could it be in a symlink dereferencing loop? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #57 from David Halik auralva...@gmail.com 2009-04-17 10:29:08 EDT --- The build should only take 20-30 minutes. Have you tried multiple builds, or was that the only one? This is the first that I have heard of such an issue despite many many builds, both locally and and on Koji. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #58 from Jasper Capel fedora-jas...@newnewyork.nl 2009-04-17 10:58:52 EDT --- This was the only build, on a rawhide machine and rawhide buildroot. I will try again later then, with a clean buildroot, after I get a chance to reboot my machine. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #59 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-04-17 11:18:17 EDT --- rpmlint on rpm package (not installed) built for local mock for F-11 x86_64. 2 packages and 0 specfiles checked; 377 errors, 5 warnings. There is 3 common cases for the errors: 1/ songbird.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/songbird-1.1.2/xulrunner/mangle ['/usr/lib64/songbird-1.1.2', '$ORIGIN/../lib64', '$ORIGIN/../lib'] Whereas the /usr/lib64/songbird-1.1.2 rpath was expected to use the internal xulrunner, the others are what the rpath policy expect to have removed. There is a need to track why thoses additionals rpathes are added. 2/ songbird.x86_64: E: script-without-shebang /usr/lib64/songbird-1.1.2/xulrunner/dictionaries/en-US.aff Thoses files need to be chmod -x 3/songbird-debuginfo.x86_64: E: non-readable /usr/src/debug/Songbird1.1.2/dependencies/vendor/xulrunner/mozilla/xpcom/glue/pldhash.c 0640 The source code (ending in -debuginfo sub-package) need to be publicly accessible (0644) 4/songbird.x86_64: W: no-soname /usr/lib64/songbird-1.1.2/lib/sbGStreamerMediacore.so This one is a warning only... As I understand, it is meant to be dlopened and isn't registered as a system library; also, it doesn't have a SOVERSION. So this is acceptable for me. I still need to have rpmlint on installed files and runtime testing on F-11 x86_64 @Jasper I never experienced such problem in my case, either rpmbuild, mock or koji built. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #60 from Jasper Capel fedora-jas...@newnewyork.nl 2009-04-17 13:15:15 EDT --- My apologies, it builds just fine. :) It's a mystery to me what caused this. Anyway, I'll be testing songbird on my F11 x86_64 workstation. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #53 from David Halik auralva...@gmail.com 2009-04-14 14:55:19 EDT --- 1.1.2 source tar balls haven't been released yet, but as soon as they are I'll post updates. As a side note, I just wanted to say thanks to Toni of SUSE who has been giving me rpm feedback in his efforts to port the src.rpm. They now have a nicely working rpm as well. kwizart, anything else in particular that needs to be done for sponsorship that I can help with? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #54 from Stephen Lau ste...@songbirdnest.com 2009-04-14 17:55:10 EDT --- 1.1.2 source tarballs are up now: http://wiki.songbirdnest.com/Developer/Articles/Builds/Contributed_Builds -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #55 from David Halik auralva...@gmail.com 2009-04-14 21:51:52 EDT --- Thanks stevel. 1.1.2 src.rpm and spec: http://rpm.rutgers.edu/fedora/songbird-1.1.2-1.fc11.src.rpm http://rpm.rutgers.edu/fedora/songbird.spec As always, compiled Koji rpms are also located at the same address. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #52 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-04-10 21:08:23 EDT --- I won't be able to test during the week-end, so if you have a 1.1.2 being prepared ... There is also a need to think about David sponsorship. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #47 from David Halik auralva...@gmail.com 2009-04-07 10:35:05 EDT --- kwizart: Forcing the RPM_OPT_FLAGS is the cause for the buffer overflow. Allowing it to build normally results in a working SB 1.1.1 on F11. Without RPM_OPT_FLAGS: gcc -o host_ifparser.o -c -DXP_UNIX -O3 With RPM_OPT_FLAGS: gcc -o host_ifparser.o -c -DXP_UNIX -Os -g -pipe -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m32 -march=i586 -mtune=generic -fasynchronous-unwind-tables Is it mandatory that we build with the RPM_OPT_FLAGS? I'm going to try a few things and see which option is causing the overflow, but it would be much simpler if we didn't have to modify them. Recommendations? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #48 from Rex Dieter rdie...@math.unl.edu 2009-04-07 10:50:34 EDT --- More than likely, the stricter RPM_OPT_FLAGS are simply exposing an already-present coding problem. recommendation: fix the code, don't work-around it via different compiler flags than act only as a band-aid. May require some down-n-dirty debugging of host_ifparser.c though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #49 from David Halik auralva...@gmail.com 2009-04-07 11:09:05 EDT --- FYI, host_ifparser.c is just an example of the compile options RPM_OPT_FLAGS was adding, not the specific problem. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #50 from David Halik auralva...@gmail.com 2009-04-07 12:46:51 EDT --- For tracking the buffer overflow with RPM_OPT_FLAGS: http://bugzilla.songbirdnest.com/show_bug.cgi?id=16022 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #51 from David Halik auralva...@gmail.com 2009-04-07 16:42:47 EDT --- The buffer overflow is patched. src.rpm and spec have been updated and tested. 1.1.1 works nicely in F11 now. http://rpm.rutgers.edu/fedora/songbird.spec http://rpm.rutgers.edu/fedora/songbird-1.1.1-3.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #45 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-04-06 05:53:43 EDT --- Okay, so we are focusing on F-11 for now, once the 1.1.1 package will be good, you will be allowed to backport the needed changes to the Songbird 1.0.0 package which may be more suitable for F-9/F-10. (there is no stric policy about reviewing a package twice, different version for different branches. So I'm only pre-reviewing 1.1.1 for F-11). Given the number of improvements and quality assurance that a songbird version needs, It would be better to only update the Rawhide version as a consequence (so, as you said, you can verify the patches to be upstreamed). As we are good for gstreamer by F-11, taglib is waiting for a future 2.0 release to get built on shared, do you have a newer src.rpm so i can look at SongBird 1.1.1 for F-11 ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #46 from David Halik auralva...@gmail.com 2009-04-06 20:05:45 EDT --- @kwizart: Ok, I think I made all the changes you requested. The RPM_OPT_FLAGS and some other xulrunner options were carried over from the new thunderbird 3 spec. I also got rid of the unnecessary minimal-toc issue and fixed a few other things. As discussed, this build currently uses the included taglib until the upcoming taglib release is available, but all gstreamer libraries are from the system. I'm focusing soley on the F11 release at this point. Backporting 1.0.0 to F10 should be trivial later. This current F11 release builds fine on all archs, however I installed F11 beta today and I was not able to get it to run. There is a buffer overflow immediately upon run in both i386 and x86_64. I'm currently submitting the bug and backtrace to the Songbird developers and will get back to you. http://rpm.rutgers.edu/fedora/songbird.spec http://rpm.rutgers.edu/fedora/songbird-1.1.1-2.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #42 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-04-04 04:42:19 EDT --- @David Please work with the gstreamer maintainer to get the patch merged in gstreamer upstream. Once done we can eventually have it backported in our current version of gstreamer for F-11 (if allowed by the maintainer ). What would you do if gstreamer is later updated with the needed fix (along with others gstreamer bugfixes). You will have to rebuild again SB to an internally QA gstreamer ? quoting from SB #15401 I don't think the Fedora peeps are going to take this very well, but they won't have a choice if Songbird is to be stable. Remember that the choice is our. Either to have songbird compliant with the Fedora guidelines either to have it not in repository. And it is more important to have packages that can be maintained easily (without using it own copies) than having packages to just work. You really need to be convinced by this in order to get sponsored as a Fedora contributor, because there is no other choice. F-11 isn't frozen until then, so please work with gstreamer upstream/maintainer to have the probmem solved. Then, what is the last version of the src.rpm ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #43 from Peter Robinson pbrobin...@gmail.com 2009-04-04 05:15:12 EDT --- quoting from SB #15401 I don't think the Fedora peeps are going to take this very well, but they won't have a choice if Songbird is to be stable. Remember that the choice is our. Either to have songbird compliant with the Fedora guidelines either to have it not in repository. And it is more important to have packages that can be maintained easily (without using it own copies) than having packages to just work. By shipping an extra copy of gstreamer it also becomes a security risk if there's a exploit that's fixed in the mainline gstreamer and is missed being updated in the songbird copy. That is why there was an effort a number of releases ago to strip out all the included copies of db4/zlib/etc. EG there was a gstreamer CVE just recently. See RHBZ 481267 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #44 from David Halik auralva...@gmail.com 2009-04-04 10:50:03 EDT --- (In reply to comment #42) @David Please work with the gstreamer maintainer to get the patch merged in gstreamer upstream. Once done we can eventually have it backported in our current version of gstreamer for F-11 (if allowed by the maintainer ). What would you do if gstreamer is later updated with the needed fix (along with others gstreamer bugfixes). You will have to rebuild again SB to an internally QA gstreamer ? AS I said in the above post, gstreamer 0.10.22, which is already in F11, has the necessary patches. quoting from SB #15401 I don't think the Fedora peeps are going to take this very well, but they won't have a choice if Songbird is to be stable. Remember that the choice is our. Either to have songbird compliant with the Fedora guidelines either to have it not in repository. And it is more important to have packages that can be maintained easily (without using it own copies) than having packages to just work. You really need to be convinced by this in order to get sponsored as a Fedora contributor, because there is no other choice. You're missing the point of my statement. Yes, I totally agree that the package should be compliant with Fedora guidelines and easily maintainable, but my point was that in doing so Fedora Songbird builds will be missing developer patches to vendor packages. Each time a new version of Songbird is release a Fedora build will not be possible until all patches are verified as upstreamed to gstreamer, or risk having a non-functioning Songbird. This last release was a perfect example. Are you ok with this? If so, then so am I and we can move on. F-11 isn't frozen until then, so please work with gstreamer upstream/maintainer to have the probmem solved. As I stated, the F11 Songbird doesn't have the issues. All the issues reported were from my F10 backport. SO no problem there. Then, what is the last version of the src.rpm ? I'll update the src.rpm for F11 with all the fixes above and post it this weekend. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #40 from Stephen Lau ste...@songbirdnest.com 2009-03-28 12:43:00 EDT --- (In reply to comment #39) Why are those gstreamer patches not been upstreamed? Using system components is very important for Fedora and if songbird includes their own copy, how will it work with additional codecs installed by the user? They have been upstreamed, they are in GStreamer 0.10.22 which, I believe, is slated for F11. It's just not in F10 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 Rahul Sundaram sunda...@redhat.com changed: What|Removed |Added CC||sunda...@redhat.com --- Comment #39 from Rahul Sundaram sunda...@redhat.com 2009-03-27 23:26:37 EDT --- Why are those gstreamer patches not been upstreamed? Using system components is very important for Fedora and if songbird includes their own copy, how will it work with additional codecs installed by the user? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #41 from Rahul Sundaram sunda...@redhat.com 2009-03-28 13:26:59 EDT --- You can then branch only for Fedora 11 and meanwhile work with gstreamer maintainers in Fedora to see if a updated version could be pushed in for Fedora 10. Including a local copy is (usually) not allowed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #38 from David Halik auralva...@gmail.com 2009-03-24 14:49:15 EDT --- Good news and bad news. The good news is that both the above mentioned bugs are fixed. Songbird bug 15401 is indeed fixed in 0.10.22 and Songbird bug 15432 has been patched. The bad news is that it's looking like building an internal gstreamer is going to have to happen. Each Songbird stable release has any number of gstreamer patches applied, and if we continue to build against the system libraries we will be missing anything that has been upstreamed by Songbird. In order to offer a stable product I don't see how we can run with system libraries since the system gstreamer will always be behind what has been checked in. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #37 from Stephen Lau ste...@songbirdnest.com 2009-03-21 18:26:08 EDT --- (In reply to comment #35) Yes, I am aware of this and another bug. Please see the following threads: http://bugzilla.songbirdnest.com/show_bug.cgi?id=15401 http://bugzilla.songbirdnest.com/show_bug.cgi?id=15432 I have been using the gstreamer system library all along, and continue to do so. Even with the latest 0.10.22 gstreamer package the freezing issue is still there. At this point we're going to have to wait on the upstreamed patches. Stevel, comments? Yeah - I'll try to find out more detail this week on what exactly our upstreamed patches are that are missing from the 0.10.22 packages, and what the ETA is on landing them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #35 from David Halik auralva...@gmail.com 2009-03-19 07:07:19 EDT --- Yes, I am aware of this and another bug. Please see the following threads: http://bugzilla.songbirdnest.com/show_bug.cgi?id=15401 http://bugzilla.songbirdnest.com/show_bug.cgi?id=15432 I have been using the gstreamer system library all along, and continue to do so. Even with the latest 0.10.22 gstreamer package the freezing issue is still there. At this point we're going to have to wait on the upstreamed patches. Stevel, comments? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #34 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-03-19 06:44:01 EDT --- (In reply to comment #33) The latest RPM package (1.1.1 on i386) suffers from a hangs making it unusable because it delivers its own copy of Gstreamer: http://bugzilla.songbirdnest.com/show_bug.cgi?id=15698 Well, indeed, this isn't acceptable at all to have gstreamer internally, so how goes the work to get the patches merged in next gstreamer-libs ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #33 from Vladimir Kotal vl...@devnull.cz 2009-03-19 06:02:25 EDT --- The latest RPM package (1.1.1 on i386) suffers from a hangs making it unusable because it delivers its own copy of Gstreamer: http://bugzilla.songbirdnest.com/show_bug.cgi?id=15698 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 Rex Dieter rdie...@math.unl.edu changed: What|Removed |Added CC||rdie...@math.unl.edu --- Comment #36 from Rex Dieter rdie...@math.unl.edu 2009-03-19 09:17:29 EDT --- hi, I help maintain taglib in fedora, I can help with integration efforts here once taglib2 lands. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=453422
--- Comment #32 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-03-16
16:28:48 EDT ---
Build failed on F-10
http://koji.fedoraproject.org/koji/getfile?taskID=1244213name=build.log
But worked on F-11 (so probably that was expected).
http://koji.fedoraproject.org/koji/taskinfo?taskID=1244393
This package doesn't use our CFLAGS:
- some part uses -O3
- other parts uses ... -fPIC -fno-rtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Woverloaded-virtual -Wsynth -Wno-ctor-dtor-privacy
-Wno-non-virtual-dtor -Wcast-align -Wno-long-long -pedantic
-fno-strict-aliasing -fshort-wchar -pthread -pipe -DNDEBUG -DTRIMMED -Os
-freorder-blocks -fno-reorder-functions
Instead, the package have to obbey to the $RPM_OPT_FLAGS macro.
Once that said, according to thunderbird 3:
http://kojipkgs.fedoraproject.org/packages/thunderbird/3.0/1.beta2.fc11/data/logs/i586/build.log
the -O2 compiler optimization doesn't seems compatible with xulrunner and
thunderbird have it changed to -Os. This is the same with stable release. So we
may need to do the same.
Actually only ppc64 use our CFLAGS since it is tweaked from the spec for
minimal toc, but it is added twice since this is now in the default
RPM_OPT_FLAGS for ppc64 by F-11
See in http://koji.fedoraproject.org/koji/getfile?taskID=1244397name=build.log
- Internal taglib - I've thought works was done to have it use the system
version. Why is it still internally used by F-11 ?
- Weird conditionals %ifnarch i586 and %ifarch i586
better to use:
%ifarch %{ix86}
%define sb_arch i686
%else
%define sb_arch %{_arch}
%endif
That will make the spec to work on F-10 and F-11.
- It seems to be better to have sed -i s/-gstabs+//g configure.ac
for all arches unless there are good reason to override -g from our
RPM_OPT_FLAGS.
- Icons sizes:
cp -p ../app/branding/icon64.png etc
Only the 64 pixels is available upstream. It could be nicer to use the .xpm
icon pixelated to png with differents size, or to use the .xpm icon directly.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #31 from David Halik auralva...@gmail.com 2009-03-13 13:36:14 EDT --- Here is the latest spec and srpm built against F11. There are a few open Linux bugs there are affecting the 1.1.1 release, but the build part of the equation has been worked out successfully. http://rpm.rutgers.edu/fedora/songbird.spec http://rpm.rutgers.edu/fedora/songbird-1.1.1-1.fc11.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #30 from David Halik auralva...@gmail.com 2009-03-12 15:28:46 EDT --- Songbird 1.1.1 stable is now out and the srpm has been updated accordingly. I very happy with the progress of the package so far thanks to everyone's help. I think all of the issues that were raised have been addressed. I'm going to post the spec and srpm as soon as a few issues are worked out. There seems to be a xulrunner bug when building under F11 which might need a patch. There is also a hanging issue that is effecting Songbird *NIX users and we're debugging it. Initial guessing points to the latest gstreamer patches from Songbird that aren't in the system libraries yet. (In reply to comment #29) Well, since there is a 1.1 beta2 release two days ago, I wonder if it wouldn't be suitable to concentrate a this 1.1 pre-release while targeting Fedora-11. That would be easier to have fix merged if any. Beginning with this release I'll targert F11 as suggested. Just a quick notes,(don't update the spec just for this at this time): Uses Source0: instead of Source: Done. While using desktop-file-install, please don't use fedora as vendor leaving it empty () for now. Done. Use cp -p to prevent timestamps changes while copying various files/directory. Done. Don't hardcode the parallel build macro: Done. %post and %postun. Are you really sure you need to run ldconfig at %post and %postun (thunderbird doesn't do that at least). I did some researching and you're correct. Since we're not sharing out any libraries ldconfig is not necessary. Removed. you should try to use GTK+ icon cache (with various icons size if possible) and avoid using the pixmap directory. Done. I followed the Thunderbird example which also seems to be correct for Songbird. One thing I wanted to note, I spoke with stevel and opened an enhancement bug for the icons. Right now they have very few png's included with the upstreamed tarball, but it's a trivial matter to add a few more. Songbird bugzilla 15652 Please use || : to avoid scriplet failure if something went wrong for any reason. Done. Do you really need BuildRequires: zip ? I guess this is a compression utility. You shouldn't need it to decompress anything, aren't you ? Unless it is used within the buildsystem... I haven't checked yet. Unfortunately, xulrunner's autoconfig requires zip or it dies, so I'm leaving it in for now: checking for zip... no configure: error: zip not found in $PATH -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=453422
--- Comment #29 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-03-02
08:53:56 EDT ---
Well, since there is a 1.1 beta2 release two days ago, I wonder if it wouldn't
be suitable to concentrate a this 1.1 pre-release while targeting Fedora-11.
That would be easier to have fix merged if any.
Then you should be able to backport changes to 1.0 eventually for F9/F10.
Just a quick notes,(don't update the spec just for this at this time):
Uses Source0: instead of Source:
While using desktop-file-install, please don't use fedora as vendor leaving
it empty () for now.
See http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
(that's a rather new guideline whereas it was common practice earlier).
Use cp -p to prevent timestamps changes while copying various files/directory.
Don't hardcode the parallel build macro:
make -f songbird.mk MOZ_MAKE_FLAGS=-j4
make -f songbird.mk MOZ_MAKE_FLAGS=%{?_smp_mflags}
It should allow our builder to build at the maximum speed, If the parallel
build aren't safe, you should have a comment. same if the jobserver isn't
supported from a given makefile.
%post and %postun. Are you really sure you need to run ldconfig at %post and
%postun (thunderbird doesn't do that at least).
Having update-desktop-database there is good since you have mime type
Can you see this http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
Specially, you should try to use GTK+ icon cache (with various icons size if
possible) and avoid using the pixmap directory.
Please use || : to avoid scriplet failure if something went wrong for any
reason.
Do you really need BuildRequires: zip ? I guess this is a compression
utility. You shouldn't need it to decompress anything, aren't you ?
Unless it is used within the buildsystem... I haven't checked yet.
At this step, it was still a preliminary review at the looking at the spec
level.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #28 from David Halik auralva...@gmail.com 2009-02-13 16:46:24 EDT --- Based off of the method used in the Thunderbird package, the internal provides are now filtered out properly. This avoids any potential conflicts between system libraries, such as libxul, and those packaged with Songbird. http://rpm.rutgers.edu/fedora/songbird.spec http://rpm.rutgers.edu/fedora/songbird-1.0.0-4.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #27 from David Halik auralva...@gmail.com 2009-02-12 17:30:10 EDT --- @Nikolay I looked into the symlinking issue. There was a bug open on this upstream that has now been fixed and allows for proper symlinking to the mozilla wrapper script. http://bugzilla.songbirdnest.com/show_bug.cgi?id=13265 1.1 is due out in the next week or two and this fix will be in it. @kwizart I implemented some more fixes and spun rev 3. It's located here: http://rpm.rutgers.edu/fedora/songbird.spec http://rpm.rutgers.edu/fedora/songbird-1.0.0-3.fc10.src.rpm The mozilla startup script I just discussed sets up the proper LD paths to ensure that songbird only uses the provided internal libraries, but I see what you're getting at with the other package provides. I'm looking at the other mozilla packages to ensure that songbird is filtered and doesn't end up providing libxul.so (and others) to the general package population. I also trimmed the vendor source ball to only the required packages. The src.rpm is a much more managable size now. With the next release coming out soon I'm going to try and work with upstream (stevel) to get a reduced size tarball next time. Right now the two major bugs I see are the symlinking wrapper issue in 13265 (which will be fixed soon) and filtering the internal provides to only the necessary ones. Anything else stand out as an obvious problem? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #26 from David Halik auralva...@gmail.com 2009-02-02 13:33:47 EDT --- @kwizart Thanks for the help. I'm looking at some of the suggestions you posted as well as trimming down the tarball. I'll post revision 3 soon with the changes and updated src rpm. Once that happens having remi look it over would definitely be beneficial. Let me work on it a bit first before we move forward. @Nikolay /usr/bin/songbird is just a sym link to songbird-bin, but it appears as though I missed the scriplet that you pointed out. Songbird should ideally be run with /usr/lib/songbird-1.0.0/songbird which in turn runs songbird-bin and sets up the dependency paths properly. libjemalloc is provided by the patched internal xulrunner, but it looks as if running the binary directly causes songbird to look for the dependency on the system, not in the songbird root. If xulrunner is not installed it then breaks. Thanks for pointing this out. Songbird running against the system xulrunner is not a good idea since all the internal fixes Songbird relies upon are missing. I'll fix this in the upcoming release I mentioned. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #25 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-02-02 06:04:56 EDT --- (In reply to comment #24) 1) Is anyone going to make a full review for this + sponsoring the packager? I unfortunately don't believe due to packaging policies that songbird can be included until it can be compiled against the Fedora xulrunner rather than its own. We are definitely not expecting songbird to use the vanilla libxul in order to be acceptable. (even thunderbird use it owns libxul, and it is very important for the songbird fedora package maintainer to look at how the thunderbird package is done. Specially about how to filter the provides of the internal libxul) BUT, using the system libxul should be doable at some later point. I will forward an email to remi who could do the final review and sponsorship (specially as he's experienced in mozilla apps packaging). Hence, I could assist him with a preliminary review. @David you seems to have done a release: 2, but the corresponding srpm isn't here. Can you implement the contribs dependencies source package to be smaller, as requested in #c20 ? I will start review then. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #23 from Nikolay Vladimirov niko...@vladimiroff.com 2009-01-31 16:08:29 EDT --- Several things: 1) Is anyone going to make a full review for this + sponsoring the packager? 2) There is an issue with the package. When installed it places the binary executable in /usr/bin/songbird which leads to: songbird: error while loading shared libraries: libjemalloc.so: cannot open shared object file: No such file or directory Running songbird-bin from /usr/lib64/songbird-1.0.0 raises the same error. I guess that the start up script songbird must be used. As far as I know it's some generic mozilla script that's used for starting their apps. For example firefox uses something similar. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #24 from Peter Robinson pbrobin...@gmail.com 2009-02-01 02:44:56 EDT --- 1) Is anyone going to make a full review for this + sponsoring the packager? I unfortunately don't believe due to packaging policies that songbird can be included until it can be compiled against the Fedora xulrunner rather than its own. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=453422
Nicolas Chauvet (kwizart) kwiz...@gmail.com changed:
What|Removed |Added
CC||kwiz...@gmail.com
--- Comment #20 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-01-30
07:54:15 EDT ---
Hi!
What is the status of this package ?
Is this the last package version !
Just one note for now:
* Why is it using zlib-static ?
zlib doesn't change that much nor produce a circle dependency. So the needs of
static linking doens't make sense IMO.
* The source rpm is definitely enormous it would seems easier to repack the
%{tarname}%{version}-860-vendor.tar.bz2 with cherry picking only what is needed
to be built internally for the given Fedora version(xulrunner/taglib/other?).
This can be made using a script that will have to be provided within the source
package. (as source100: for example).
*BTW you need to use Source0: instead of Source:
But having a script to repack the source dependencies isn't that a real
solution.
The best way would be to have a script provided from the Songbird upstream(hi
Stephen) To download a given (vanilla) version of a Songbird dependency, with
only the related patch needed by Songbird (if there is). And That for each
Songbird dependency. (following the VideoLan example, with vlc)
This will allow for the packager (and the other packagers, that will check the
Songbird Packager commits during the whole live for the package), to control
which will be the difference between the system package and eventually, to
override the use of an internal dependency if the Songbird patch is for another
platform or already merged in the new system version...
For now, I think we will need to use xulrunner internally, but what the current
status of the (system) xulrunner 3.1 usability with SongBird ? (xulrunner 3.1
is already present in Rawhide/F-11).
We could also ask the feodra taglib package maintainer if he will allow to
backport the needed patch for F-11 (unless it breaks the taglib ABI).
/me is still rpmbuilding Songbird for F-10 x86_64
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #21 from Stephen Lau ste...@songbirdnest.com 2009-01-30 09:31:57 EDT --- (In reply to comment #20) Hi! What is the status of this package ? Is this the last package version ! David (auralvance) has spun 1.0 Fedora RPMs here: http://wiki.songbirdnest.com/Developer/Articles/Builds/Contributed_Builds Just one note for now: * Why is it using zlib-static ? zlib doesn't change that much nor produce a circle dependency. So the needs of static linking doens't make sense IMO. It can use the system zlib. For now, I think we will need to use xulrunner internally, but what the current status of the (system) xulrunner 3.1 usability with SongBird ? (xulrunner 3.1 is already present in Rawhide/F-11). Still not possible... unless the XULRunner has the patches we depend on, Songbird will not likely work. :( -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #22 from David Halik auralva...@gmail.com 2009-01-30 10:11:16 EDT --- My mistake. I forgot to log in and update the ticket after the 1.0 release. :) Yes, the 1.0 rpm's have been out for sometime. Here's the direct link to the src.rpm and spec, all of which you can find in the url stevel pointed out. As of the latest release we use system zlib. http://rpm.rutgers.edu/fedora/songbird-1.0.0-1.fc10.src.rpm http://rpm.rutgers.edu/fedora/songbird.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #14 from David Halik [EMAIL PROTECTED] 2008-12-08 11:44:13 EDT --- In keeping with the Songbird release of 1.0, I've bumped the package version and spec file. Both can be found here along with stable builds from koji: http://rpm.rutgers.edu/fedora/songbird-1.0.0-1.fc10.src.rpm http://rpm.rutgers.edu/fedora/songbird.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #15 from Peter Robinson [EMAIL PROTECTED] 2008-12-08 11:49:18 EDT --- What is the status of being about to build it with the distro gstreamer/xulrunner? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #16 from Stephen Lau [EMAIL PROTECTED] 2008-12-08 11:59:49 EDT --- It should build fine with a distribution GStreamer as long as it's up to date enough. It still has local XULRunner patches that haven't yet made it upstream though. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #17 from David Halik [EMAIL PROTECTED] 2008-12-08 13:04:58 EDT --- Exactly. In Fedora, the only packages that I need to build against locally are taglib and xulrunner. System gstreamer works just fine. The localized xulrunner though is a blocker until its either accepted as is or the patches are fully upstreamed. I think the larger issue is whether or not all the patches can be upstreamed without changing core mozilla functionality. Stevel would know better, but I'm guessing that all the patches that could easily be implemented have been and the rest are sensitive. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #18 from Peter Robinson [EMAIL PROTECTED] 2008-12-08 13:59:19 EDT --- The upstream songbird tracking bug is 357052. I'm not sure how many of them are Linux dependant or even Fedora dependant bugs but the last time I tried I couldn't even build Songbird against out of tree libraries, it seems that it has improved on the gstreamer front. What's the issues with taglib. https://bugzilla.mozilla.org/show_bug.cgi?id=357052 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #19 from Stephen Lau [EMAIL PROTECTED] 2008-12-08 14:03:48 EDT --- We have patches to taglib for writing back metadata, as well as out-of-order reading of tags from remote files. Additionally, we've applied the community patches for m4a/m4p tag parsing. Scott is working on taglib 2.0 which will (hopefully) contain all these patches, but he isn't merging them into the stable taglib release tree... so until taglib 2.0 is released, we need a private taglib. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 Itamar Reis Peixoto [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Alias||songbird -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #13 from Peter Robinson [EMAIL PROTECTED] 2008-08-30 09:44:24 EDT --- Songbird now has a tracking bug in upstream Mozilla BZ to track their xulrunner issues. https://bugzilla.mozilla.org/show_bug.cgi?id=357052 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #12 from David Halik [EMAIL PROTECTED] 2008-08-26 22:04:39 EDT --- In keeping with the Songbird release of 0.7, I've bumped the package version and spec file. Both can be found here along with stable builds from koji: http://rpm.rutgers.edu/fedora/songbird-0.7.0-1.fc9.src.rpm http://rpm.rutgers.edu/fedora/songbird.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #11 from Peter Robinson [EMAIL PROTECTED] 2008-08-13 04:25:22 EDT --- I would suggest sending an email to the fedora-devel mailing list or to the xulrunner/firefox maintainers directly regarding this. I know the fedora maintainers work closely with the Mozilla guys regarding various bits to do with the linux version of mozilla code so I'm sure they can assist. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #10 from Stephen Lau [EMAIL PROTECTED] 2008-08-12 19:26:39 EDT --- A bunch of us from various XULRunner projects (representing Songbird, Komodo/ActiveState, Mozilla, Mozdev, and others) are hashing out some XULRunner issues on a xulcentral mailing list @ Mozdev. One common theme that is coming up is the importance of a shared XULRunner to distribution adoption. Would someone from Fedora/Red Hat be interested in participating in these discussions? The list page is here if you'd like to signup: https://www.mozdev.org/mailman/listinfo/xulcentral -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Comment #9 from Peter Robinson [EMAIL PROTECTED] 2008-08-11 07:46:06 EDT --- I've looked at building this in the past and found it to be in the too hard basket because it builds against its own copy of xulrunner and gstreamer. Having gone through most of the patches that they apply to the xulrunner code base quite a few of them have upstream bugs and most of the patches that apply to the linux build are fairly trivial bug fixes but the SongBird devs aren't pushing them for upstream. They all easily will apply and build against the Fedora XULrunner and don't affect firefox and other apps but Fedora would more than likely want them upstream first. The other issue is that most of the build scripts are hardcoded for the locally included copies of the source code and don't use auto* for locating include files etc so as to be able to build against the OS versions. They have said they'll happily accept patches but haven't the time or expertise to do it themselves. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: songbird - Mozilla based multimedia player https://bugzilla.redhat.com/show_bug.cgi?id=453422 [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Additional Comments From [EMAIL PROTECTED] 2008-07-15 16:05 EST --- I wouldn't mind seeing this in Fedora One big thing: XULRunner is in Rawhide as its own package, so you should definitely attempt to build against it as shipped there, rather than stuffing it into this package. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: songbird - Mozilla based multimedia player https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Additional Comments From [EMAIL PROTECTED] 2008-07-15 16:14 EST --- I'd be fine with that, but upstream they heavily patch xulrunner which kills that option. The Songbird dev's would have to either use the unmodified release, or the patches would have to be applied to either the upstreamed xulrunner or in rawhide. Unless one of these changes, the modified version needs to be packaged for Songbird to build against and run. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: songbird - Mozilla based multimedia player https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Additional Comments From [EMAIL PROTECTED] 2008-07-15 16:31 EST --- Upstream is the preferred option. Shoot off an email to [EMAIL PROTECTED] and see what they think. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: songbird - Mozilla based multimedia player https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Additional Comments From [EMAIL PROTECTED] 2008-07-15 16:41 EST --- I would agree that upstream is always nice. For reference, these are the patches. http://src.songbirdnest.com/source/xref/patches/mozilla/ According to the devs, the six digit bug numbers are upstreamed mozilla, the others are Songbird specific. It sounds like they're pushing for using the system wide installation due to issues in Ubuntu and OpenSolaris, so this might actually happen, but I'm not sure on what kind of time frame. I'll run it by gecko-maint though... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: songbird - Mozilla based multimedia player https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Additional Comments From [EMAIL PROTECTED] 2008-07-15 17:39 EST --- The ones that are fixes for upstream bugs are the easiest to justify. The gecko people might agree to carry most of them if they're quality. The other ones probably need to go into upstream XULRunner. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: songbird - Mozilla based multimedia player https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Additional Comments From [EMAIL PROTECTED] 2008-07-05 17:36 EST --- Songbird 0.6.1 now builds under ppc/ppc64 with minimal tweaking and the patch has been sent upstream. See below for the new links and changelog: http://rpm.rutgers.edu/fedora/songbird-0.6.1-3.fc9.src.rpm http://rpm.rutgers.edu/fedora/songbird.spec * Tue Jul 05 2008 David Lee Halik [EMAIL PROTECTED] - 0.6.1-3 - Set -gstabs+ removal to only 64 bit - Enable ppc and ppc64 building - Added -mminimal-toc for ppc64 building -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: songbird - Mozilla based multimedia player https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Additional Comments From [EMAIL PROTECTED] 2008-07-01 08:50 EST --- I was able to fix the debugedit issue by removing -gstabs+ flags from the build process. Apparently, the stripper get caught up on those in x86_64, see bug 453506 The package has now been rebuilt with this fix, and some other small tweaks. Note, ppc building is not possible at the moment: http://rpm.rutgers.edu/fedora/songbird-0.6.1-2.fc9.src.rpm http://rpm.rutgers.edu/fedora/songbird.spec * Mon Jun 30 2008 David Lee Halik [EMAIL PROTECTED] - 0.6.1-2 - Removed flag -gstabs+ from configure.ac to enable debuginfo, bug 453506 - Removed manual stripping for binaries - Removed xulrunner source arch macros -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: songbird - Mozilla based multimedia player https://bugzilla.redhat.com/show_bug.cgi?id=453422 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453422] Review Request: songbird - Mozilla based multimedia player
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: songbird - Mozilla based multimedia player https://bugzilla.redhat.com/show_bug.cgi?id=453422 --- Additional Comments From [EMAIL PROTECTED] 2008-06-30 14:12 EST --- To clarify on the x86_64 debug comment in the spec file: /usr/lib/rpm/debugedit is called during the debug creation process and it fails to read the x86_64 binaries. extracting debug info from /var/tmp/songbird-0.6.1-1-root-mockbuild/usr/lib64/songbird-0.6.1/xulrunner/xulrunner-bin Failed to write file: invalid section entry size This is not an issue in i386. I verified that the packages still work as intended, but the debug info is somehow maligned. This issue is definitely upstream, so I will be posting a bug when I have one. For more info I found the same issue in bug 187243 As for rpmlint, there are some issues, but all are upstream: $ rpmlint /usr/src/redhat/RPMS/i386/songbird-0.6.1-1.fc9.i386.rpm songbird.i386: E: script-without-shebang /usr/lib/songbird-0.6.1/xulrunner/README.txt songbird.i386: E: script-without-shebang /usr/lib/songbird-0.6.1/xulrunner/icons/mozicon16.xpm songbird.i386: E: script-without-shebang /usr/lib/songbird-0.6.1/searchplugins/google-lyrics.xml songbird.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/songbird-0.6.1/README.txt songbird.i386: E: script-without-shebang /usr/lib/songbird-0.6.1/xulrunner/icons/mozicon50.xpm songbird.i386: W: hidden-file-or-dir /usr/lib/songbird-0.6.1/.autoreg songbird.i386: E: zero-length /usr/lib/songbird-0.6.1/.autoreg songbird.i386: E: script-without-shebang /usr/lib/songbird-0.6.1/xulrunner/components/nsContentPrefService.js songbird.i386: W: file-not-utf8 /usr/share/doc/songbird-0.6.1/TRADEMARK.txt songbird.i386: E: script-without-shebang /usr/lib/songbird-0.6.1/components/sbAddonMetadata.js songbird.i386: E: script-without-shebang /usr/lib/songbird-0.6.1/xulrunner/components/nsHandlerService.js songbird.i386: E: script-without-shebang /usr/lib/songbird-0.6.1/xulrunner/LICENSE songbird.i386: E: binary-or-shlib-defines-rpath /usr/lib/songbird-0.6.1/components/sbMetadataHandlerTaglib.so ['$ORIGIN/../xulrunner'] songbird.i386: W: no-soname /usr/lib/songbird-0.6.1/lib/sbGStreamer.so songbird.i386: E: binary-or-shlib-defines-rpath /usr/lib/songbird-0.6.1/xulrunner/mangle ['$ORIGIN/../lib'] songbird.i386: E: binary-or-shlib-defines-rpath /usr/lib/songbird-0.6.1/xulrunner/shlibsign ['$ORIGIN/../lib'] 1 packages and 0 specfiles checked; 12 errors, 4 warnings. The only one I was really concerned with is the RPATH error, but this seems to be completely internal in order to direct songbird to its own xulrunner libs. If it were to ask LD for information I'm guessing songbird would receive local xulrunner libs which are not patched by upstream. Feedback is appreciated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
