[Bug 453870] Review Request: iw - A nl80211 based wireless configuration tool
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: iw - A nl80211 based wireless configuration tool
https://bugzilla.redhat.com/show_bug.cgi?id=453870
--- Additional Comments From [EMAIL PROTECTED] 2008-07-03 08:34 EST ---
Remarks:
* You shpuld add comments describin how to create provided in Source0 tarball.
E.g.something like:
# svn export http://example.com/svn/name/trunk name-1.0.0
# tar cjvf name-1.0.0.tar.bz2 name-1.0.0
Source0:name-1.0.0.tar.bz2
* You may simplify installation process. Instead of
mkdir -p $RPM_BUILD_ROOT%{_bindir}
install -m 0755 %{name} $RPM_BUILD_ROOT%{_bindir}/%{name}
you may do it in the following way:
install -D -p -m 0755 %{name} $RPM_BUILD_ROOT%{_bindir}/%{name}
Note -p (preserves timestamps) and -D (creates all necessary directories).
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453870] Review Request: iw - A nl80211 based wireless configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iw - A nl80211 based wireless configuration tool https://bugzilla.redhat.com/show_bug.cgi?id=453870 --- Additional Comments From [EMAIL PROTECTED] 2008-07-03 09:07 EST --- Thanks for the comments, fixed: http://tgmweb.at/gadllah/iw.spec http://tgmweb.at/gadllah/iw-0.0-0.2.20080703git.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453870] Review Request: iw - A nl80211 based wireless configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iw - A nl80211 based wireless configuration tool https://bugzilla.redhat.com/show_bug.cgi?id=453870 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453870] Review Request: iw - A nl80211 based wireless configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iw - A nl80211 based wireless configuration tool https://bugzilla.redhat.com/show_bug.cgi?id=453870 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-22 06:14 EST --- Adel: Thanks for the package. 1.) I suggest you version the dependency on kernel-devel. At least headers from el5's 2.6.18 are definitely not enough to build this. 2.) The comment that explains how to generate the source tarball should describe how to reproduce the very same sourece tree, and I guess that I'll get a more recent version if I did a simple git clone now. You should probably add a SHA hash of the tree you are packaging, or whatever nonsense does GIT use instead of revision numbers :) Not really a blockers though -- there's nothing you can do wrong when doing that at import time. In all other respect, the package is perfect. Nice work. RPMlint is happy, SPEC file is sane and legible, compiler flags are honoured. Therefore the package is APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453870] Review Request: iw - A nl80211 based wireless configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iw - A nl80211 based wireless configuration tool https://bugzilla.redhat.com/show_bug.cgi?id=453870 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453870] Review Request: iw - A nl80211 based wireless configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iw - A nl80211 based wireless configuration tool https://bugzilla.redhat.com/show_bug.cgi?id=453870 --- Additional Comments From [EMAIL PROTECTED] 2008-07-22 07:58 EST --- Thanks for the review, I have fixed 1) and 2) (fix will be in the imported package). New Package CVS Request === Package Name: iw Short Description: A nl80211 based wireless configuration tool Owners: drago01 Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453870] Review Request: iw - A nl80211 based wireless configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iw - A nl80211 based wireless configuration tool https://bugzilla.redhat.com/show_bug.cgi?id=453870 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-22 12:06 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 453870] Review Request: iw - A nl80211 based wireless configuration tool
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: iw - A nl80211 based wireless configuration tool https://bugzilla.redhat.com/show_bug.cgi?id=453870 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
