[Bug 454125] Review Request: gtest - Google C++ testing framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gtest - Google C++ testing framework
https://bugzilla.redhat.com/show_bug.cgi?id=454125
[EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Additional Comments From [EMAIL PROTECTED] 2008-07-05 15:18 EST ---
I am not sponsored yet. This is an unofficial review
rpmlint produces no output.
Required:
[x] package and spec file named against package naming guidelines
[x] license tag matches with actual license used. Source and package both have
identical license copies. Included in %doc
[x] spec file has permissible content, is legible and written in American
English
[x] md5sum for source (at project page) and source inside srpm meet -
md5sum 669530b4399d8e02c1c96483bd939f6c
[x] successfully build and compiled on different platforms (used koji to build
on ppc, ppc64, i386, x86_64)
[x] Build dependency - chrpath listed in BuildRoot
[-] Handle locales -- N/A
[-] relocatable -- N/A
[x] owns all directories created
[x] permissions okay
[x] %clean section present
[x] macros used consistently
[x] Header files in -devel package
[x] static libraries --disabled
[x] base devel package requirement
fully versioned dependency
Requires: %{name} = %{version}-%{release} Checked
[x] *.la libtool archives removed
[x] No GUI -- %{name}.desktop not required
[x] at beginning of %install and %clean removes buildroot -- Checked
[x] All files are utf-8
[x] -devel subpackage only has symlinks so ldconfig not required in subpackage
[x] package meets package guideline
Optional:
[x] Includes license -- no need to query upstream
[x] description and summary translations -- not available
[x] No file dependency outside /etc, /bin/sbin, /usr/bin, /usr/sbin
Key - = N/A, x = Check, ! = Problem, ? = Not evaluated
Package looks Okay to me
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454125] Review Request: gtest - Google C++ testing framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtest - Google C++ testing framework https://bugzilla.redhat.com/show_bug.cgi?id=454125 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-07-23 06:37 EST --- I would like to review it officially now. Will review today late or tomorrow. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454125] Review Request: gtest - Google C++ testing framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: gtest - Google C++ testing framework
https://bugzilla.redhat.com/show_bug.cgi?id=454125
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |ASSIGNED
Flag|fedora-review? |fedora-review+
--- Additional Comments From [EMAIL PROTECTED] 2008-07-24 01:26 EST ---
Package APPROVED
Package build successfully (ppc, ppc64, i386, x86_64)
Required
[x] rpmlint output -- clean
[x] package naming
[x] spec file name
[x] packaging guidlines
[x] license approved
[x] license field in spec
[x] license file
[x] language used in spec file -- American English
[x] spec file -- legible
[x] Source0 link
md5sum
upstream - 669530b4399d8e02c1c96483bd939f6c
package source - 669530b4399d8e02c1c96483bd939f6c
[x] package build in mock
[x] BuildRequires
[NA] locales
[NA] relocatable
[x] owns directory it creates in %{doc}
[x] duplicate files not present
[x] %clean & %install section contain rm -rf $RPM_BUILD_ROOT
[x] permissible package content
[x] file encoding - utf-8
[x] file permissions -- correct
[x] package has no dependency on files in %doc
[NA] GUI
[x] -devel subpackage only has symlinks so ldconfig not required in subpackage
[x] *.la libtool archives removed
[x] base devel package requirement
fully versioned dependency
Requires: %{name} = %{version}-%{release} Checked
Optional
[NA] Query upstream regarding license
[NA] Translation for description and summary available
[x] Package build in mock for most of architectures
[NA] scripts used
[x] No dependencies outside FHS guidelines
Optional suggestions: None
Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454125] Review Request: gtest - Google C++ testing framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtest - Google C++ testing framework https://bugzilla.redhat.com/show_bug.cgi?id=454125 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-07-24 06:44 EST --- New Package CVS Request === Package Name: gtest Short Description: Google C++ testing framework Owners: rishi Branches: F-8 F-9 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454125] Review Request: gtest - Google C++ testing framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtest - Google C++ testing framework https://bugzilla.redhat.com/show_bug.cgi?id=454125 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-24 14:25 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454125] Review Request: gtest - Google C++ testing framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gtest - Google C++ testing framework https://bugzilla.redhat.com/show_bug.cgi?id=454125 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Additional Comments From [EMAIL PROTECTED] 2008-07-26 04:48 EST --- Tagged and built for Rawhide. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
