[Bug 454134] Review Request: gnome-desktop-sharp - .NET language binding for mono

2008-07-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono


https://bugzilla.redhat.com/show_bug.cgi?id=454134


[EMAIL PROTECTED] changed:

   What|Removed |Added

 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
 Status|NEW |ASSIGNED
   Flag||fedora-review?




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454134] Review Request: gnome-desktop-sharp - .NET language binding for mono

2008-07-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono


https://bugzilla.redhat.com/show_bug.cgi?id=454134





--- Additional Comments From [EMAIL PROTECTED]  2008-07-05 08:13 EST ---
formal review is here, see notes on the end

OK  source files match upstream:
b99729f7a7265fb1cecf09ced31e009e3ccd66bb  
gnome-desktop-sharp-2.20.1.tar.bz2
OK  package meets naming and versioning guidelines.
OK  specfile is properly named, is cleanly written and uses macros 
consistently.
OK  dist tag is present.
OK  build root is correct.
BAD license field matches the actual license.
OK  license is open source-compatible (LGPLv2+). License text included in 
package.
OK  latest version is being packaged.
OK  BuildRequires are proper.
N/A compiler flags are appropriate.
OK  %clean is present.
OK  package builds in koji (Rawhide/x86_64).
OK  debuginfo package looks complete.
OK  rpmlint is silent.
BAD final provides and requires look sane.
N/A %check is present and all tests pass.
OK  shared libraries are added to the regular linker search paths, correct
scriptlets exist
OK  owns the directories it creates.
OK  doesn't own any directories it shouldn't.
OK  no duplicates in %files.
OK  file permissions are appropriate.
OK  correct scriptlets present.
OK  code, not content.
OK  documentation is small, so no -docs subpackage is necessary.
OK  %docs are not necessary for the proper functioning of the package.
OK  no headers.
OK  pkgconfig files are in devel subpackage
OK  no libtool .la droppings.
OK  not a GUI app.


* are you sure about the LGPLv2+ license tag? I was able to find only LGPLv2
references in the sources
* this package should obsolete the standalone gtksourceview2-sharp package
* the NEWS file can be removed from %doc as there is no real content


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454134] Review Request: gnome-desktop-sharp - .NET language binding for mono

2008-07-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono


https://bugzilla.redhat.com/show_bug.cgi?id=454134





--- Additional Comments From [EMAIL PROTECTED]  2008-07-05 09:39 EST ---
Correct, it's a LGPLv2.1 with a shortname LGPLv2.
was confusing with a couple of opened files from previous release gnome-sharp.

SPEC: 
http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-sharp.spec
SRPM:
http://laxathom.fedorapeople.org/RPMS/gnome-desktop-sharp/gnome-desktop-sharp-2.20.1-2.fc10.src.rpm
   
 



-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454134] Review Request: gnome-desktop-sharp - .NET language binding for mono

2008-07-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono


https://bugzilla.redhat.com/show_bug.cgi?id=454134


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-review?  |fedora-review+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-05 10:12 EST ---
All issues are fixed now, this PACKAGE is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454134] Review Request: gnome-desktop-sharp - .NET language binding for mono

2008-07-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono


https://bugzilla.redhat.com/show_bug.cgi?id=454134


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag||fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-07-05 10:29 EST ---
Thanks Dan.

New Package CVS Request
===
Package Name: gnome-desktop-sharp
Short Description: .Net language binding for mono
Owners: laxathom
Branches: F-9 EL-5
InitialCC

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454134] Review Request: gnome-desktop-sharp - .NET language binding for mono

2008-07-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono


https://bugzilla.redhat.com/show_bug.cgi?id=454134


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




--- Additional Comments From [EMAIL PROTECTED]  2008-07-05 14:11 EST ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454134] Review Request: gnome-desktop-sharp - .NET language binding for mono

2008-07-05 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono


https://bugzilla.redhat.com/show_bug.cgi?id=454134


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE
   Flag|fedora-cvs+ |fedora-cvs?




--- Additional Comments From [EMAIL PROTECTED]  2008-07-05 15:52 EST ---
Thanks Kevin.

imported and built on rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454134] Review Request: gnome-desktop-sharp - .NET language binding for mono

2008-07-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono


https://bugzilla.redhat.com/show_bug.cgi?id=454134


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2008-07-06 18:38 EST ---
Will this be pushed to F-9 and EL-5 soon? It's needed to update gnome-do -- 
thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454134] Review Request: gnome-desktop-sharp - .NET language binding for mono

2008-07-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono


https://bugzilla.redhat.com/show_bug.cgi?id=454134





--- Additional Comments From [EMAIL PROTECTED]  2008-07-06 19:34 EST ---
(In reply to comment #7)
> Will this be pushed to F-9 and EL-5 soon? It's needed to update gnome-do --
thanks!

The update of gnome-sharp to 2.20 (which is required for gnome-desktop-sharp to
be added to F-9) caused a huge amount of collateral damage in rawhide
necessitating rebuilding many mono apps such as f-spot, banshee, muine and
others, see the relevant threads on fedora-devel-list:

http://www.redhat.com/archives/fedora-devel-list/2008-July/msg00159.html
http://www.redhat.com/archives/fedora-devel-list/2008-July/msg00170.html

Some are still not yet rebuilding because the jump to 2.20 affects many packages
across the entire mono stack in unanticipated ways.

I think it's wise to let the dust settle in rawhide before pushing this to F-9,
gnome-do users can wait.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 454134] Review Request: gnome-desktop-sharp - .NET language binding for mono

2008-07-06 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-desktop-sharp - .NET language binding for mono


https://bugzilla.redhat.com/show_bug.cgi?id=454134


[EMAIL PROTECTED] changed:

   What|Removed |Added

   Flag|fedora-cvs? |fedora-cvs+




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review