[Bug 454867] Review Request: kcirbshooter - A small puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454867 Stefan Posdzich <[EMAIL PROTECTED]> changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454867] Review Request: kcirbshooter - A small puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454867 Kevin Fenzi <[EMAIL PROTECTED]> changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Comment #16 from Kevin Fenzi <[EMAIL PROTECTED]> 2008-11-05 17:41:05 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454867] Review Request: kcirbshooter - A small puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454867 Stefan Posdzich <[EMAIL PROTECTED]> changed: What|Removed |Added Flag||fedora-cvs? --- Comment #15 from Stefan Posdzich <[EMAIL PROTECTED]> 2008-11-05 12:37:21 EDT --- New Package CVS Request === Package Name: kcirbshooter Short Description: A small puzzle game Owners: cheekyboinc Branches: F-8 F-9 F-10 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454867] Review Request: kcirbshooter - A small puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454867 Nils Philippsen <[EMAIL PROTECTED]> changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Comment #14 from Nils Philippsen <[EMAIL PROTECTED]> 2008-11-05 09:58:51 EDT --- Good: - Re-added information about the copyright terms and holder to the source file. - No compiled executable found in the source tarball. - Uses $RPM_BUILD_ROOT consistently. - Uses RPM optimization flags - Corrected grammar of description. APPROVED. Go ahead and request CVS to be set up now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454867] Review Request: kcirbshooter - A small puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454867 Stefan Posdzich <[EMAIL PROTECTED]> changed: What|Removed |Added Flag|needinfo?([EMAIL PROTECTED] | |ightlinux.org) | --- Comment #13 from Stefan Posdzich <[EMAIL PROTECTED]> 2008-10-27 14:49:50 EDT --- Hope all "problems" are fixed now! Spec: http://cheekyboinc.spielen-unter-linux.de/kcirbshooter.spec SRPM: http://cheekyboinc.spielen-unter-linux.de/kcirbshooter-0.04-2.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454867] Review Request: kcirbshooter - A small puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454867 --- Comment #12 from Nils Philippsen <[EMAIL PROTECTED]> 2008-10-27 13:54:32 EDT --- Created an attachment (id=321634) --> (https://bugzilla.redhat.com/attachment.cgi?id=321634) Patch which allows setting of OPTFLAGS for the Makefile -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454867] Review Request: kcirbshooter - A small puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454867 --- Comment #11 from Tom "spot" Callaway <[EMAIL PROTECTED]> 2008-10-27 13:47:16 EDT --- (In reply to comment #10) > (*) e.g. "kcirbshooter is a fork of the game found at http://... which was > done > to avoid confusion with the original Brickshooter(tm) game" -- Spot, what do > you think? Sure, that should be within the realm of fair use. ~spot -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454867] Review Request: kcirbshooter - A small puzzle game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=454867
Nils Philippsen <[EMAIL PROTECTED]> changed:
What|Removed |Added
Summary|Review Request: |Review Request:
|brickshooter - A small |kcirbshooter - A small
|puzzle game |puzzle game
Flag||needinfo?([EMAIL PROTECTED]
||ightlinux.org)
--- Comment #10 from Nils Philippsen <[EMAIL PROTECTED]> 2008-10-27 11:49:02
EDT ---
All this on top of my first review in comment #1.
Bad:
- MUSTFIX: Re-add information about the copyright terms and holder to the
source file (luckily there's only one ;-), i.e. I found the following in the
original source file and leaving it out may technically be a GPL violation:
...
License: GPLv2
[EMAIL PROTECTED]
20080502
...
Possibly just leave the existing top level comment and add yours(*) before that
to be on the safe side.
(*) e.g. "kcirbshooter is a fork of the game found at http://... which was done
to avoid confusion with the original Brickshooter(tm) game" -- Spot, what do
you think?
- MUSTFIX: Don't distribute the compiled executable in the source tarball, it
might use the pre-built binary otherwise.
- MUSTFIX: Use either $RPM_BUILD_ROOT or %buildroot consistently, not both.
- MUSTFIX: Use RPM optimization flags. I'll attach a patch which lets you set
them this way:
make OPTFLAGS="%optflags" ${?_smp_mflags}"
- MUSTFIX: correct grammar of description:
"""
Kcirbshooter is a small puzzle game for linux, where you have
to clear the central area from differently colored bricks. Three or
more adjacent bricks of the same color will vanish. You can shoot
bricks into the playing field from the fringes.
"""
Good:
=
- No potential for confusion with original Brickshooter game.
- Owns all directories it creates or depends on packages that contain them.
- Includes license as documentation
- Builds in mock.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 454867] Review Request: kcirbshooter - A small puzzle game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=454867 Nils Philippsen <[EMAIL PROTECTED]> changed: What|Removed |Added Blocks|182235 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
