[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 [EMAIL PROTECTED] changed: What|Removed |Added AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] Status|NEW |ASSIGNED Summary|Review Request: perl- |Review Request: perl- |Filesys-Df - Perl extension |Filesys-Df - Perl extension |for filesystem disk space |for filesystem disk space |information |information Flag||fedora-review? --- Additional Comments From [EMAIL PROTECTED] 2008-07-23 00:45 EST --- build failed http://koji.fedoraproject.org/koji/getfile?taskID=733112&name=build.log -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 --- Additional Comments From [EMAIL PROTECTED] 2008-07-23 06:01 EST --- Fixed: http://koji.fedoraproject.org/koji/taskinfo?taskID=733592 SPEC and SRPM are updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 --- Additional Comments From [EMAIL PROTECTED] 2008-07-23 06:09 EST --- rpmlint gave me perl-Filesys-Df.i386: E: zero-length /usr/lib/perl5/vendor_perl/5.10.0/i386-linux-thread-multi/auto/Filesys/Df/Df.bs ==> is this really required? If not remove it. perl-Filesys-Df.i386: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-Filesys-Df-0.92/README This file has wrong end-of-line encoding, usually caused by creation or modification on a non-Unix system. It could prevent it from being displayed correctly in some circumstances. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 --- Additional Comments From [EMAIL PROTECTED] 2008-07-23 08:00 EST --- Df.bs: it is bootstrap file for loading so library. Yes, it is zero length. And as far I tried now, it is working even when erase. But since other perl modules has same zero length file (like perl-DBI, perl-Compress-Raw-Bzip2), I'm not sure if I want to remove it. This file is executed by bootstrap statedment in Df.pm (see http://www.perl.com/doc/manual/html/lib/DynaLoader.html ) README - I'm not sure to what to do. Hmmm probably include patch to substitute this newlines (but it will be long patch). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 --- Additional Comments From [EMAIL PROTECTED] 2008-07-23 09:27 EST --- OK. I put into srpm patch to remove dos EOL. I left Df.bs on place. SPEC and SRPM are updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk
space information
https://bugzilla.redhat.com/show_bug.cgi?id=455443
--- Additional Comments From [EMAIL PROTECTED] 2008-07-23 10:06 EST ---
sorry I forgot to put "How to fix wrong-file-end-of-line-encoding".
here it is given
http://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#wrong-file-end-of-line-encoding
==> sed -i 's/\r//'
Regarding .bs files, I checked packages on F9 you mentioned in comment #4 but
didn't find any .bs installed on my machine.
Okay. I just had a look at perl-DBI build.log at
http://kojipkgs.fedoraproject.org/packages/perl-DBI/1.601/4.fc9/data/logs/i386/build.log
and there I see .bs is actually removed using
find /var/tmp/perl-DBI-1.601-4.fc9-root-mockbuild -type f -name '*.bs' -empty
-exec rm -f '{}' ';'
So you should add to spec
find $RPM_BUILD_ROOT -type f -name '*.bs' -empty -exec rm -f {} \;
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug, or are watching someone who is.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 --- Additional Comments From [EMAIL PROTECTED] 2008-07-23 11:00 EST --- Aha, I now realize I checked rhel5 packages instead Fedora. And they have zero *.bs files. Nevertheless I fixed it. I will try to contact author of cpanspec to have this line autogenerated. SPEC and SRPM are updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 --- Additional Comments From [EMAIL PROTECTED] 2008-07-24 07:49 EST --- I really like to see people commenting updated (SPEC and SRPM)path by increasing release tag and adding changelog in SPEC each time they rebuild SRPM. I assume that updated SRPM is http://miroslav.suchy.cz/fedora/perl-Filesys-Df/perl-Filesys-Df-0.92-1.fc9.src.rpm Your package is not building still and failed with build.log http://koji.fedoraproject.org/koji/getfile?taskID=735939&name=build.log -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 --- Additional Comments From [EMAIL PROTECTED] 2008-07-24 11:32 EST --- SRCRPM: http://miroslav.suchy.cz/fedora/perl-Filesys-Df/perl-Filesys-Df-0.92-2.fc9.src.rpm SPEC: http://miroslav.suchy.cz/fedora/perl-Filesys-Df/perl-Filesys-Df.spec Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=736579 $ rpmlint /home/msuchy/rpmbuild/SRPMS/perl-Filesys-Df-0.92-2.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-review? |fedora-review+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-29 02:20 EST --- Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=744642 + rpmlint is silent for SRPM and for RPM. + source files match upstream url a8b0aa3e5151a8a6c8b3067625980934 Filesys-Df-0.92.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful! + Package perl-Filesys-Df-0.92-2.fc10 => Provides: Df.so perl(Filesys::Df) = 0.92 Requires: libc.so.6 libc.so.6(GLIBC_2.1) libc.so.6(GLIBC_2.1.3) perl >= 0:5.006 perl(Carp) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars) rtld(GNU_HASH) APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 [EMAIL PROTECTED] changed: What|Removed |Added Flag||fedora-cvs? --- Additional Comments From [EMAIL PROTECTED] 2008-07-29 07:46 EST --- New Package CVS Request === Package Name: perl-Filesys-Df Short Description: Perl extension for filesystem disk space information Owners: msuchy Branches: devel F-9 EL-4 EL-5 InitialCC: Cvsextras Commits: yes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 [EMAIL PROTECTED] changed: What|Removed |Added Flag|fedora-cvs? |fedora-cvs+ --- Additional Comments From [EMAIL PROTECTED] 2008-07-29 11:42 EST --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 455443] Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-Filesys-Df - Perl extension for filesystem disk space information https://bugzilla.redhat.com/show_bug.cgi?id=455443 [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
