[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456266 Victor G. Vasilyev [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE --- Comment #9 from Victor G. Vasilyev [EMAIL PROTECTED] 2008-08-29 08:04:31 EDT --- Successful koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=792982 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456266 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #8 from Kevin Fenzi [EMAIL PROTECTED] 2008-08-29 00:29:12 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456266 Lillian Angel [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=456266
Lillian Angel [EMAIL PROTECTED] changed:
What|Removed |Added
Flag|needinfo?([EMAIL PROTECTED] |
|ect.org)|
--- Comment #4 from Lillian Angel [EMAIL PROTECTED] 2008-08-27 13:57:02 EDT
---
Only one minor issue. Marked with
rpmlint:
$ rpmlint -i /notnfs/langel/rpm/RPMS/noarch/appframework-*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
http://fedoraproject.org/wiki/Packaging/Guidelines
* 1 Packaging Guidelines
o 1.1 Naming
ok
o 1.2 Legal
ok
o 1.3 No inclusion of pre-built binaries or libraries
n/a
o 1.4 Writing a package from scratch
ok
o 1.5 Modifying an existing package
n/a
o 1.6 Filesystem Layout
ok
+ 1.6.1 Libexecdir
n/a
o 1.7 Use rpmlint
no errors
o 1.8 Changelogs
good
o 1.9 Tags
ok
o 1.10 BuildRoot tag
ok
o 1.11 Requires
ok
o 1.12 BuildRequires
ok
o 1.13 Summary and description
ok
o 1.14 Encoding
ok
o 1.15 Documentation
ok
o 1.16 Compiler flags
ok
o 1.17 Debuginfo packages
n/a
o 1.18 Exclusion of Static Libraries
n/a
o 1.19 Duplication of system libraries
n/a
o 1.20 Beware of Rpath
n/a
o 1.21 Configuration files
n/a
o 1.22 Initscripts
n/a
o 1.23 Desktop files
n/a
o 1.24 Macros
ok. consistent.
o 1.25 Handling Locale Files
n/a
o 1.26 Timestamps
n/a
o 1.27 Parallel make
n/a
o 1.28 Scriptlets requirements
n/a
o 1.29 Running scriptlets only in certain situations
n/a
o 1.30 Scriplets are only allowed to write in certain directories
n/a
o 1.31 Conditional dependencies
n/a
o 1.32 Build packages with separate user accounts
n/a
o 1.33 Relocatable packages
n/a
o 1.34 Code Vs Content
ok
o 1.35 File and Directory Ownership
ok
o 1.36 Users and Groups
ok
o 1.37 Web Applications
n/a
o 1.38 Conflicts
n/a
o 1.39 No External Kernel Modules
n/a
o 1.40 No Files or Directories under /srv
n/a
o 1.41 Application Specific Guidelines
n/a
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
MUST Items:
- MUST: rpmlint must be run on every package. The output should be posted in
the review.
no errors
- MUST: The package must be named according to the Package Naming Guidelines .
done
- MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming Guidelines
.
done
- MUST: The package must meet the Packaging Guidelines .
done
- MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
done
- MUST: The License field in the package spec file must match the actual
license.
done
- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
done
- MUST: The spec file must be written in American English.
done
- MUST: The spec file for the package MUST be legible. If the reviewer is
unable to read the spec file, it will be impossible to perform a review. Fedora
is not the place for entries into the Obfuscated Code Contest
(http://www.ioccc.org/).
done
- MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
done
- MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
on i386
- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
done
- MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
n/a
- MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun.
n/a
- MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
n/a
- MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. Refer to the Guidelines for examples.
ok
- MUST: A package must not contain any duplicate files in the %files listing.
ok
MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
I think the defattr lines
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=456266
--- Comment #5 from Victor G. Vasilyev [EMAIL PROTECTED] 2008-08-27 14:57:04
EDT ---
The forth revision is prepared. The minor issue is fixed.
Spec URL: http://nbi.netbeans.org/files/documents/210/2040/appframework.spec
SRPM URL:
http://nbi.netbeans.org/files/documents/210/2153/appframework-1.03-4.fc10.src.rpm
Changes:
- The %%defattr(-,root,root,-) is used everywhere
- Use the %%{ant} instead of the ant command
- Use the %%{version} in the -n option of the %%setup
Successful koji build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=789109
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456266 --- Comment #6 from Lillian Angel [EMAIL PROTECTED] 2008-08-27 15:01:42 EDT --- Approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456266 --- Comment #7 from Victor G. Vasilyev [EMAIL PROTECTED] 2008-08-27 15:14:19 EDT --- New Package CVS Request === Package Name: appframework Short Description: Swing Application Framework Owners: victorv Branches: InitialCC: -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456266 Conrad Meyer [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #3 from Conrad Meyer [EMAIL PROTECTED] 2008-08-24 06:16:26 EDT --- Changelog format seems a bit off to me, see [0]. Builds in Koji [1]. Spec looks good to me but I havn't done a formal review. [0]: http://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs [1]: http://koji.fedoraproject.org/koji/taskinfo?taskID=782501 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456266 --- Comment #2 from Victor G. Vasilyev [EMAIL PROTECTED] 2008-08-14 11:29:09 EDT --- The second release is prepared for review. Spec URL: http://nbi.netbeans.org/files/documents/210/2040/appframework.spec SRPM URL: http://nbi.netbeans.org/files/documents/210/2109/appframework-1.03-2.fc10.src.rpm Changes: - java-devel jpackage-utils are added as the build requirements - jpackage-utils is added as the run-time requirement - Appropriate values of Group Tags are chosen from the official list - Redundant run-time requirements for /bin/* utilities are removed - A ghost symlink for javadoc package is removed - Documentation added - Both build-time and run-time requirements for the swing-layout package are added - Redundant dependency on swing-worker is removed, because it is included as a part of JRE since version 6. rpmlint shows no errors and no warnings against both SRPM and RPMs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=456266 Brian Pepple [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Blocks|177841 | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: appframework - Swing Application Framework https://bugzilla.redhat.com/show_bug.cgi?id=456266 [EMAIL PROTECTED] changed: What|Removed |Added Summary|Review Request: appframework|Review Request: appframework |- Swing Application |- Swing Application |Framework |Framework --- Additional Comments From [EMAIL PROTECTED] 2008-07-31 13:10 EST --- This is my first contribution so I need a sponsor please. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: appframework - Swing Application Framework https://bugzilla.redhat.com/show_bug.cgi?id=456266 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||177841 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 456266] Review Request: appframework - Swing Application Framework
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: appframework - Swing Application Framework https://bugzilla.redhat.com/show_bug.cgi?id=456266 [EMAIL PROTECTED] changed: What|Removed |Added OtherBugsDependingO||456337 nThis|| -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug, or are watching someone who is. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
