[Bug 457925] Review Request: biniax - An unique arcade logic game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457925
Simon Wesp <[EMAIL PROTECTED]> changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
||g
AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]
||g
Summary|Review Request: biniax - A |Review Request: biniax - An
|unique arcade logic game|unique arcade logic game
Flag||fedora-review+
--- Comment #10 from Simon Wesp <[EMAIL PROTECTED]> 2008-10-25 15:48:02 EDT ---
This "MUST"-Checklist is from:
https://fedoraproject.org/wiki/Packaging/ReviewGuidelines
-
MUST Items:
- MUST: rpmlint must be run on every package. The output should be posted in
the review.
+ rpmlint is silence
- MUST: The package must be named according to the Package Naming Guidelines .
+ OK
- MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming Guidelines
.
+ OK
- MUST: The package must meet the Packaging Guidelines .
+ OK
- MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
+ OK
- MUST: The License field in the package spec file must match the actual
license.
+ OK
- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
+ OK
- MUST: The spec file must be written in American English.
+ OK
- MUST: The spec file for the package MUST be legible. If the reviewer is
unable to read the spec file, it will be impossible to perform a review. Fedora
is not the place for entries into the Obfuscated Code Contest
(http://www.ioccc.org/).
+ OK
- MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
+ OK
No md5sum list on homepage of biniax
12bca4b9b8354519edbdf89faa3c328b biniax-src.zip cassmodiah
12bca4b9b8354519edbdf89faa3c328b biniax-src.zip CheekyBoinc
- MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
+ OK
- MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug filed
in bugzilla, describing the reason that the package does not compile/build/work
on that architecture. The bug number should then be placed in a comment, next
to the corresponding ExcludeArch line. New packages will not have bugzilla
entries during the review process, so they should put this description in the
comment until the package is approved, then file the bugzilla entry, and
replace the long explanation with the bug number. The bug should be marked as
blocking one (or more) of the following bugs to simplify tracking such issues:
FE-ExcludeArch-x86 , FE-ExcludeArch-x64 , FE-ExcludeArch-ppc ,
FE-ExcludeArch-ppc64
+ OK -> short run-test on x86 (cassmodiah)
/ N/A -> no run-test on x64
+ OK -> no run-test on ppc (cheekyboinc)
/ N/A -> no run-test on ppc64
+OK build on all architectures
http://koji.fedoraproject.org/koji/taskinfo?taskID=903139
- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
+OK
- MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
/ N/A
- MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun. If the package has multiple subpackages with libraries, each
subpackage should also have a %post/%postun section that calls /sbin/ldconfig.
An example of the correct syntax for this is:
/ N/A
- MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
+ OK
- MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. Refer to the Guidelines for
[Bug 457925] Review Request: biniax - An unique arcade logic game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457925 --- Comment #6 from Stefan Posdzich <[EMAIL PROTECTED]> 2008-10-18 17:31:04 EDT --- Fixed Version Spec: http://cheekyboinc.spielen-unter-linux.de/biniax.spec SRPM: http://cheekyboinc.spielen-unter-linux.de/biniax-1.2-2.fc10.src.rpm To your last point: I cant reproduce that on Fedora 8 (x86), Fedora 9 (ppc) and Rawhide (x86). Biniax exit without problems. Thanks to Robert for the patch! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457925] Review Request: biniax - An unique arcade logic game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457925 Christopher Stone <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #4 from Christopher Stone <[EMAIL PROTECTED]> 2008-10-18 16:49:58 EDT --- http://www.englishonline.org.cn/en/learners/vocabulary-grammar/grammar-questions/a-or-an -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457925] Review Request: biniax - An unique arcade logic game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457925 --- Comment #5 from Robert Scheck <[EMAIL PROTECTED]> 2008-10-18 16:50:06 EDT --- Created an attachment (id=320769) --> (https://bugzilla.redhat.com/attachment.cgi?id=320769) biniax-1.2-optflags.patch -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457925] Review Request: biniax - An unique arcade logic game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457925 Robert Scheck <[EMAIL PROTECTED]> changed: What|Removed |Added CC||[EMAIL PROTECTED] ||e --- Comment #3 from Robert Scheck <[EMAIL PROTECTED]> 2008-10-18 16:40:58 EDT --- My english is maybe worse, but I would say "A unique" because the "u" is pronounced as "j" so just "a" not "an", right? Sorry... ;-) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457925] Review Request: biniax - An unique arcade logic game
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=457925 --- Comment #2 from Stefan Posdzich <[EMAIL PROTECTED]> 2008-10-10 10:58:40 EDT --- Thanks for your reply! I will look at your points soon and, maybe, fix them / comment. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 457925] Review Request: biniax - An unique arcade logic game
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=457925
Orcan Ogetbil <[EMAIL PROTECTED]> changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #1 from Orcan Ogetbil <[EMAIL PROTECTED]> 2008-10-05 02:53:23 EDT
---
The package is in good condition. Some notes:
-
The line:
dos2unix Readme.txt LICENSE.txt
is not necassary. You can use "sed" instead. See:
http://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#wrong-file-end-of-line-encoding
So you can remove dos2unix from BuildRequires
-
$RPM_OPT_FLAGS is not passed to gcc correctly. Hence the debuginfo package is
not useful.
-
Please be consistent with macros. e.g. in the spec file there is
cp -ra data/* %{buildroot}%{_datadir}/biniax/data
in one line and
%{_datadir}/%{name}
on the other.
-
It would be nice if you can make the desktop file richer. Please see:
http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files
At least, have those fields that are given in that example full.
For instance "Name:Biniax" (mind the capital letter) would look nicer.
-
Summary: An unique ...
should be
Summary: A unique ...
-
The game does not exit properly. I have to kill the process in order to exit
the game.
Is this because of your patch?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
