[Bug 458543] Review Request: eg - a wrapper for Git
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=458543
--- Comment #1 from Jason Tibbitts <[EMAIL PROTECTED]> 2008-08-09 12:47:46 EDT
---
> eg.spec:61: E: use-of-RPM_SOURCE_DIR
> You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to use
> a directory for building, use $RPM_BUILD_ROOT instead.
It's kind of rare to see $RPM_SOURCE_DIR used like that; wouldn't it just be
easier to install %{SOURCE0} directly?
> As mentioned above, there are no other files in the source. Is it normal to
> create something like 'README.Fedora' in this case?
You don't need to invent documentation where none exists. You could, however,
consider writing a manpage and sending it upstream.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458543] Review Request: eg - a wrapper for Git
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=458543
Till Maas <[EMAIL PROTECTED]> changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #2 from Till Maas <[EMAIL PROTECTED]> 2008-08-10 10:24:34 EDT ---
(In reply to comment #1)
> > eg.spec:61: E: use-of-RPM_SOURCE_DIR
> > You use $RPM_SOURCE_DIR or %{_sourcedir} in your spec file. If you have to
> > use
> > a directory for building, use $RPM_BUILD_ROOT instead.
>
> It's kind of rare to see $RPM_SOURCE_DIR used like that; wouldn't it just be
> easier to install %{SOURCE0} directly?
Imho it the source should be copied to the build-dir in %setup, therefore
instead of
cp $RPM_SOURCE_DIR/%{name} $RPM_BUILD_DIR/%{name}-%{version}
this would be better in %prep:
cp -p %SOURCE0 .
I did not test it, but imho it should work. Also note the "-p" to preserve the
timestamp.
When %SOURCE0 would be directly installed in %install, then it make much more
work to create a patch, e.g. I normally run make prep, create the patch and use
"make patch SUFFIX=foo" in Fedora CVS.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 458543] Review Request: eg - a wrapper for Git
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458543 Dan Horák <[EMAIL PROTECTED]> changed: What|Removed |Added Status|NEW |CLOSED CC||[EMAIL PROTECTED] Resolution||DUPLICATE --- Comment #3 from Dan Horák <[EMAIL PROTECTED]> 2008-08-10 14:13:35 EDT --- *** This bug has been marked as a duplicate of 442914 *** -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
