[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 Fedora Update System [EMAIL PROTECTED] changed: What|Removed |Added Status|ASSIGNED|CLOSED Resolution||NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #18 from Fedora Update System [EMAIL PROTECTED] 2008-09-11 13:02:53 EDT --- iok-1.0.8-2.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 Tony Fu [EMAIL PROTECTED] changed: What|Removed |Added CC|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Comment #17 from Tony Fu [EMAIL PROTECTED] 2008-09-09 23:13:31 EDT --- requested by Jens Petersen (#27995) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #16 from Fedora Update System [EMAIL PROTECTED] 2008-09-08 00:35:53 EDT --- iok-1.0.8-2.fc9 has been submitted as an update for Fedora 9. http://admin.fedoraproject.org/updates/iok-1.0.8-2.fc9 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #12 from Jens Petersen [EMAIL PROTECTED] 2008-09-05 03:00:09 EDT --- cvs admin done -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #13 from Parag AN(पराग) [EMAIL PROTECTED] 2008-09-05 03:30:15 EDT --- Package Change Request == Package Name: iok New Branches: EL-5 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #14 from Jens Petersen [EMAIL PROTECTED] 2008-09-05 03:44:05 EDT --- added -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #15 from Parag AN(पराग) [EMAIL PROTECTED] 2008-09-05 03:46:44 EDT --- Jens, Thanks for review and cvs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=459073
--- Comment #8 from Jens Petersen [EMAIL PROTECTED] 2008-09-04 02:39:09 EDT
---
Thanks. Here is the review:
+:ok, =:needs attention
MUST Items:
[+] MUST: rpmlint must be run on every package. The output should be posted in
the review.
[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}
[+] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines.
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[=] MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task.
2bd14a41a710f8c91fd994df6322d748 iok-1.0.8.tar.gz
- Please provide the URL to the source tarball.
[+] MUST: The package must successfully compile and build into binary rpms on
at least one supported architecture.
[+] MUST: All build dependencies must be listed in BuildRequires
[+] MUST: A package must own all directories that it creates.
[+] MUST: A package must not contain any duplicate files in the %files listing.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Each package must have a %clean section
[+] MUST: Each package must consistently use macros
[+] MUST: The package must contain code, or permissable content.
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application.
[+] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: At the beginning of %install, each package MUST run rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
[+] MUST: All filenames in rpm packages must be valid UTF-8.
SHOULD Items:
[+] SHOULD: The reviewer should test that the package builds in mock.
[+] SHOULD: The reviewer should test that the package functions as described.
Package is APPROVED, after adding the missing source url.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 Jens Petersen [EMAIL PROTECTED] changed: What|Removed |Added Status|NEW |ASSIGNED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #9 from Jens Petersen [EMAIL PROTECTED] 2008-09-04 02:40:32 EDT --- Created an attachment (id=315721) -- (https://bugzilla.redhat.com/attachment.cgi?id=315721) iok.spec-1.patch suggestion for improving the description -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #10 from Parag AN(पराग) [EMAIL PROTECTED] 2008-09-04 03:32:34 EDT --- Jens, Thanks for your suggestions. Here is updated package Spec URL: http://paragn.fedorapeople.org/iok/iok.spec SRPM URL: http://paragn.fedorapeople.org/iok/iok-1.0.8-2.fc9.src.rpm Koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=805828 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #11 from Parag AN(पराग) [EMAIL PROTECTED] 2008-09-04 03:42:10 EDT --- New Package CVS Request === Package Name: iok Short Description: Indic onscreen virtual keyboard Owners: pnemade Branches: F-9 InitialCC: petersen -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #6 from Jens Petersen [EMAIL PROTECTED] 2008-09-03 03:18:02 EDT --- smalls things but better to use %configure if possible. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #7 from Parag AN(पराग) [EMAIL PROTECTED] 2008-09-03 09:45:46 EDT --- updated SPEC and SRPM at same location. Spec URL: http://paragn.fedorapeople.org/iok/iok.spec SRPM URL: http://paragn.fedorapeople.org/iok/iok-1.0.8-1.fc9.src.rpm I don't think I should increase release for such minor change. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #5 from Parag AN(पराग) [EMAIL PROTECTED] 2008-09-02 03:27:21 EDT --- Jens, Thanks for your suggestions. Here is updated package Spec URL: http://paragn.fedorapeople.org/iok/iok.spec SRPM URL: http://paragn.fedorapeople.org/iok/iok-1.0.8-1.fc9.src.rpm Koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=799289 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 Jens Petersen [EMAIL PROTECTED] changed: What|Removed |Added Customer Facing||--- AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED] --- Comment #3 from Jens Petersen [EMAIL PROTECTED] 2008-08-21 02:43:37 EDT --- Thanks for the submission. :) I did some testing. And here are some comments and thoughts: - really like the compact size now - it seems to segfault when loading some maps, which is not nice (would be nice if it only displayed the dialog for those cases) - would be nice to have a toggle button between English and native input - I think it would be better to hide the menu bar (at least the Save and modify entries by default) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #4 from Jens Petersen [EMAIL PROTECTED] 2008-08-21 03:36:47 EDT --- (BTW how about using make dist to generate the tarballs?) Otherwise the package looks pretty fine to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 Parag AN(पराग) [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED], ||[EMAIL PROTECTED] --- Comment #1 from Parag AN(पराग) [EMAIL PROTECTED] 2008-08-14 06:08:14 EDT --- koji build = http://koji.fedoraproject.org/koji/taskinfo?taskID=777244 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459073] Review Request: iok - Indic onscreen virtual keyboard
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459073 --- Comment #2 from Parag AN(पराग) [EMAIL PROTECTED] 2008-08-14 06:37:16 EDT --- updated package Spec URL: http://paragn.fedorapeople.org/iok/iok.spec SRPM URL: http://paragn.fedorapeople.org/iok/iok-1.0.7-3.svn9.fc9.src.rpm %changelog * Thu Aug 14 2008 Parag Nemade [EMAIL PROTECTED]- 1.0.7-3.svn9 - fix directory ownership -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
