[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Yaakov Nemoy loupgaroubl...@gmail.com changed: What|Removed |Added Blocks|496433(RussianFedora) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Peter Lemenkov lemen...@gmail.com changed: What|Removed |Added Blocks||496433(RussianFedora) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Yaakov Nemoy loupgaroubl...@gmail.com changed: What|Removed |Added Status|NEW |CLOSED Resolution||WONTFIX Flag|needinfo?(m...@blagblagblag. |fedora-review- |org)| --- Comment #45 from Yaakov Nemoy loupgaroubl...@gmail.com 2009-04-27 18:25:02 EDT --- Fail's legal. It uses ffmpeg, so it's being transferred. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Yaakov Nemoy loupgaroubl...@gmail.com changed: What|Removed |Added Blocks|467363 |201449(FE-DEADREVIEW) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #44 from Zarko zarko.pin...@gmail.com 2009-04-22 05:11:59 EDT --- This package transferred to RPM Fusion: https://bugzilla.rpmfusion.org/show_bug.cgi?id=527 Can you close it here? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #43 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-04-04 01:51:45 EDT --- Is mlt totally useless without kdenlive? Can someone write an application that uses mlt and no ffmpeg? If yes, mlt package belongs to Fedora. Otherwise, we can carry it over to rpmfusion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Zarko zarko.pin...@gmail.com changed: What|Removed |Added CC||zarko.pin...@gmail.com --- Comment #42 from Zarko zarko.pin...@gmail.com 2009-03-13 03:56:23 EDT --- Hello, I took with Dan about ffmpeg libs in mlt. So, I have a question: Can we maybe build kdenlive's RPM on that way it can use mlt (without ffmpeg) if you do not have enabled fusion repo, or with mlt-ffmpeg if you have fusion enabled? Or on other hand, we must build two kdenlive RPMs. (one with mlt, and one with mlt-ffmpeg). That one without ffmpeg call kdenlive and put on Fedora's repo, and another call kdenlive-ffmpeg and put them on Fusion repo. I think this is unnecessary mess, and will be better put the mlt, mlt++ and kdenlive to Fusion repo. kind regards zarko -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #40 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-03-03 21:33:53 EDT --- kwizart, I think you should take this package over, otherwise it might take a very long time for it to get done. I can do the review if you want. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #41 from Yaakov Nemoy loupgaroubl...@gmail.com 2009-03-04 02:27:16 EDT --- I'm sorry to say that jebba's MIA in order to spend more time on other things in life. IF no one wants to take this over, this bug should be closed. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #39 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-03-02 12:16:08 EDT --- ping someone... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Nicolas Chauvet (kwizart) kwiz...@gmail.com changed: What|Removed |Added Flag||needinfo?(m...@blagblagblag. ||org) --- Comment #38 from Nicolas Chauvet (kwizart) kwiz...@gmail.com 2009-02-09 13:06:55 EDT --- 0.3.6 is here. @jebba Are you still interested in mlt ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #37 from Orcan 'oget' Ogetbil oget.fed...@gmail.com 2009-01-31 00:56:41 EDT --- This is one of the slowest progressing bugs I have seen. It doesn't stall, it keeps going, but slow. Folks, we do need nice applications such as kdenlive in Fedora. Can we boost up the pace a little? Complaining fellows: What else do we need from mlt upstream? Or is version 0.3.4 good enough for packaging? I have a feeling that we are waiting for mlt to be capable of running on some ancient computers. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #36 from Dan Dennedy d...@dennedy.org 2008-12-21 23:30:57 EDT --- I added a new configure option --avformat-no-filters to facilitate a codecs and muxers only plugin whose name will not conflict with a stock --avformat-no-codecs plugin. Of course, that is for rpmfusion.org or other non-fedora, but just to let you know that this will prevent a plugin filename clash on a mlt-ffmpeg package and relieve any concerns in that regard. Finally, I have also made changes to mlt and patch to kdenlive to remove all ffmpeg library dependencies from kdenlive to make that easier for acceptance. All of these changes should be in mlt 0.3.4 and kdenlive 0.7.1 due out by the end of the year. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #34 from Dan Dennedy d...@dennedy.org 2008-12-18 01:17:57 EDT --- (In reply to comment #32) (In reply to comment #14) I have built mlt Fedora 8 x86_64 with --disable-qimage --disable-mmx and it worked also for rawhide.(0) But in this last case, i also need to disable see in %prep section: -- #disable sse unless x86_64 %ifnarch x86_64 sed -i.checksse -e 's|ifndef __DARWIN__|ifdef __DARWIN__|' src/modules/motion_est/filter_motion_est.c #Note that this conditional is wrong %endif SSE detection should be moved to ./configure and the code containing SSE instructions should be wrapped in #ifdef HAVE_SSE ... #endif. Please ask upstream to do that. I am upstream, and I have done this. I also checked other code assumed to be MMX to make sure it was not using SSE, and it is not. -- I haven't checked that, but if mmx is used on ppc, then is will certainly fails. What i expect is mmx should be disabled in all cases unless i686: The configure script checks /proc/cpuinfo on Linux to see if mmx: 1 and sse: 1 to automatically disable the respective options. However, you are probably cross-compiling to ppc? %configure \ ... %ifnarch i686 --disable-mmx \ %endif So anyone that want to rebuild mlt with theses options can do so with using --target=i686 for the package. Actually, there are i686 class CPUs without MMX, for example Pentium Pro and there are i586 class CPUs with MMX (Pentium MMX, AMD K6 and K6-2/3). I'd suggest a --with mmx conditional instead. You cannot rely on --target here. Of course, it'd be best handled upstream in a fashion similar to what I've suggested for SSE above. There is still a --disable-mmx. It implies --disable-sse. Do you want to test this from a svn snapshot prior to my next release - planned before end-of-year? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #35 from Dan Dennedy d...@dennedy.org 2008-12-18 02:54:07 EDT --- (In reply to comment #31) I don't want this project to be a nuisance with too many configurations. First of all, I think I should split up my ffmpeg module because there are some elements for deinterlace and color space conversion that are unencumbered and then encumbered format/codec-oriented elements. That would let you or someone else just make a separate package with the encumbered elements similar to gstreamer-ffmpeg. MLT has libdv and libvorbis modules that still make it usable without the encumbered ffmpeg elements. I do not yet think it is necessary to In MLT SVN trunk, I have added a configure option --avformat-no-codecs. This will build the MLT avformat plugin without exposing *any* of the codecs or muxers. This does make a plugin that contains the deinterlace, resampling, and color space converter. The color space converter is required at the moment to make this usable. The --avformat-svn configure option will checkout a specific revision of FFmpeg and then statically link the MLT plugin against it if that makes it any easier (no shared ffmpeg libs to link against). Someone can then make a mlt-ffmpeg package for rpmfusion.org that does something along the lines of: ./configure ... make -C src/framework make -C src/modules/avformat all install This would put only that plugin into the package, but at this point it is a replacement for the one from the main mlt package. IOW, it shares the same file path/name. Is that a problem? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #33 from Nicolas Chauvet (kwizart) [EMAIL PROTECTED] 2008-12-11 11:57:29 EDT --- (In reply to comment #32) Actually, there are i686 class CPUs without MMX, for example Pentium Pro and I'm against to worry about something lower than a PIII specially on a library dedicated for multimedia features. The current workaround would be to allow a i686 target that can have mmx sse and sse2 enabled on x86_32 arch. CPU that aren't capable of theses optimization should remains with the plain i386 package which is the only package that will be provided within the Fedora repositories. Once that said, if the i686 target_cpu doesn't fit well for our needs, then we might want to introduce another ix86 varriant as a rpm macro. But in any cases, Please note that the mmx miss on some ix86 CPU are more important in some Via C3 cases than in pentium pro -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #30 from Nicolas Chauvet (kwizart) [EMAIL PROTECTED] 2008-12-10 08:48:33 EDT --- (In reply to comment #29) ... - I do not understand why the existing --disable-mmx is not satisfactory; maybe he meant --disable-sse2 instead of --disable-sse. But it seems to me all of MLT's usage of MMX is not acceptable to Fedora i386 policy, and I know some of it is not yet compatible with x86-64. So, it seems to me --disable-mmx should be fine as a global option regardless of architecture of the build. We can build the library twice within one mlt.i386 package for i386. (that's done with the atlas package for an example) - one time with mmx sse sse2 disabled. - one other time with mmx sse sse2 enabled. The resulting optimized library will be moved in /usr/lib/sse2 and activated at runtime if the dynamic library loader has detected the running cpu is sse2 capable. For this feature to be enabled, we need to be sure nothing will hardcode the libraries pathes, and that it will be correctly linked (not dlopened for example). - I know nothing about multilibs. That's a packaging level problem. - Re: - Have runtime tests to be done. What exactly does that mean? MLT already attempts to dlopen all so in lib/mlt. That's really bad. We are in $prefix/lib64/mlt on x86_64 ppc64 sparc64 (aka multilibs systems, so not ia64). It would be easier to use libtool-ltdl, but i don't know how to add support for it easily with you current buildsys. Anyway, you should be able to tweak the dlopening path to be correct. Once that said, I'm not sure I can support one more split between mlt non-ffmpeg enabled and mlt-freeworld ffmpeg enabled. Is there any package using mlt that can be in Fedora once mlt is in ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #31 from Dan Dennedy [EMAIL PROTECTED] 2008-12-10 15:27:25 EDT --- we need to be sure nothing will hardcode the libraries pathes ... MLT already attempts to dlopen all so in lib/mlt. That's really bad. We are in $prefix/lib64/mlt on x86_64 ppc64 sparc64 Sorry for my miscommunication. I did not mean literally lib/mlt. It is actually *defaulted* to $(libdir)/mlt, where there is a ./configure option --libdir. The application can override this via API, and there is an environment variable as well. Once that said, I'm not sure I can support one more split between mlt non-ffmpeg enabled and mlt-freeworld ffmpeg enabled. I don't want this project to be a nuisance with too many configurations. First of all, I think I should split up my ffmpeg module because there are some elements for deinterlace and color space conversion that are unencumbered and then encumbered format/codec-oriented elements. That would let you or someone else just make a separate package with the encumbered elements similar to gstreamer-ffmpeg. MLT has libdv and libvorbis modules that still make it usable without the encumbered ffmpeg elements. I do not yet think it is necessary to have good, bad, and ugly packages separate from the framework lib, do you? I think the framework and majority of plugin modules can be in one package. In that case, I need to make it easier/possible to separately build the encumbered ffmpeg module. Feedback welcome. Is there any package using mlt that can be in Fedora once mlt is in? kdenlive, which was rewritten for KDE4 and proving to be fairly usable and stable. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Dominik 'Rathann' Mierzejewski [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #32 from Dominik 'Rathann' Mierzejewski [EMAIL PROTECTED] 2008-12-10 17:17:22 EDT --- (In reply to comment #14) I have built mlt Fedora 8 x86_64 with --disable-qimage --disable-mmx and it worked also for rawhide.(0) But in this last case, i also need to disable see in %prep section: -- #disable sse unless x86_64 %ifnarch x86_64 sed -i.checksse -e 's|ifndef __DARWIN__|ifdef __DARWIN__|' src/modules/motion_est/filter_motion_est.c #Note that this conditional is wrong %endif SSE detection should be moved to ./configure and the code containing SSE instructions should be wrapped in #ifdef HAVE_SSE ... #endif. Please ask upstream to do that. -- I haven't checked that, but if mmx is used on ppc, then is will certainly fails. What i expect is mmx should be disabled in all cases unless i686: %configure \ ... %ifnarch i686 --disable-mmx \ %endif So anyone that want to rebuild mlt with theses options can do so with using --target=i686 for the package. Actually, there are i686 class CPUs without MMX, for example Pentium Pro and there are i586 class CPUs with MMX (Pentium MMX, AMD K6 and K6-2/3). I'd suggest a --with mmx conditional instead. You cannot rely on --target here. Of course, it'd be best handled upstream in a fashion similar to what I've suggested for SSE above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #29 from Dan Dennedy [EMAIL PROTECTED] 2008-12-04 13:51:11 EDT --- There are still some things in Nicolas' comments #18 and #21 that are not addressed because I do not fully understand them. To be honest, I hardly understand anything he writes. - I do not understand why the existing --disable-mmx is not satisfactory; maybe he meant --disable-sse2 instead of --disable-sse. But it seems to me all of MLT's usage of MMX is not acceptable to Fedora i386 policy, and I know some of it is not yet compatible with x86-64. So, it seems to me --disable-mmx should be fine as a global option regardless of architecture of the build. - I know nothing about multilibs. - Re: - Have runtime tests to be done. What exactly does that mean? MLT already attempts to dlopen all so in lib/mlt. Another release is planned before end-of-year. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #28 from Orcan 'oget' Ogetbil [EMAIL PROTECTED] 2008-12-04 01:12:15 EDT --- It looks like the upstream (Dan) made a new release. Who's going to build this package? Dan, is this ready to package now? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added Flag||needinfo? --- Comment #25 from Mamoru Tasaka [EMAIL PROTECTED] 2008-10-30 12:56:17 EDT --- What is the status of this bug? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Nicolas Chauvet (kwizart) [EMAIL PROTECTED] changed: What|Removed |Added Flag|needinfo? | --- Comment #26 from Nicolas Chauvet (kwizart) [EMAIL PROTECTED] 2008-10-30 13:09:43 EDT --- I just wonder if it seems rational to build plugins for applications that cannot goes to fedora (let's name kino or kdenelive) ? At least I wonder if we lack libffmpeg support the program would still be usable ? And what about extending capabilities ? In my test case, the libavformat module failed to load : mlt_repository.c, mlt_repository_init: failed to dlopen /usr/lib64/mlt/libmltavformat.so Whereas the file seems present. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #27 from Dan Dennedy [EMAIL PROTECTED] 2008-10-30 13:53:58 EDT --- (In reply to comment #26) I just wonder if it seems rational to build plugins for applications that cannot goes to fedora (let's name kino or kdenelive) ? Do you refer to Kino and kdenlive the applications or to the MLT modules named kino and kdenlive? Kino does not use MLT, but kdenlive requires it. The MLT kino module simply contains Kino's DV AVI code. The MLT kdenlive module does not contain anything specific to kdenlive. Rather, it is more of a work area for the kdenlive lead developer to add his own effects to MLT. At least I wonder if we lack libffmpeg support the program would still be usable ? MLT is hardly usable at this time without FFmpeg libavformat and libavcodec. There are plans for a gstreamer module, but work has not yet begun. Without FFmpeg, MLT can still be useful for DV only work via libdv and the kino module. And what about extending capabilities ? In my test case, the libavformat module failed to load : mlt_repository.c, mlt_repository_init: failed to dlopen /usr/lib64/mlt/libmltavformat.so Whereas the file seems present. Either there are unresolved symbols or some other build error preventing loading. Quite recently, FFmpeg starting requiring libbz2, and depending upon how you configured, that might be missing. You can do a 'ldd $(which ffmpeg)' and 'ldd libmltavformat.so' and compare them. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #18 from Nicolas Chauvet (kwizart) [EMAIL PROTECTED] 2008-10-20 11:28:18 EDT --- (In reply to comment #15) Why exactly do you need to disable sse even for x86? sse isn't present on all x86 CPU, Thus activating sse on suches CPU is totally forbidden in Fedora for a binary. It is possible to have sse2 activated for a library (see atlas for an example). The changes you make to filter_motion_est.c are illogical, but they are effective at suppressing the respective code (since this is not Darwin platform). The top-level Makefile helper config.mak defines a USE_MMX unless --disable-mmx. Does this make more sense? Yes, this is a hack. To fix this, it would be better to have a --disable-sse option. so it can be disabled unless x86_64. (as all x86_64 have the sse2 cpu capability). Of course, as the koji built showned. You cannot set -DARCH_X86 on ppc64, so the cpu detection for the mlt build system should probably redesigned. mlt-config should be deprecated because pkg-config files are also supplied. However, I do have to convert mlt++ over to pkg-config. I will do that now for the next release. Also, I will check to make sure kdenlive does not use it. I'll consider removing mlt-config as well. I haven't tested it yet, but you should note that the last version of sox also have pkg-config support after having dropped any sox-config file in the F-9 version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #19 from Dan Dennedy [EMAIL PROTECTED] 2008-10-20 13:18:23 EDT --- (In reply to comment #18) I haven't tested it yet, but you should note that the last version of sox also have pkg-config support after having dropped any sox-config file in the F-9 version. mlt does support sox with pkg-config except the sox 14.1.0 .pc file is wrong: https://sourceforge.net/tracker/index.php?func=detailaid=2076270group_id=10706atid=310706 Also, after making some changes (svn trunk) to deal with a changed interface, mlt still crashes on latest sox due to invisible changes :( If you only have a sox 14.1.0 package, then please disable the corresponding mlt module for now: configure --disable-sox. I do plan to fix this prior to the next mlt release. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #20 from Dan Dennedy [EMAIL PROTECTED] 2008-10-20 13:34:31 EDT --- (In reply to comment #18) Of course, as the koji built showned. You cannot set -DARCH_X86 on ppc64, so the cpu detection for the mlt build system should probably redesigned. The mlt xine module should disable itself for ppc64 via src/modules/xine/configure. I have added ppc64 to its tests in svn: http://mlt.svn.sourceforge.net/viewvc/mlt/trunk/mlt/src/modules/xine/configure?r1=1121r2=1185 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=459979
--- Comment #21 from Nicolas Chauvet (kwizart) [EMAIL PROTECTED] 2008-10-20
14:58:00 EDT ---
(In reply to comment #19)
mlt does support sox with pkg-config except the sox 14.1.0 .pc file is wrong:
https://sourceforge.net/tracker/index.php?func=detailaid=2076270group_id=10706atid=310706
Why ?
Even if sox.h ends in $(PREFIX)/include , /usr/include will be in the default
path, so the header will be found anyway... It would be better to have sox.h
not in the default path and use -I/usr/include/sox each time sox libraries are
meant to be linked.
for xine:
Indeed, so it is disabled unless %{ix86} and x86_64
SPECS: http://kwizart.fedorapeople.org/SPECS/mlt.spec
SRPMS: http://kwizart.fedorapeople.org/SRPMS/mlt-0.3.0-5.fc8.kwizart.src.rpm
Summary: Toolkit for broadcasters, video editors, media players, transcoders
There is still some work, specially for (at least):
- The multilibs compliance (to split the binaries and the libraries).
- The modules packaged as sub-packages (so the dependencies will be installed
as needed - see https://bugzilla.redhat.com/show_bug.cgi?id=457035#c7 for a
discution on rpm packaging and modules).
- Have runtime tests to be done.
If the frei0r-devel package isn't ready, it could be possible to enable it
later...
I can offer my help as co-maintainer of the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #22 from jebba [EMAIL PROTECTED] 2008-10-20 16:45:46 EDT --- kwizart, OK, re: co-maintainer :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #23 from Dan Dennedy [EMAIL PROTECTED] 2008-10-20 18:49:52 EDT --- (In reply to comment #21) (In reply to comment #19) mlt does support sox with pkg-config except the sox 14.1.0 .pc file is wrong: https://sourceforge.net/tracker/index.php?func=detailaid=2076270group_id=10706atid=310706 Why ? Even if sox.h ends in $(PREFIX)/include , /usr/include will be in the default path, so the header will be found anyway... It would be better to have sox.h not in the default path and use -I/usr/include/sox each time sox libraries are meant to be linked. You can debate that with the sox developers, not me; it's not my project. The fact of the matter is that it installs a sox.h to includedir defaulted as $prefix/include, and when the $prefix is not /usr, then the header can not be found by simply using 'pkg-config --cflags' Anyways, I suppose this problem does not affect your packaging and therefore worth further discussion, but the runtime compatibility problem between mlt and sox 14.1.0 remains. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #24 from Dan Dennedy [EMAIL PROTECTED] 2008-10-20 18:54:16 EDT --- (In reply to comment #21) There is still some work, specially for (at least): - The multilibs compliance (to split the binaries and the libraries). Is there something I should do to facilitate this? I have already fixed up mlt++ to use pkg-config (svn trunk) and submitted a patch to kdenlive. - Have runtime tests to be done. If the frei0r-devel package isn't ready, it could be possible to enable it later... I do not understand. Is there some upstream change you are suggesting? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #17 from Mamoru Tasaka [EMAIL PROTECTED] 2008-10-18 12:25:56 EDT --- To Nicolas: If you have some suggestion and have your own srpm for this package, would you post it somewhere where we can download it anytime? (don't use koji site for the place to put your srpm: it is deleted within one week or so). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #16 from jebba [EMAIL PROTECTED] 2008-10-17 00:33:21 EDT --- I have also submitted a review request for mlt++ https://bugzilla.redhat.com/show_bug.cgi?id=459979 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Orcan 'oget' Ogetbil [EMAIL PROTECTED] changed: What|Removed |Added Blocks||467363 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #15 from Dan Dennedy [EMAIL PROTECTED] 2008-10-14 13:45:31 EDT --- Why exactly do you need to disable sse even for x86? The changes you make to filter_motion_est.c are illogical, but they are effective at suppressing the respective code (since this is not Darwin platform). The top-level Makefile helper config.mak defines a USE_MMX unless --disable-mmx. Does this make more sense? sed -i.checksse -e 's|ifndef __DARWIN__|if !defined(__DARWIN__) defined(USE_MMX)|' mlt-config should be deprecated because pkg-config files are also supplied. However, I do have to convert mlt++ over to pkg-config. I will do that now for the next release. Also, I will check to make sure kdenlive does not use it. I'll consider removing mlt-config as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #14 from Nicolas Chauvet (kwizart) [EMAIL PROTECTED] 2008-10-14 08:54:58 EDT --- I have built mlt Fedora 8 x86_64 with --disable-qimage --disable-mmx and it worked also for rawhide.(0) But in this last case, i also need to disable see in %prep section: -- #disable sse unless x86_64 %ifnarch x86_64 sed -i.checksse -e 's|ifndef __DARWIN__|ifdef __DARWIN__|' src/modules/motion_est/filter_motion_est.c #Note that this conditional is wrong %endif -- I haven't checked that, but if mmx is used on ppc, then is will certainly fails. What i expect is mmx should be disabled in all cases unless i686: %configure \ ... %ifnarch i686 --disable-mmx \ %endif So anyone that want to rebuild mlt with theses options can do so with using --target=i686 for the package. There is lot of modules that aren't built. jack-rack, frei0r (1) and sox(2) despite this last has been requested as BuildRequires; and there is also others that cannot be in Fedora. The main interest of mlt using modules is that you can add support for theses module at install step. At the packaging level that would be interesting to have mlt splitted into sub-packages , specially if dependencies are huges (candidate are jack-rack and gtk ). About mlt-config, it is not multilibs compliant: (see l.4: export libdir=/usr/lib64 on lib64 systems) There are two workarounds, either hack the libdir value (if /usr/lib64 exist then... else /usr/lib...), or rewrite it as a wrapper around pkg-config. But It would be possible IMO to just delete it and patch the dependent applications (if any ?) to use pkg-config for mlt detection. (0) http://koji.fedoraproject.org/koji/taskinfo?taskID=879994 ppc64 still has failed, might be because of asm conditionals, it should work guess. (1) see https://bugzilla.redhat.com/show_bug.cgi?id=456256 (2) see https://bugzilla.redhat.com/show_bug.cgi?id=226425 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Dan Dennedy [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #11 from Dan Dennedy [EMAIL PROTECTED] 2008-10-13 13:20:34 EDT --- I am the maintainer of MLT. Thank you for packaging it for Fedora. My feedback... It is possible to make a LGPL version if that is what you really want to do. You probably have to remove sources from your source RPM to do so. All GPL-based plugins are identified by an empty file named gpl in their subdirectory (under mlt/src/modules). Also, the albino, humperdink, miracle, and inigo src subdirectories are GPL. I don't really know the Fedora guidelines, but Development/Libraries seems more appropriate than Development/Tools even though the description uses the word toolkit. It should be able to build on PPC, but that is not regularly tested as it has not been convenient for me. Maybe I can use some resource at SourceForge for that. More than likely it is something trivial. x86-dependent code should be optional, and the goal of the configure scripts is to detect PPC and disable things appropriately. Regarding compilation optimization flags, another user said -O4 was causing segfault on x86-64 (pending my confirmation), and I may fall back to -O2 for the next release. I recognize Fedora's policy, but there are many also building from source who would like optimization. Also, I agree to remove stripping from future releases. Finally, while I do not consider miracle to be generic, I do agree it is somewhat common and certainly unqualified. In fact, I recommend that you do not not install miracle or albino or humperdink. 'inigo' is the core utility that MLT users recognize and whose name I would like to keep. miracle is a rather niche application at this time, and albino and humperdink are companions to miracle. If you do keep miracle for the sake of convenience, then I do not have a problem with you prefacing it with 'mlt-', but again, I'd rather not do that to inigo. Also, I am planning to rename things in the near future while keeping the MLT moniker (Media Lovin' Toolkit). I will take Fedora recommendations into consideration for the executables. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #12 from jebba [EMAIL PROTECTED] 2008-10-13 15:54:32 EDT --- * Mon Oct 13 2008 jeff [EMAIL PROTECTED] - 0.3.0-4 - Build without fomit-frame-pointer ffmath - Add BuildRequires: prelink - clear-execstack libmltgtk2.so - Don't strip binaries - Group: Development/Libraries - Prefix albino, humperdink, and miracle binaries with mlt- I think we want GPL version not LGPL version, correct? Mamoru Tasaka thanks for your help and Dan Dennedy thanks for the comments and for mlt and for kino and... :) http://www.blagblagblag.org/pub/BLAG/developers/jebba/jebbadora/mlt.spec http://www.blagblagblag.org/pub/BLAG/developers/jebba/jebbadora/mlt-0.3.0-4.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #13 from jebba [EMAIL PROTECTED] 2008-10-14 00:28:42 EDT --- Compiling for x86_64 build on f9 fails with: = cc -o have_mmx.o -c have_mmx.S have_mmx.S: Assembler messages: have_mmx.S:20: Error: suffix or operands invalid for `push' ...and for pushf, pop, popf... make[2]: *** [have_mmx.o] Error 1 = -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=459979
--- Comment #10 from Mamoru Tasaka [EMAIL PROTECTED] 2008-10-08 10:52:47 EDT
---
Well,
* For compilation flags, removing -ffastmath, -fomit-frame-pointer and so on
can be done (for this package) by:
%build
sed -i -e '/fomit-frame-pointer/d' configure
sed -i -e '/ffast-math/d' configure
%configure --enable-gpl --disable-sox
-
* For preventing binaries from being stripped, changing install -c -s to
install -c (in Makefile's in this tarball) will fix it
* For execstack issue, accoding to
https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Executable_stack
the following will fix this issue:
-
BuildRequires: prelink
execstack -c $RPM_BUILD_ROOT%{_libdir}/%{name}/libmltgtk2.so
--
* About binaries' names
- This package installs some files under %_bindir, some of them
have too generic names (like miracle):
https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Use_of_common_namespace
Would you rename binaries' names such as mlt-miracle, for example?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Kevin Fenzi [EMAIL PROTECTED] changed: What|Removed |Added Blocks|177841 | --- Comment #8 from Kevin Fenzi [EMAIL PROTECTED] 2008-10-05 14:38:33 EDT --- Removing NEEDSPONSOR, as I am sponsoring submitter. Jebba: The ping in comment #6 was asking if you had a chance to address the issues mentioned in comment #5. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=459979
--- Comment #9 from jebba [EMAIL PROTECTED] 2008-10-05 16:41:27 EDT ---
I was just buying time. :)
0.3.0-3
http://www.blagblagblag.org/pub/BLAG/developers/jebba/jebbadora/mlt.spec
http://www.blagblagblag.org/pub/BLAG/developers/jebba/jebbadora/mlt-0.3.0-3.fc9.src.rpm
Fixed:
- License: GPLv2+ and LGPLv2+
- Group: Development/Tools
- ExcludeArch: x86_64 s390 s390x ppc ppc64
- %%defattr(-,root,root)
- %%doc docs/
- %%{_libdir}/%%{name} to main package
Punted:
* mlt-devel.i386: W: executable-stack /usr/lib/mlt/libmltgtk2.so
* compilation flags, debug info
I'll be able to fix the compilation flags/debug, but I don't know about the
executable-stack.
Thanks! :)
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added Flag||needinfo?([EMAIL PROTECTED] ||org) --- Comment #6 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-25 02:55:40 EDT --- ping? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 jebba [EMAIL PROTECTED] changed: What|Removed |Added Flag|needinfo?([EMAIL PROTECTED] | |org)| --- Comment #7 from jebba [EMAIL PROTECTED] 2008-09-25 03:16:37 EDT --- pong! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Itamar Reis Peixoto [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] Alias||mlt -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #3 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-10 03:35:13 EDT --- (In reply to comment #2) Revised packages here (0.3.0-2): ftp://ftp.blagblagblag.org/pub/BLAG/developers/jebba/jebbadora/mlt.spec Seems 404 or so.. Also would you provide srpm so that we can download it easily? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 --- Comment #4 from jebba [EMAIL PROTECTED] 2008-09-10 04:14:39 EDT --- Mamoru Tasaka: Sorry I temporarily had moved that dir. Its back. A SRPM is also available: http://www.blagblagblag.org/pub/BLAG/developers/jebba/jebbadora/mlt.spec http://www.blagblagblag.org/pub/BLAG/developers/jebba/jebbadora/mlt-0.3.0-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Mamoru Tasaka [EMAIL PROTECTED] changed: What|Removed |Added CC||[EMAIL PROTECTED] --- Comment #5 from Mamoru Tasaka [EMAIL PROTECTED] 2008-09-10 13:00:14 EDT --- Well, some quick notes for 0.3.0-2: * License - As far as I checked the whole codes, the license tag should be GPLv2+ and LGPLv2+. * Groups - Is the Group tag Development/Libraries proper? (maybe Development/Tools)? * ExcludeArch - Even on ppc this does not build: http://koji.fedoraproject.org/koji/taskinfo?taskID=817251 Some codes seems to be using heavily i386 dependent codes and perhaps this package only supports i386? * compilation flags, debug info - compilation flags -O4 -fomit-frame-pointer -ffast-math makes debugging very difficult and Fedora does not allow these flags. - Also, automated stripping of binaries is forbidden because this prevents from making correct debuginfo rpm. For example: - 425 make[1]: Entering directory `/builddir/build/BUILD/mlt-0.3.0/src/inigo' 426 install -d /builddir/build/BUILDROOT/mlt-0.3.0-2.fc10.i386/usr/bin 427 install -c -s -m 755 inigo /builddir/build/BUILDROOT/mlt-0.3.0-2.fc10.i386/usr/bin 428 make[1]: Leaving directory `/builddir/build/BUILD/mlt-0.3.0/src/inigo' - install command option -s must be removed. * %defattr - Now we recommend %defattr(-,root,root,-) * %doc - Perhaps %doc docs/ (not %doc docs/*) is better (this keeps directory structure) * Directory ownership issue - The directory %_libdir/%name is not owned by any packages. ! By the way should files under %_libdir/%name really be in -devel subpackage? Usually these are modules of main binary and should not be in -devel subpackage. * rpmlint issue -- mlt-devel.i386: W: executable-stack /usr/lib/mlt/libmltgtk2.so -- - rpmlint -I executable-stack shows the explanation, however I don't know what to do for this... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=459979
Yaakov Nemoy [EMAIL PROTECTED] changed:
What|Removed |Added
CC||[EMAIL PROTECTED]
--- Comment #1 from Yaakov Nemoy [EMAIL PROTECTED] 2008-08-26 21:51:34 EDT
---
- MUST: rpmlint must be run on every package. The output should be posted in
the review.
mlt-devel.i386: W: no-documentation
mlt-devel.i386: W: executable-stack /usr/lib/mlt/libmltgtk2.so
Not sure about the first one, no clue what the second one means, but it is
probably a problem in the compilation process of the package itself.
- MUST: The package must be named according to the Package Naming Guidelines .
CHECK
- MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption on Package Naming Guidelines
.
CHECK
- MUST: The package must meet the Packaging Guidelines .
BuildRoot needs to follow the guidelines. The following value is recommended.
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
- MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
CHECK
- MUST: The License field in the package spec file must match the actual
license.
CHECK
- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
CHECK
- MUST: The spec file must be written in American English.
CHECK
- MUST: The spec file for the package MUST be legible. If the reviewer is
unable to read the spec file, it will be impossible to perform a review. Fedora
is not the place for entries into the Obfuscated Code Contest
(http://www.ioccc.org/).
CHECK - for some values of legible ;) (next time use better handwriting)
- MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
No url provided.
MD5 matches with the source package from sourceforge, nonetheless.
- MUST: The package must successfully compile and build into binary rpms on at
least one supported architecture.
Tested on i386, works.
- MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch needs to have a bug filed
in bugzilla, describing the reason that the package does not compile/build/work
on that architecture. The bug number should then be placed in a comment, next
to the corresponding ExcludeArch line. New packages will not have bugzilla
entries during the review process, so they should put this description in the
comment until the package is approved, then file the bugzilla entry, and
replace the long explanation with the bug number. The bug should be marked as
blocking one (or more) of the following bugs to simplify tracking such issues:
FE-ExcludeArch-x86 , FE-ExcludeArch-x64 , FE-ExcludeArch-ppc ,
FE-ExcludeArch-ppc64
Not tested on any other architectures.
- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
CHECK
- MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
Not applicable (?)
- MUST: Every binary RPM package which stores shared library files (not just
symlinks) in any of the dynamic linker's default paths, must call ldconfig in
%post and %postun. If the package has multiple subpackages with libraries, each
subpackage should also have a %post/%postun section that calls /sbin/ldconfig.
An example of the correct syntax for this is:
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
CHECK
- MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.
Not Applicable
- MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. Refer to the Guidelines for examples.
CHECK (but someone who does the actual review, please double check)
- MUST: A package must not contain any duplicate files in the %files listing.
CHECK
- MUST: Permissions on files must be set properly. Executables should be set
with executable
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=459979
--- Comment #2 from jebba [EMAIL PROTECTED] 2008-08-26 22:26:59 EDT ---
***
mlt-devel.i386: W: no-documentation
Does the -devel package need a LICENSE or something? I'd think not since it
Requires: the main package.
***
mlt-devel.i386: W: executable-stack /usr/lib/mlt/libmltgtk2.so
I have no clue here.
***
%(mktemp -ud %{_tmppath}/%{name}-%{version}-%{release}-XX)
I changed my BuildRoot: to that. I had a more commonly used one before.
***
No url provided.
Now using full URL to source:
http://downloads.sourceforge.net/mlt/%{name}-%{version}.tar.gz
***
Not tested on any other architectures.
This package does *not* compile on x86_64, croaking on some assembly...
Untested on ppc. I added ExcludeArch: x86_64.
***
To -devel section, added:
Requires: pkgconfig
***
-devel section, fixed:
Requires: %{name} = %{version}-%{release}
Revised packages here (0.3.0-2):
ftp://ftp.blagblagblag.org/pub/BLAG/developers/jebba/jebbadora/mlt.spec
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.
___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review
[Bug 459979] Review Request: mlt - Toolkit for broadcasters, video editors, media players, transcoders
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 jebba [EMAIL PROTECTED] changed: What|Removed |Added Blocks||177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ Fedora-package-review mailing list Fedora-package-review@redhat.com http://www.redhat.com/mailman/listinfo/fedora-package-review
