[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text

2008-08-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460629





--- Comment #8 from Lubomir Rintel [EMAIL PROTECTED]  2008-08-31 06:11:33 EDT 
---
Thanks; Imported and built.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text

2008-08-31 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460629


Lubomir Rintel [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|ASSIGNED|CLOSED
 Resolution||NEXTRELEASE




-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text

2008-08-30 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460629





--- Comment #7 from Kevin Fenzi [EMAIL PROTECTED]  2008-08-30 17:07:35 EDT ---
cvs done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text

2008-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460629





--- Comment #1 from Lubomir Rintel [EMAIL PROTECTED]  2008-08-29 04:36:02 EDT 
---
Built in el5 mock; rpmlint silent.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text

2008-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460629


Parag AN(पराग) [EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
 CC||[EMAIL PROTECTED]
 AssignedTo|[EMAIL PROTECTED]|[EMAIL PROTECTED]




--- Comment #2 from Parag AN(पराग) [EMAIL PROTECTED]  2008-08-29 04:46:43 EDT 
---
looks like missing
BuildRequires:  perl(Test::More)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text

2008-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460629


Marek Mahut [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]
Customer Facing||---




--- Comment #3 from Marek Mahut [EMAIL PROTECTED]  2008-08-29 04:58:11 EDT ---
Lubomir,

Please fix BR and this cosmetic issue:

perl-Pod-Simple-Wiki.src: E: description-line-too-long It currently contains
the following output filters: Confluence, Kwiki, Mediawiki,

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text

2008-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460629





--- Comment #4 from Lubomir Rintel [EMAIL PROTECTED]  2008-08-29 05:29:55 EDT 
---
You both have broken build roots and broken rpmlint! :)

SPEC: http://netbsd.sk/~lkundrak/SPECS/perl-Pod-Simple-Wiki.spec
SRPM: http://netbsd.sk/~lkundrak/SRPMS/perl-Pod-Simple-Wiki-0.09-3.el5.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text

2008-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460629





--- Comment #5 from Parag AN(पराग) [EMAIL PROTECTED]  2008-08-29 05:49:54 EDT 
---
Review:
+ package builds in mock (rawhide i386).
koji Build = http://koji.fedoraproject.org/koji/taskinfo?taskID=792829
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
9029379c5106b4d96a53ea1d83b68485  Pod-Simple-Wiki-0.09.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful
Files=25, Tests=184,  3 wallclock secs ( 0.17 usr  0.05 sys +  2.20 cusr  0.22
csys =  2.64 CPU)

+ Package perl-Pod-Simple-Wiki-0.09-3.fc10 =
Provides: perl(Pod::Simple::Wiki) = 0.09 perl(Pod::Simple::Wiki::Confluence) =
0.09 perl(Pod::Simple::Wiki::Kwiki) = 0.08 perl(Pod::Simple::Wiki::Mediawiki) =
0.08 perl(Pod::Simple::Wiki::Moinmoin) = 0.08 perl(Pod::Simple::Wiki::Template)
= 0.08 perl(Pod::Simple::Wiki::Tiddlywiki) = 0.08
perl(Pod::Simple::Wiki::Twiki) = 0.08 perl(Pod::Simple::Wiki::Usemod) = 0.08

Requires: /usr/bin/perl perl(Getopt::Long) perl(Pod::Simple)
perl(Pod::Simple::Wiki) perl(Pod::Usage) perl(strict) perl(vars)

Suggestions:-
1) I think you should remove
/usr/lib/perl5/vendor_perl/5.10.0/Pod/Simple/Wiki/Confluence.pm.escape from
installing in %files

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review


[Bug 460629] Review Request: perl-Pod-Simple-Wiki - Utility and perl classes for converting POD to Wiki text

2008-08-29 Thread bugzilla
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=460629





--- Comment #6 from Lubomir Rintel [EMAIL PROTECTED]  2008-08-29 09:01:31 EDT 
---
Thanks for the suggestion; I'll definitely remove that.
Also much thanks for the review!

New Package CVS Request
===
Package Name: perl-Pod-Simple-Wiki
Short Description: Utility and perl classes for converting POD to Wiki text
Owners: lkundrak
Branches: F-8 F-9 EL-5

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are on the CC list for the bug.

___
Fedora-package-review mailing list
Fedora-package-review@redhat.com
http://www.redhat.com/mailman/listinfo/fedora-package-review